Skip to contentSkip to conversation

crypto: ccp - fix error handling

PATCH In review Pavel Machek 4 participants 4 messages Sep 21, 2020 – Oct 2, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: ccp - fix error handling

Fix resource leak in error handling.

drivers/crypto/ccp/ccp-ops.c +1 -1
index bd270e66185e..40869ea1ed20 100644
@@ -1744,7 +1744,7 @@ ccp_run_sha_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
 			break;
 		default:
 			ret = -EINVAL;
-			goto e_ctx;
+			goto e_data;
 		}
 	} else {
 		/* Stash the context */
Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Pavel Machek

Fix resource leak in error handling.

Quoted 18 lines
drivers/crypto/ccp/ccp-ops.c +1 -1
index bd270e66185e..40869ea1ed20 100644
@@ -1744,7 +1744,7 @@ ccp_run_sha_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
 			break;
 		default:
 			ret = -EINVAL;
-			goto e_ctx;
+			goto e_data;
 		}
 	} else {
 		/* Stash the context */
Signature · 3 lines
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
maintainer
#2 lore raw
In reply to Pavel Machek
Quoted 1 line · Pavel Machek

Fix resource leak in error handling.

Does it need a Fixes: tag?

Thanks,
Tom

Quoted 17 lines
drivers/crypto/ccp/ccp-ops.c +1 -1
index bd270e66185e..40869ea1ed20 100644
@@ -1744,7 +1744,7 @@ ccp_run_sha_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
 			break;
 		default:
 			ret = -EINVAL;
-			goto e_ctx;
+			goto e_data;
 		}
 	} else {
 		/* Stash the context */