devlink: Use nla_policy to validate range
Subsystems (2)
cover devlink: Use nla_policy to validate range
This two small patches uses nla_policy to validate user specified fields are in valid range or not.
Patch summary:
Patch-1 checks the range of eswitch mode field
Patch-2 checks for the port type field. It eliminates a check in code by using nla policy infrastructure.
Parav Pandit (2):
devlink: Enhance policy to validate eswitch mode value
devlink: Enhance policy to validate port type input value
net/core/devlink.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.26.2
PATCH 1/2 devlink: Enhance policy to validate eswitch mode value
Use range checking facility of nla_policy to validate eswitch mode input attribute value is valid or not.
--- net/core/devlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/core/devlink.c +2 -1
@@ -7202,7 +7202,8 @@ static const struct nla_policy devlink_nl_policy[DEVLINK_ATTR_MAX + 1] = { [DEVLINK_ATTR_SB_POOL_THRESHOLD_TYPE] = { .type = NLA_U8 }, [DEVLINK_ATTR_SB_THRESHOLD] = { .type = NLA_U32 }, [DEVLINK_ATTR_SB_TC_INDEX] = { .type = NLA_U16 }, - [DEVLINK_ATTR_ESWITCH_MODE] = { .type = NLA_U16 }, + [DEVLINK_ATTR_ESWITCH_MODE ] =NLA_POLICY_RANGE (NLA_U16 ,DEVLINK_ESWITCH_MODE_LEGACY , + DEVLINK_ESWITCH_MODE_SWITCHDEV), [DEVLINK_ATTR_ESWITCH_INLINE_MODE] = { .type = NLA_U8 }, [DEVLINK_ATTR_ESWITCH_ENCAP_MODE] = { .type = NLA_U8 }, [DEVLINK_ATTR_DPIPE_TABLE_NAME] = { .type = NLA_NUL_STRING },
Signature · 1 line
2.26.2
PATCH 2/2 devlink: Enhance policy to validate port type input value
In reply to Parav PanditUse range checking facility of nla_policy to validate port type attribute input value is valid or not.
--- net/core/devlink.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
net/core/devlink.c +2 -3
@@ -867,8 +867,6 @@ static int devlink_port_type_set(struct devlink *devlink,int err;if (devlink->ops->port_type_set) { -if (port_type ==DEVLINK_PORT_TYPE_NOTSET ) -return -EINVAL ;if (port_type == devlink_port->type)return 0 ; err = devlink->ops->port_type_set (devlink_port, port_type);
@@ -7193,7 +7191,8 @@ static const struct nla_policy devlink_nl_policy[DEVLINK_ATTR_MAX + 1] = { [DEVLINK_ATTR_BUS_NAME] = { .type = NLA_NUL_STRING }, [DEVLINK_ATTR_DEV_NAME] = { .type = NLA_NUL_STRING }, [DEVLINK_ATTR_PORT_INDEX] = { .type = NLA_U32 }, - [DEVLINK_ATTR_PORT_TYPE] = { .type = NLA_U16 }, + [DEVLINK_ATTR_PORT_TYPE ] =NLA_POLICY_RANGE (NLA_U16 ,DEVLINK_PORT_TYPE_AUTO , + DEVLINK_PORT_TYPE_IB), [DEVLINK_ATTR_PORT_SPLIT_COUNT] = { .type = NLA_U32 }, [DEVLINK_ATTR_SB_INDEX] = { .type = NLA_U32 }, [DEVLINK_ATTR_SB_POOL_INDEX] = { .type = NLA_U16 },
Signature · 1 line
2.26.2
Quoted 2 lines · On Mon, 21 Sep 2020 19:41:28 +0300 Parav Pandit wrote:
This two small patches uses
nla_policyto validate user specified fields are in valid range or not.
David Miller
maintainerFrom: Parav Pandit <[email protected]>
Date: Mon, 21 Sep 2020 19:41:28 +0300
Quoted 7 lines
This two small patches uses
nla_policyto validate user specified fields are in valid range or not.Patch summary:
Patch-1 checks the range of eswitch mode field
Patch-2 checks for the port type field. It eliminates a check in code by using nla policy infrastructure.
Series applied, thanks.