Skip to contentSkip to conversation

i2c: nvidia-gpu: use dev_info for timeout error

PATCH In review Ajay Gupta 3 participants 3 messages Sep 21, 2020

Subsystems (2)
lore
Share & tools
lore

Ajay Gupta

author
#0 lore raw

PATCH 1/1 i2c: nvidia-gpu: use dev_info for timeout error

From: Ajay Gupta <[email protected]>

Timeout error may be seen due to missing i2c client such as USB Type-C UCSI controller on some NVIDIA GPU card. Currently we don't have a correct way to identify these cards.

Tools like Plymouth (splashscreen) doesn't like dev_err so changing timeout status log to dev_info.

Bug information:
https://bugzilla.kernel.org/show_bug.cgi?id=206653

---
 drivers/i2c/busses/i2c-nvidia-gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-nvidia-gpu.c +1 -1
index f480105000b8..17a8cefe5c45 100644
@@ -85,7 +85,7 @@ static int gpu_i2c_check_status(struct gpu_i2c_dev *i2cd)
 				 500, 1000 * USEC_PER_MSEC);
 
 	if (ret) {
-		dev_err(i2cd->dev, "i2c timeout error %x\n", val);
+		dev_info(i2cd->dev, "i2c timeout error %x\n", val);
 		return -ETIMEDOUT;
 	}
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · Ajay Gupta

From: Ajay Gupta <[email protected]>

Timeout error may be seen due to missing i2c client such as USB Type-C UCSI controller on some NVIDIA GPU card. Currently we don't have a correct way to identify these cards.

Quoted 7 lines

Tools like Plymouth (splashscreen) doesn't like dev_err so changing timeout status log to dev_info.

Bug information:
https://bugzilla.kernel.org/show_bug.cgi?id=206653

Hmm, a KERN_INFO message saying "error" does not make much sense. Maybe this is an argument to simply remove the message?

maintainer
#2 lore raw

Hi Wolfram,

Quoted 17 lines

-----Original Message-----
From: Wolfram Sang <[email protected]>
Sent: Monday, September 21, 2020 11:09 AM
To: Ajay Gupta <[email protected]>
Cc: [email protected]; Ajay Gupta <[email protected]>
Subject: Re: [PATCH] i2c: nvidia-gpu: use dev_info for timeout error

Quoted 9 lines · Ajay Gupta

From: Ajay Gupta <[email protected]>

Timeout error may be seen due to missing i2c client such as USB Type-C UCSI controller on some NVIDIA GPU card. Currently we don't have a correct way to identify these cards.

Tools like Plymouth (splashscreen) doesn't like dev_err so changing timeout status log to dev_info.

Quoted 7 lines
Quoted 4 lines

Bug information:
https://bugzilla.kernel.org/show_bug.cgi?id=206653

Hmm, a KERN_INFO message saying "error" does not make much sense. Maybe this is an argument to simply remove the message?

Sounds good. Client driver anyways gets probe error in case of a real i2c timeout with an existing i2c device and that can help debug.

Thanks

Quoted 1 line

nvpublic