Skip to contentSkip to conversation

package/freescale-imx/imx-dpu-g2d: new package

PATCH In review Refik Tuzakli 3 participants 4 messages Feb 8, 2020 – Aug 6, 2021 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 package/freescale-imx/imx-dpu-g2d: new package

imx-dpu-g2d package is used by i.MX 8 and i.MX 8X series instead of imx-vpu or imx-vpu-hantro. With this commit, imx-dpu-g2d is added and is enabled for i.MX8 and i.MX 8X.

---
 DEVELOPERS                                    |  1 +
 package/freescale-imx/Config.in               |  8 ++++
 package/freescale-imx/imx-dpu-g2d/Config.in   | 23 ++++++++++++
 .../imx-dpu-g2d/imx-dpu-g2d.hash              |  4 ++
 .../freescale-imx/imx-dpu-g2d/imx-dpu-g2d.mk  | 37 +++++++++++++++++++
 5 files changed, 73 insertions(+)
 create mode 100644 package/freescale-imx/imx-dpu-g2d/Config.in
 create mode 100644 package/freescale-imx/imx-dpu-g2d/imx-dpu-g2d.hash
 create mode 100644 package/freescale-imx/imx-dpu-g2d/imx-dpu-g2d.mk
DEVELOPERS +1 -0
index 3520072034..198b687d39 100644
@@ -2077,6 +2077,7 @@ F:	package/uhttpd/
 F:	package/ustream-ssl/
 
 N:	Refik Tuzakli <[email protected]>
+F:	package/freescale-imx/imx-dpu-g2d
 F:	package/paho-mqtt-cpp/
 
 N:	R??mi R??rolle <[email protected]>
package/freescale-imx/Config.in +8 -0
index 711e8f72c2..2343511c28 100644
@@ -79,6 +79,11 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VPU_HANTRO
 	bool
 	default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
 
+config BR2_PACKAGE_FREESCALE_IMX_HAS_DPU
+	bool
+	default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 || \
+		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
+
 config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU
 	bool
 	default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q || \
@@ -99,6 +104,9 @@ source "package/freescale-imx/imx-uuc/Config.in"
 source "package/freescale-imx/imx-vpu/Config.in"
 source "package/freescale-imx/imx-vpu-hantro/Config.in"
 source "package/freescale-imx/imx-vpuwrap/Config.in"
+if BR2_PACKAGE_FREESCALE_IMX_HAS_DPU
+source "package/freescale-imx/imx-dpu-g2d/Config.in"
+endif
 source "package/freescale-imx/firmware-imx/Config.in"
 source "package/freescale-imx/imx-sc-firmware/Config.in"
 if (BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51 || BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53)
package/freescale-imx/imx-dpu-g2d/Config.in new file +23 -0
new file mode 100644
index 0000000000..377ad31dcb
@@ -0,0 +1,23 @@
+comment "imx-dpu-g2d needs a glibc toolchain"
+	depends on BR2_aarch64
+	depends on !BR2_TOOLCHAIN_USES_GLIBC
+
+config BR2_PACKAGE_IMX_DPU_G2D
+	bool "imx-dpu-g2d"
+	# Library binaries are linked against libc.so.6
+	depends on BR2_TOOLCHAIN_USES_GLIBC
+	select BR2_PACKAGE_LIBDRM
+	help
+	  Userspace DPU 2D libraries for Vivante GPU on i.MX platforms.
+
+	  This library is provided by NXP as-is and doesn't have an
+	  upstream.
+
+if BR2_PACKAGE_IMX_DPU_G2D
+
+config BR2_PACKAGE_IMX_DPU_G2D_EXAMPLES
+	bool "install examples"
+	help
+	  Copy the Vivante DPU examples to the target.
+
+endif
package/freescale-imx/imx-dpu-g2d/imx-dpu-g2d.hash new file +4 -0
new file mode 100644
index 0000000000..50eee591c3
@@ -0,0 +1,4 @@
+# Locally calculated
+sha256	46c72ce9b98b7116e9f7f53a66aadc8fb66910473477c6553db77ed71e54d7ea  imx-dpu-g2d-1.8.2.bin
+sha256  d55f024af2bfff714b90de596f6d0399124b999e8c18a86b13a3b507bae6f561  COPYING
+sha256  9665930f69c0b6f4a4c055d7fe2b8ee563e771efbc83892abb1955e61492cdf7  EULA
package/freescale-imx/imx-dpu-g2d/imx-dpu-g2d.mk new file +37 -0
new file mode 100644
index 0000000000..ea5bbb9f97
@@ -0,0 +1,37 @@
+################################################################################
+#
+# imx-dpu-g2d
+#
+################################################################################
+
+IMX_DPU_G2D_VERSION = 1.8.2
+IMX_DPU_G2D_SITE = $(FREESCALE_IMX_SITE)
+IMX_DPU_G2D_SOURCE = imx-dpu-g2d-$(IMX_DPU_G2D_VERSION).bin
+IMX_DPU_G2D_DEPENDENCIES = libdrm
+IMX_DPU_G2D_INSTALL_STAGING = YES
+
+IMX_DPU_G2D_LICENSE = NXP Semiconductor Software License Agreement
+IMX_DPU_G2D_LICENSE_FILES = EULA COPYING
+IMX_DPU_G2D_REDISTRIBUTE = NO
+
+define IMX_DPU_G2D_EXTRACT_CMDS
+	$(call FREESCALE_IMX_EXTRACT_HELPER,$(IMX_DPU_G2D_DL_DIR)/$(IMX_DPU_G2D_SOURCE))
+endef
+
+define IMX_DPU_G2D_INSTALL_STAGING_CMDS
+	cp -dpfr $(@D)/g2d/usr/* $(STAGING_DIR)/usr
+endef
+
+ifeq ($(BR2_PACKAGE_IMX_DPU_G2D_EXAMPLES),y)
+define IMX_DPU_G2D_INSTALL_EXAMPLES
+	mkdir -p $(TARGET_DIR)/usr/share/examples/
+	cp -dpfr $(@D)/gpu-demos/opt/* $(TARGET_DIR)/usr/share/examples/
+endef
+endif
+
+define IMX_DPU_G2D_INSTALL_TARGET_CMDS
+	$(IMX_DPU_G2D_INSTALL_EXAMPLES)
+	cp -dpfr $(@D)/g2d/usr/lib $(TARGET_DIR)/usr
+endef
+
+$(eval $(generic-package))
Signature · 1 line
2.17.1
#1 lore raw

PATCH v3 1/1 package/freescale-imx/imx-dpu-g2d: new package

Hi,

Quoted 3 lines · Refik Tuzakli

imx-dpu-g2d package is used by i.MX 8 and i.MX 8X series instead of imx-vpu or imx-vpu-hantro. With this commit, imx-dpu-g2d is added and is enabled for i.MX8 and i.MX 8X.

My review on v2 [1] still applies here, this has nothing to do with VPU operations.

Quoted 57 lines
---
 DEVELOPERS                                    |  1 +
 package/freescale-imx/Config.in               |  8 ++++
 package/freescale-imx/imx-dpu-g2d/Config.in   | 23 ++++++++++++
 .../imx-dpu-g2d/imx-dpu-g2d.hash              |  4 ++
 .../freescale-imx/imx-dpu-g2d/imx-dpu-g2d.mk  | 37 +++++++++++++++++++
 5 files changed, 73 insertions(+)
 create mode 100644 package/freescale-imx/imx-dpu-g2d/Config.in
 create mode 100644 package/freescale-imx/imx-dpu-g2d/imx-dpu-g2d.hash
 create mode 100644 package/freescale-imx/imx-dpu-g2d/imx-dpu-g2d.mk
DEVELOPERS +1 -0
index 3520072034..198b687d39 100644
@@ -2077,6 +2077,7 @@ F:	package/uhttpd/
 F:	package/ustream-ssl/
 
 N:	Refik Tuzakli <[email protected]>
+F:	package/freescale-imx/imx-dpu-g2d
 F:	package/paho-mqtt-cpp/
 
 N:	R?mi R?rolle <[email protected]>
package/freescale-imx/Config.in +8 -0
index 711e8f72c2..2343511c28 100644
@@ -79,6 +79,11 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VPU_HANTRO
 	bool
 	default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M
 
+config BR2_PACKAGE_FREESCALE_IMX_HAS_DPU
+	bool
+	default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 || \
+		BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X
+
 config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU
 	bool
 	default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q || \
@@ -99,6 +104,9 @@ source "package/freescale-imx/imx-uuc/Config.in"
 source "package/freescale-imx/imx-vpu/Config.in"
 source "package/freescale-imx/imx-vpu-hantro/Config.in"
 source "package/freescale-imx/imx-vpuwrap/Config.in"
+if BR2_PACKAGE_FREESCALE_IMX_HAS_DPU
+source "package/freescale-imx/imx-dpu-g2d/Config.in"
+endif
 source "package/freescale-imx/firmware-imx/Config.in"
 source "package/freescale-imx/imx-sc-firmware/Config.in"
 if (BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51 || BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53)
package/freescale-imx/imx-dpu-g2d/Config.in new file +1 -0
new file mode 100644
index 0000000000..377ad31dcb
@@ -0,0 +1,23 @@
+comment "imx-dpu-g2d needs a glibc toolchain"

package/freescale-imx/imx-dpu-g2d/Config.in line 11

Quoted 10 lines
package/freescale-imx/imx-dpu-g2d/Config.in new file +10 -0
+	depends on BR2_aarch64
+	depends on !BR2_TOOLCHAIN_USES_GLIBC
+
+config BR2_PACKAGE_IMX_DPU_G2D
+	bool "imx-dpu-g2d"
+	# Library binaries are linked against libc.so.6
+	depends on BR2_TOOLCHAIN_USES_GLIBC
+	select BR2_PACKAGE_LIBDRM
+	help
+	  Userspace DPU 2D libraries for Vivante GPU on i.MX platforms.

Also, this is not Vivante-related either.

package/freescale-imx/imx-dpu-g2d/Config.in line 21

Quoted 9 lines
package/freescale-imx/imx-dpu-g2d/Config.in new file +9 -0
+	  This library is provided by NXP as-is and doesn't have an
+	  upstream.
+
+if BR2_PACKAGE_IMX_DPU_G2D
+
+config BR2_PACKAGE_IMX_DPU_G2D_EXAMPLES
+	bool "install examples"
+	help
+	  Copy the Vivante DPU examples to the target.

Ditto.

Quoted 44 lines
package/freescale-imx/imx-dpu-g2d/Config.in new file +1 -0
+endif
package/freescale-imx/imx-dpu-g2d/imx-dpu-g2d.hash new file +4 -0
new file mode 100644
index 0000000000..50eee591c3
@@ -0,0 +1,4 @@
+# Locally calculated
+sha256	46c72ce9b98b7116e9f7f53a66aadc8fb66910473477c6553db77ed71e54d7ea  imx-dpu-g2d-1.8.2.bin
+sha256  d55f024af2bfff714b90de596f6d0399124b999e8c18a86b13a3b507bae6f561  COPYING
+sha256  9665930f69c0b6f4a4c055d7fe2b8ee563e771efbc83892abb1955e61492cdf7  EULA
package/freescale-imx/imx-dpu-g2d/imx-dpu-g2d.mk new file +27 -0
new file mode 100644
index 0000000000..ea5bbb9f97
@@ -0,0 +1,37 @@
+################################################################################
+#
+# imx-dpu-g2d
+#
+################################################################################
+
+IMX_DPU_G2D_VERSION = 1.8.2
+IMX_DPU_G2D_SITE = $(FREESCALE_IMX_SITE)
+IMX_DPU_G2D_SOURCE = imx-dpu-g2d-$(IMX_DPU_G2D_VERSION).bin
+IMX_DPU_G2D_DEPENDENCIES = libdrm
+IMX_DPU_G2D_INSTALL_STAGING = YES
+
+IMX_DPU_G2D_LICENSE = NXP Semiconductor Software License Agreement
+IMX_DPU_G2D_LICENSE_FILES = EULA COPYING
+IMX_DPU_G2D_REDISTRIBUTE = NO
+
+define IMX_DPU_G2D_EXTRACT_CMDS
+	$(call FREESCALE_IMX_EXTRACT_HELPER,$(IMX_DPU_G2D_DL_DIR)/$(IMX_DPU_G2D_SOURCE))
+endef
+
+define IMX_DPU_G2D_INSTALL_STAGING_CMDS
+	cp -dpfr $(@D)/g2d/usr/* $(STAGING_DIR)/usr
+endef
+
+ifeq ($(BR2_PACKAGE_IMX_DPU_G2D_EXAMPLES),y)
+define IMX_DPU_G2D_INSTALL_EXAMPLES
+	mkdir -p $(TARGET_DIR)/usr/share/examples/

package/freescale-imx/imx-dpu-g2d/imx-dpu-g2d.mk line 37

Quoted 10 lines
package/freescale-imx/imx-dpu-g2d/imx-dpu-g2d.mk new file +10 -0
+	cp -dpfr $(@D)/gpu-demos/opt/* $(TARGET_DIR)/usr/share/examples/
+endef
+endif
+
+define IMX_DPU_G2D_INSTALL_TARGET_CMDS
+	$(IMX_DPU_G2D_INSTALL_EXAMPLES)
+	cp -dpfr $(@D)/g2d/usr/lib $(TARGET_DIR)/usr
+endef
+
+$(eval $(generic-package))

Regards,
Gary

[1] http://patchwork.ozlabs.org/project/buildroot/patch/20200203193155.12657-2-tuzakli.refik at gmail.com/#2359160

#2 lore raw
In reply to Refik Tuzakli

Hello Refik,

Quoted 5 lines · On Sat, 8 Feb 2020 16:49:50 +0300 Refik Tuzakli <[email protected]>…

imx-dpu-g2d package is used by i.MX 8 and i.MX 8X series instead of imx-vpu or imx-vpu-hantro. With this commit, imx-dpu-g2d is added and is enabled for i.MX8 and i.MX 8X.

So I wanted to apply this, but except Gary's feedback, there is still one issue. When I look at the libraries libg2d-dpu.so.1.6.0 is linked with, I see:

 0x0000000000000001 (NEEDED)             Shared library: [libdrm.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [libOpenCL.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [ld-linux-aarch64.so.1]

So libc/ld-linux-aarch64 are part of the C library, libdrm.so is taken care of by the libdrm dependency... but what about libOpenCL ? What package is supposed to provide that in this context ?

Gary: I know you said this imx-dpu-g2d package is independent of the GPU, but here it links against OpenCL... which I guess is provided by imx-gpu-viv.

Note: I looked at version 1.8.14 of imx-dpu-g2d.

Could you give me some insight here, and once we resolve this issue, submit a v4, also taking into account the feedback from Gary?

Best regards,

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#3 lore raw

Hi Thomas,

Quoted 20 lines · Thomas Petazzoni

Hello Refik,

Quoted 5 lines · On Sat, 8 Feb 2020 16:49:50 +0300 Refik Tuzakli <[email protected]>…

imx-dpu-g2d package is used by i.MX 8 and i.MX 8X series instead of imx-vpu or imx-vpu-hantro. With this commit, imx-dpu-g2d is added and is enabled for i.MX8 and i.MX 8X.

So I wanted to apply this, but except Gary's feedback, there is still one issue. When I look at the libraries libg2d-dpu.so.1.6.0 is linked with, I see:

 0x0000000000000001 (NEEDED)             Shared library: [libdrm.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [libOpenCL.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [ld-linux-aarch64.so.1]
Quoted 7 lines

So libc/ld-linux-aarch64 are part of the C library, libdrm.so is taken care of by the libdrm dependency... but what about libOpenCL ? What package is supposed to provide that in this context ?

Gary: I know you said this imx-dpu-g2d package is independent of the GPU, but here it links against OpenCL... which I guess is provided by imx-gpu-viv.

Yes I said that ;) But to be honest I've never used any i.MX 8QM / 8QXP CPUs, mainly the M series.
So the DPU package, on paper, is supposed to provide the same G2D API as the other package using the Display Controller (DPU) of those processors to do the 2D operations.
So the theory is that it has nothing to do with the GPU. But in recent releases they indeed added a runtime dependency to OpenCL as the package needs it for HEVC tile format coming out of the VPU [1].

Regards,
Gary

[1] https://github.com/Freescale/meta-freescale/commit/0661394c
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot