leds: lm3552: Fix warnings for undefined parameters
PATCH 1/2 leds: lm3552: Fix warnings for undefined parameters
Fix warnings for undefined parameters when W=1 is used.
--- drivers/leds/leds-lm3532.c | 50 +++++++++++++++++++------------------- 1 file changed, 25 insertions(+), 25 deletions(-)
drivers/leds/leds-lm3532.c +25 -25
@@ -96,15 +96,15 @@/* * struct lm3532_als_data -* @config - value of ALS configuration register -* @als1_imp_sel - value of ALS1 resistor select register -* @als2_imp_sel - value of ALS2 resistor select register -* @als_avrg_time - ALS averaging time -* @als_input_mode - ALS input mode for brightness control -* @als_vmin - Minimum ALS voltage -* @als_vmax - Maximum ALS voltage -* @zone_lo - values of ALS lo ZB(Zone Boundary) registers -* @zone_hi - values of ALS hi ZB(Zone Boundary) registers +* @config: value of ALS configuration register +* @als1_imp_sel: value of ALS1 resistor select register +* @als2_imp_sel: value of ALS2 resistor select register +* @als_avrg_time: ALS averaging time +* @als_input_mode: ALS input mode for brightness control +* @als_vmin: Minimum ALS voltage +* @als_vmax: Maximum ALS voltage +* @zone_lo: values of ALS lo ZB(Zone Boundary) registers +* @zone_hi: values of ALS hi ZB(Zone Boundary) registers */ struct lm3532_als_data {u8 config;
@@ -121,14 +121,14 @@ struct lm3532_als_data {/** * struct lm3532_led * @led_dev: led class device -* @priv - Pointer the device data structure -* @control_bank - Control bank the LED is associated to -* @mode - Mode of the LED string -* @ctrl_brt_pointer - Zone target register that controls the sink -* @num_leds - Number of LED strings are supported in this array -* @full_scale_current - The full-scale current setting for the current sink. -* @led_strings - The LED strings supported in this array -* @enabled - Enabled status +* @priv: Pointer the device data structure +* @control_bank: Control bank the LED is associated to +* @mode: Mode of the LED string +* @ctrl_brt_pointer: Zone target register that controls the sink +* @num_leds: Number of LED strings are supported in this array +* @full_scale_current: The full-scale current setting for the current sink. +* @led_strings: The LED strings supported in this array +* @enabled: Enabled status */ struct lm3532_led {struct led_classdev led_dev;
@@ -145,16 +145,16 @@ struct lm3532_led {/** * struct lm3532_data -* @enable_gpio - Hardware enable gpio +* @enable_gpio: Hardware enable gpio * @regulator: regulator * @client: i2c client -* @regmap - Devices register map -* @dev - Pointer to the devices device struct -* @lock - Lock for reading/writing the device -* @als_data - Pointer to the als data struct -* @runtime_ramp_up - Runtime ramp up setting -* @runtime_ramp_down - Runtime ramp down setting -* @leds - Array of LED strings +* @regmap: Devices register map +* @dev: Pointer to the devices device struct +* @lock: Lock for reading/writing the device +* @als_data: Pointer to the als data struct +* @runtime_ramp_up: Runtime ramp up setting +* @runtime_ramp_down: Runtime ramp down setting +* @leds: Array of LED strings */ struct lm3532_data {struct gpio_desc *enable_gpio;
Signature · 1 line
2.28.0
PATCH 2/2 leds: lm36274: Fix warning for undefined parameters
Fix warnings for undefined parameters when building with W=1.
--- drivers/leds/leds-lm36274.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/leds/leds-lm36274.c +3 -2
@@ -26,8 +26,8 @@* @lmu_data: Register and setting values for common code * @regmap: Devices register map * @dev: Pointer to the devices device struct -* @led_sources - The LED strings supported in this array -* @num_leds - Number of LED strings are supported in this array +* @led_sources: The LED strings supported in this array +* @num_leds: Number of LED strings are supported in this array */ struct lm36274 {struct platform_device *pdev;
@@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver = { .probe = lm36274_probe, .driver = { .name = "lm36274-leds", + .of_match_table = of_lm36274_leds_match, }, };module_platform_driver (lm36274_driver)
Signature · 1 line
2.28.0
Re: [PATCH 2/2] leds: lm36274: Fix warning for undefined parameters
Quoted 24 lines · On Tue, 22 Sep 2020 14:06:38 -0500 Dan Murphy <[email protected]> wrote:
Fix warnings for undefined parameters when building with W=1.
Fixes 11e1bbc116a75 ("leds: lm36274: Introduce the TI LM36274 LED driver")Signed-off-by Dan Murphy <[email protected]>--- drivers/leds/leds-lm36274.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/leds/leds-lm36274.c +2
-2@@ -26,8 +26,8 @@* @lmu_data: Register and setting values for common code * @regmap: Devices register map * @dev: Pointer to the devices device struct -* @led_sources - The LED strings supported in this array -* @num_leds - Number of LED strings are supported in this array +* @led_sources: The LED strings supported in this array +* @num_leds: Number of LED strings are supported in this array */ struct lm36274 {struct platform_device *pdev;
drivers/leds/leds-lm36274.c static struct platform_driver lm36274_driver = { · line 169
Quoted 7 lines
drivers/leds/leds-lm36274.c +1
-0@@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver = { .probe = lm36274_probe, .driver = { .name = "lm36274-leds", + .of_match_table = of_lm36274_leds_match, }, };module_platform_driver (lm36274_driver)
Re: [PATCH 2/2] leds: lm36274: Fix warning for undefined parameters
In reply to Dan MurphyQuoted 2 lines · Dan Murphy
Fix warnings for undefined parameters when building with W=1.
It also adds of_match_table. I guess that's okay.
I'll remove the fixes tags as I don't believe these need to go to stable.
Best regards,
Pavel
Quoted 31 lines
Fixes 11e1bbc116a75 ("leds: lm36274: Introduce the TI LM36274 LED driver")Signed-off-by Dan Murphy <[email protected]>--- drivers/leds/leds-lm36274.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/leds/leds-lm36274.c +3
-2@@ -26,8 +26,8 @@* @lmu_data: Register and setting values for common code * @regmap: Devices register map * @dev: Pointer to the devices device struct -* @led_sources - The LED strings supported in this array -* @num_leds - Number of LED strings are supported in this array +* @led_sources: The LED strings supported in this array +* @num_leds: Number of LED strings are supported in this array */ struct lm36274 {struct platform_device *pdev;@@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver = { .probe = lm36274_probe, .driver = { .name = "lm36274-leds", + .of_match_table = of_lm36274_leds_match, }, };module_platform_driver (lm36274_driver)Signature · 1 line
2.28.0
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Wrong subject, it says
lm3552
but driver is called
lm3532
Besides this:
Quoted 8 lines · Marek Behun
Wrong subject, it says
lm3552
but driver is called
lm3532Besides this:
Reviewed-by Marek Behún <[email protected]>
Thanks for review!
Best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html