x86/msi: Fold pci_conf_write16() calls in write_msi_msg()
PATCH 1/1 x86/msi: Fold pci_conf_write16() calls in write_msi_msg()
In addition, this removes the unqualified 0/1 passed to msi_data_reg()
No functional change.
Signed-off-by Andrew Cooper <[email protected]>
---
CC: Jan Beulich <[email protected]>
CC: Roger Pau Monné <[email protected]>
CC: Wei Liu <[email protected]>
--- xen/arch/x86/msi.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
xen/arch/x86/msi.c +2 -5
@@ -214,13 +214,10 @@ static int write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)pci_conf_write32 (dev->sbdf,msi_lower_address_reg (pos), msg->address_lo);if ( entry->msi_attrib.is_64 ) - {pci_conf_write32 (dev->sbdf,msi_upper_address_reg (pos), msg->address_hi); -pci_conf_write16 (dev->sbdf,msi_data_reg (pos,1 ), msg->data); - } -else -pci_conf_write16 (dev->sbdf,msi_data_reg (pos,0 ), msg->data); +pci_conf_write16 (dev->sbdf,msi_data_reg (pos, entry->msi_attrib.is_64), + msg->data);break ; }case PCI_CAP_ID_MSIX :
Signature · 1 line
2.11.0
Quoted 5 lines · Andrew Cooper
In addition, this removes the unqualified 0/1 passed to
msi_data_reg()No functional change.
Signed-off-by Andrew Cooper <[email protected]>
Acked-by Jan Beulich <[email protected]>