Skip to contentSkip to conversation

package/libvpx: vp9 encoder needs c++

PATCH New Bernd Kuhls 2 participants 2 messages Sep 23, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libvpx: vp9 encoder needs c++

Encoding rate control interface for v9 is implemented in c++:
https://github.com/webmproject/libvpx/commit/745979bc2913b4f26847084699d9fddd68b60410#diff-58f26933c120328b31831a743eec5ba3R534

Disable vp9 encoding when toolchain lacks c++.

Fixes:
http://autobuild.buildroot.net/results/983/9836215fe22f260483f9153fb5447892801a14a9/
http://autobuild.buildroot.net/results/88a/88aa80ee006ba2dcc40c15be3af73c756cb62974/

---
 package/libvpx/libvpx.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/libvpx/libvpx.mk +7 -0
index c7245885d9..26d211cf86 100644
@@ -20,6 +20,13 @@ LIBVPX_CONF_OPTS = \
 	--disable-docs \
 	--disable-unit-tests
 
+# vp9/ratectrl_rtc.cc
+ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
+LIBVPX_CONF_OPTS += --enable-vp9-encoder
+else
+LIBVPX_CONF_OPTS += --disable-vp9-encoder
+endif
+
 # This is not a true autotools package.  It is based on the ffmpeg build system
 define LIBVPX_CONFIGURE_CMDS
 	(cd $(LIBVPX_SRCDIR) && rm -rf config.cache && \
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 package/libvpx: vp9 encoder needs c++

Quoted 5 lines · On Wed, 23 Sep 2020 20:08:30 +0200 Bernd Kuhls <[email protected]> wrote:

Encoding rate control interface for v9 is implemented in c++:
https://github.com/webmproject/libvpx/commit/745979bc2913b4f26847084699d9fddd68b60410#diff-58f26933c120328b31831a743eec5ba3R534

Disable vp9 encoding when toolchain lacks c++.

Quoted 8 lines

Fixes:
http://autobuild.buildroot.net/results/983/9836215fe22f260483f9153fb5447892801a14a9/
http://autobuild.buildroot.net/results/88a/88aa80ee006ba2dcc40c15be3af73c756cb62974/

---
 package/libvpx/libvpx.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com