ARM: dts: stm32: Enable thermal sensor support on stm32mp15xx-dhcor
PATCH 1/1 ARM: dts: stm32: Enable thermal sensor support on stm32mp15xx-dhcor
Enable STM32 Digital Thermal Sensor driver for stm32mp15xx-dhcor SoMs.
--- arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi +4 -0
@@ -21,6 +21,10 @@ memory@c0000000 { }; }; +&dts { + status = "okay"; +}; + &i2c4 { pinctrl-names = "default"; pinctrl-0 = <&i2c4_pins_a>;
Signature · 7 lines
2.28.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 4 lines · Marek Vasut
Enable STM32 Digital Thermal Sensor driver for stm32mp15xx-dhcor SoMs.
Fixes 94cafe1b6482 ("ARM: dts: stm32: Add Avenger96 devicetree supportbased on STM32MP157A")
The change looks good but what does this patch fixes?
Thanks,
Mani
Quoted 25 lines
Signed-off-by Marek Vasut <[email protected]>Cc Alexandre Torgue <[email protected]>Cc Manivannan Sadhasivam <[email protected]>To: [email protected]
---arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi| 4 ++++1 file changed, 4 insertions(+)arch/arm/boot/dts/stm32mp15xx-dhcor-som.dtsi +4
-0@@ -21,6 +21,10 @@ memory@c0000000 { }; }; +&dts { + status = "okay"; +}; + &i2c4 { pinctrl-names = "default"; pinctrl-0 = <&i2c4_pins_a>;
Signature · 6 lines
Sent from my Android device with K-9 Mail. Please excuse my brevity. _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 9 lines · Manivannan Sadhasivam
Quoted 4 lines · Marek Vasut
Enable STM32 Digital Thermal Sensor driver for stm32mp15xx-dhcor SoMs.
Fixes 94cafe1b6482 ("ARM: dts: stm32: Add Avenger96 devicetree supportbased on STM32MP157A")
The change looks good but what does this patch fixes?
The missing temp sensor, which helps you detect overheat of the SoC. That is esp. important on the 800 MHz AV96.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 8 lines · Marek Vasut
Quoted 3 lines · Manivannan Sadhasivam
On 24 September 2020 4:55:35 AM IST, Marek Vasut <[email protected]>
Quoted 1 line · wrote:
Quoted 1 line
Enable STM32 Digital Thermal Sensor driver for stm32mp15xx-dhcor
SoMs.
Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Fixes 94cafe1b6482 ("ARM: dts: stm32: Add Avenger96 devicetreesupport
Quoted 3 lines
Quoted 1 line
based on STM32MP157A")
The change looks good but what does this patch fixes?
The missing temp sensor, which helps you detect overheat of the SoC. That is esp. important on the 800 MHz AV96.
This doesn't quality as a "fix". Essentially you're just adding a missing feature and not fixing any issues. So please remove the fixes tag and resubmit.
Thanks,
Mani
Signature · 6 lines
Sent from my Android device with K-9 Mail. Please excuse my brevity. _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 13 lines · Manivannan Sadhasivam
Quoted 10 lines · Marek Vasut
Quoted 3 lines · Manivannan Sadhasivam
On 24 September 2020 4:55:35 AM IST, Marek Vasut <[email protected]>
Quoted 1 line · wrote:
Quoted 1 line
Enable STM32 Digital Thermal Sensor driver for stm32mp15xx-dhcor
SoMs.
Quoted 2 lines
Quoted 2 lines
Fixes 94cafe1b6482 ("ARM: dts: stm32: Add Avenger96 devicetreesupport
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
based on STM32MP157A")
The change looks good but what does this patch fixes?
The missing temp sensor, which helps you detect overheat of the SoC. That is esp. important on the 800 MHz AV96.
This doesn't quality as a "fix". Essentially you're just adding a missing feature and not fixing any issues. So please remove the fixes tag and resubmit.
I would argue that if the system overheats and crashes, we want to know about that, possibly in advance so thermal throttling can be applied. Currently this is not possible and I think that is a bug.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Manivannan Sadhasivam
Reviewed-byQuoted 18 lines · Marek Vasut
Quoted 17 lines · Manivannan Sadhasivam
Quoted 14 lines · Marek Vasut
Quoted 3 lines · Manivannan Sadhasivam
On 24 September 2020 4:55:35 AM IST, Marek Vasut <[email protected]>
Quoted 1 line · wrote:
Quoted 1 line
Enable STM32 Digital Thermal Sensor driver for stm32mp15xx-dhcor
SoMs.
Quoted 2 lines
Quoted 2 lines
Fixes 94cafe1b6482 ("ARM: dts: stm32: Add Avenger96 devicetreesupport
Quoted 3 lines
Quoted 1 line
based on STM32MP157A")
The change looks good but what does this patch fixes?
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
The missing temp sensor, which helps you detect overheat of the SoC. That is esp. important on the 800 MHz AV96.
This doesn't quality as a "fix". Essentially you're just adding a missing feature and not fixing any issues. So please remove the fixes tag and resubmit.
I would argue that if the system overheats and crashes, we want to know about that, possibly in advance so thermal throttling can be applied. Currently this is not possible and I think that is a bug.
No, this is not a _bug_. This is a missing feature that the current kernel doesn't support and you know about that! The fact that you can trigger a crash due to hw limitation doesn't qualify as a bug IMO. And you can do that by other means also (CPU throttling without CPUFreq support etc...)
Anyway, I'll stop here and let Alex to make a call.
Either case, feel free to add:
Thanks,
Mani
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 24 lines · Manivannan Sadhasivam
Quoted 23 lines · Marek Vasut
Quoted 21 lines · Manivannan Sadhasivam
Quoted 8 lines · Marek Vasut
Quoted 3 lines · Manivannan Sadhasivam
On 24 September 2020 4:55:35 AM IST, Marek Vasut <[email protected]>
Quoted 1 line · wrote:
Quoted 1 line
Enable STM32 Digital Thermal Sensor driver for stm32mp15xx-dhcor
SoMs.
Quoted 1 line
Quoted 1 line
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Fixes 94cafe1b6482 ("ARM: dts: stm32: Add Avenger96 devicetreesupport
Quoted 3 lines
Quoted 1 line
based on STM32MP157A")
The change looks good but what does this patch fixes?
The missing temp sensor, which helps you detect overheat of the SoC. That is esp. important on the 800 MHz AV96.
This doesn't quality as a "fix". Essentially you're just adding a missing feature and not fixing any issues. So please remove the fixes tag and resubmit.
Quoted 8 lines
Quoted 3 lines
I would argue that if the system overheats and crashes, we want to know about that, possibly in advance so thermal throttling can be applied. Currently this is not possible and I think that is a bug.
No, this is not a _bug_. This is a missing feature that the current kernel doesn't support and you know about that! The fact that you can trigger a crash due to hw limitation doesn't qualify as a bug IMO. And you can do that by other means also (CPU throttling without CPUFreq support etc...)
I would say that makes the hardware pretty useless, which is not the expectation I would have of a system I would like to use in production. Just assume your laptop would randomly overheat and crash, would you consider that a missing feature or a bug that should be fixed ?
Quoted 1 line
Anyway, I'll stop here and let Alex to make a call.
I agree.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Marek, Mani
Quoted 28 lines · Manivannan Sadhasivam
Quoted 18 lines · Marek Vasut
Quoted 17 lines · Manivannan Sadhasivam
Quoted 14 lines · Marek Vasut
Quoted 3 lines · Manivannan Sadhasivam
On 24 September 2020 4:55:35 AM IST, Marek Vasut <[email protected]>
Quoted 1 line · wrote:
Quoted 1 line
Enable STM32 Digital Thermal Sensor driver for stm32mp15xx-dhcor
SoMs.
Quoted 2 lines
Quoted 2 lines
Fixes 94cafe1b6482 ("ARM: dts: stm32: Add Avenger96 devicetreesupport
Quoted 3 lines
Quoted 1 line
based on STM32MP157A")
The change looks good but what does this patch fixes?
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
The missing temp sensor, which helps you detect overheat of the SoC. That is esp. important on the 800 MHz AV96.
This doesn't quality as a "fix". Essentially you're just adding a missing feature and not fixing any issues. So please remove the fixes tag and resubmit.
I would argue that if the system overheats and crashes, we want to know about that, possibly in advance so thermal throttling can be applied. Currently this is not possible and I think that is a bug.
Quoted 6 lines
No, this is not a _bug_. This is a missing feature that the current kernel doesn't support and you know about that! The fact that you can trigger a crash due to hw limitation doesn't qualify as a bug IMO. And you can do that by other means also (CPU throttling without CPUFreq support etc...)
Anyway, I'll stop here and let Alex to make a call.
I take this patch as fix this time. I understand your argument Mani, but to avoid unexplained crashes at boot it's better to get also on older version.
So applied on stm32-dt-for-v5.10-fixes.
regards
alex
Quoted 7 lines
Either case, feel free to add:
Reviewed-by Manivannan Sadhasivam <[email protected]>Thanks,
Mani
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel