usbtv: Fix refcounting mixup
Subsystems (2)
PATCH v2 1/1 usbtv: Fix refcounting mixup
The premature free in the error path is blocked by V4L refcounting, not USB refcounting. Thanks to Ben Hutchings for review.
[v2] corrected attributions
Signed-off-by Oliver Neukum <[email protected]>
Fixes 50e704453553 ("media: usbtv: prevent double free in error case")
Reported-by Ben Hutchings <[email protected]>
--- drivers/media/usb/usbtv/usbtv-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/usb/usbtv/usbtv-core.c +2 -1
@@ -113,7 +113,8 @@ static int usbtv_probe(struct usb_interface *intf, usbtv_audio_fail:/* we must not free at this point */ -usb_get_dev (usbtv->udev); +v4l2_device_get (&usbtv->v4l2_dev); +/* this will undo the v4l2_device_get() */ usbtv_video_free (usbtv); usbtv_video_fail:
Signature · 1 line
2.26.2