Skip to contentSkip to conversation

nfs: use 'break' instead of 'fallthrough'

PATCH New Sudip Mukherjee 1 participant 1 message Sep 24, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfs: use 'break' instead of 'fallthrough'

The fallthrough attribute should only be used in a switch statement, after a preceding statement and before a logically succeeding case label, or user-defined label.

But here, it is used in the last 'switch-case' with no other 'case' where it can fallthrough. So, use break instead of fallthrough.

Fixes cf65e49f89f2 ("nfs: Convert to use the preferred fallthrough macro")
---
 fs/nfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/super.c +1 -1
index d20326ee0475..eb2401079b04 100644
@@ -889,7 +889,7 @@ static struct nfs_server *nfs_try_mount_request(struct fs_context *fc)
 		default:
 			if (rpcauth_get_gssinfo(flavor, &info) != 0)
 				continue;
-			fallthrough;
+			break;
 		}
 		dfprintk(MOUNT, "NFS: attempting to use auth flavor %u\n", flavor);
 		ctx->selected_flavor = flavor;
Signature · 1 line
2.11.0