Skip to contentSkip to conversation

ipvs: adjust the debug order of src and dst

PATCH In review longguang.yue 2 participants 2 messages Sep 23, 2020 – Sep 24, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipvs: adjust the debug order of src and dst

From: ylg <[email protected]>

adjust the debug order of src and dst when tcp state changes

---
 net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/netfilter/ipvs/ip_vs_proto_tcp.c +2 -2
index dc2e7da2742a..6567eb45a234 100644
@@ -548,10 +548,10 @@ set_tcp_state(struct ip_vs_proto_data *pd, struct ip_vs_conn *cp,
 			      th->fin ? 'F' : '.',
 			      th->ack ? 'A' : '.',
 			      th->rst ? 'R' : '.',
-			      IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
-			      ntohs(cp->dport),
 			      IP_VS_DBG_ADDR(cp->af, &cp->caddr),
 			      ntohs(cp->cport),
+			      IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
+			      ntohs(cp->dport),
 			      tcp_state_name(cp->state),
 			      tcp_state_name(new_state),
 			      refcount_read(&cp->refcnt));
Signature · 1 line
2.20.1 (Apple Git-117)
maintainer
#1 lore raw
Quoted 5 lines · longguang.yue

From: ylg <[email protected]>

adjust the debug order of src and dst when tcp state changes

Hi,

This sounds reasonable to me but please provide your real name in the Signed-off-by name, which should be consistent with the From field at the top of the commit message (or, if absent of the email).

Thanks!

Quoted 24 lines
---
 net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/netfilter/ipvs/ip_vs_proto_tcp.c +2 -2
index dc2e7da2742a..6567eb45a234 100644
@@ -548,10 +548,10 @@ set_tcp_state(struct ip_vs_proto_data *pd, struct ip_vs_conn *cp,
 			      th->fin ? 'F' : '.',
 			      th->ack ? 'A' : '.',
 			      th->rst ? 'R' : '.',
-			      IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
-			      ntohs(cp->dport),
 			      IP_VS_DBG_ADDR(cp->af, &cp->caddr),
 			      ntohs(cp->cport),
+			      IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
+			      ntohs(cp->dport),
 			      tcp_state_name(cp->state),
 			      tcp_state_name(new_state),
 			      refcount_read(&cp->refcnt));
Signature · 1 line
2.20.1 (Apple Git-117)