Skip to contentSkip to conversation

ath11k: removing the ath11k debugfs dir properly

PATCH In review Karthikeyan Kathirvel 2 participants 4 messages Sep 23, 2020 – Sep 29, 2020 1 message not in the archive Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: removing the ath11k debugfs dir properly

ath11k_debug_pdev_destroy was not called for proper cleaning of debug files when destroying the pdev, this results in not removing the ath11k directory in debugfs folder even after rmmod of ath11k. So when next time doing insmod of ath11k prevents creating another ath11k directory, hence causing ipq8074_2 to get created in parent dir of debugfs.

---
 drivers/net/wireless/ath/ath11k/debug.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath11k/debug.c +1 -0
index 0ba234a..c4759bb 100644
@@ -973,6 +973,7 @@ void ath11k_debug_soc_destroy(struct ath11k_base *ab)
 {
 	debugfs_remove_recursive(ab->debugfs_soc);
 	ab->debugfs_soc = NULL;
+	ath11k_debug_pdev_destroy(ab);
 }
 
 void ath11k_debug_fw_stats_init(struct ath11k *ar)
Signature · 7 lines
2.7.4


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw
Quoted 7 lines · Karthikeyan Kathirvel

ath11k_debug_pdev_destroy was not called for proper cleaning of debug files when destroying the pdev, this results in not removing the ath11k directory in debugfs folder even after rmmod of ath11k. So when next time doing insmod of ath11k prevents creating another ath11k directory, hence causing ipq8074_2 to get created in parent dir of debugfs.

Fails to apply, please rebase. Also Tested-on missing.

error: patch failed: drivers/net/wireless/ath/ath11k/debug.c:973
error: drivers/net/wireless/ath/ath11k/debug.c: patch does not apply stg import: Diff does not apply cleanly

Patch set to Changes Requested.

Signature · 3 lines
https://patchwork.kernel.org/patch/11795461/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#2 lore raw
In reply to Karthikeyan Kathirvel
Quoted 7 lines · Karthikeyan Kathirvel

ath11k_debug_pdev_destroy was not called for proper cleaning of debug files when destroying the pdev, this results in not removing the ath11k directory in debugfs folder even after rmmod of ath11k. So when next time doing insmod of ath11k prevents creating another ath11k directory, hence causing ipq8074_2 to get created in parent dir of debugfs.

Fails to apply, please rebase. Also Tested-on missing.

error: patch failed: drivers/net/wireless/ath/ath11k/debug.c:973
error: drivers/net/wireless/ath/ath11k/debug.c: patch does not apply stg import: Diff does not apply cleanly

Patch set to Changes Requested.

Signature · 9 lines
https://patchwork.kernel.org/patch/11795461/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

Please ignore this patch

Thanks
Karthikeyan

Quoted 17 lines · Kalle Valo
Quoted 7 lines · Karthikeyan Kathirvel

ath11k_debug_pdev_destroy was not called for proper cleaning of debug files when destroying the pdev, this results in not removing the ath11k directory in debugfs folder even after rmmod of ath11k. So when next time doing insmod of ath11k prevents creating another ath11k directory, hence causing ipq8074_2 to get created in parent dir of debugfs.

Fails to apply, please rebase. Also Tested-on missing.

error: patch failed: drivers/net/wireless/ath/ath11k/debug.c:973
error: drivers/net/wireless/ath/ath11k/debug.c: patch does not apply stg import: Diff does not apply cleanly

Patch set to Changes Requested.