input-linux: Reset il->fd handler before closing it
PATCH 1/1 input-linux: Reset il->fd handler before closing it
If object-del input-linux object on-the-fly, instance finalize will close evdev fd without resetting it. However the main thread is still trying to lock_acquire/lock_release during ppoll, which leads to a very high CPU utilization.
Signed-off-by Colin Xu <[email protected]>
--- ui/input-linux.c | 1 + 1 file changed, 1 insertion(+)
ui/input-linux.c +1 -0
@@ -418,6 +418,7 @@ static void input_linux_instance_finalize(Object *obj)if (il->initialized) {QTAILQ_REMOVE (&inputs, il, next); +qemu_set_fd_handler (il->fd,NULL ,NULL ,NULL );close (il->fd); }g_free (il->evdev);
Signature · 1 line
2.28.0
Quoted 7 lines · Colin Xu <[email protected]> 于2020年9月25日周五 上午10:18写道:
If object-del input-linux object on-the-fly, instance finalize will close evdev fd without resetting it. However the main thread is still trying to lock_acquire/lock_release during ppoll, which leads to a very high CPU utilization.
Signed-off-by Colin Xu <[email protected]>
Reviewed-by Li Qiang <[email protected]>
Quoted 20 lines
--- ui/input-linux.c | 1 + 1 file changed, 1 insertion(+)ui/input-linux.c +1
-1@@ -418,6 +418,7 @@ static void input_linux_instance_finalize(Object *obj)if (il->initialized) {QTAILQ_REMOVE (&inputs, il, next); +qemu_set_fd_handler (il->fd,NULL ,NULL ,NULL );close (il->fd); }g_free (il->evdev); --2.28.0