Skip to contentSkip to conversation

checkpatch: suppress fallthrough warning

PATCH In review Stephen Hemminger 2 participants 4 messages Sep 25, 2020 – Sep 26, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checkpatch: suppress fallthrough warning

The DPDK does not have (or want to use) the same fallthrough wrapper as the Linux kernel. Therefore silence the warning.

---
 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
devtools/checkpatches.sh +1 -1
index 78a408ef9823..923ff6f7d9ee 100755
@@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
 PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\
 SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
 LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
-NEW_TYPEDEFS,COMPARISON_TO_NULL"
+NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH"
 options="$options $DPDK_CHECKPATCH_OPTIONS"
 
 print_usage () {
Signature · 1 line
2.27.0
#1 lore raw
Quoted 14 lines · Stephen Hemminger

The DPDK does not have (or want to use) the same fallthrough wrapper as the Linux kernel. Therefore silence the warning.

---
 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
devtools/checkpatches.sh +0 -0
index 78a408ef9823..923ff6f7d9ee 100755

devtools/checkpatches.sh VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ · line 33

Quoted 1 line
devtools/checkpatches.sh +0 -0
@@ -33,7 +33,7 @@ VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\
 PREFER_KERNEL_TYPES,PREFER_FALLTHROUGH,BIT_MACRO,CONST_STRUCT,\
                       ^^

This token is already set here.
Is there an issue with this?

Quoted 10 lines
devtools/checkpatches.sh +1 -2
 SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\
 LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
-NEW_TYPEDEFS,COMPARISON_TO_NULL"
+NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH"
 options="$options $DPDK_CHECKPATCH_OPTIONS"
 
 print_usage () {
--

2.27.0

Signature · 1 line
David Marchand
#2 lore raw
Quoted 7 lines · On Fri, 25 Sep 2020 18:41:40 +0200 David Marchand <[email protected]>…
Quoted 5 lines · Stephen Hemminger

The DPDK does not have (or want to use) the same fallthrough wrapper as the Linux kernel. Therefore silence the warning.

Never mind; note to self look first...

Didn't see that it was already set. Maybe the issue is that the scans from patchwork are still using older version of the DPDK script?

Did a dummy patch just now with main branch and dpdk-checkpatch is correctly suppressing the warning. But recent patches submitted to mailing list are getting checkpatch warnings.

#3 lore raw
Quoted 10 lines · Stephen Hemminger
Quoted 6 lines · On Fri, 25 Sep 2020 18:41:40 +0200 David Marchand <[email protected]>…
Quoted 4 lines · Stephen Hemminger

The DPDK does not have (or want to use) the same fallthrough wrapper as the Linux kernel. Therefore silence the warning.

Quoted 6 lines
Quoted 1 line
Quoted 1 line

Never mind; note to self look first...

Didn't see that it was already set. Maybe the issue is that the scans from patchwork are still using older version of the DPDK script?

Ah yes.
I updated it on the server.

Signature · 1 line
David Marchand