Skip to contentSkip to conversation

Documentation/llvm: Fix clang target examples

PATCH In review Florian Fainelli 4 participants 4 messages Sep 25, 2020 – Sep 26, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation/llvm: Fix clang target examples

clang --target=<triple> is how we can specify a particular toolchain triple to be use, fix the two occurences in the documentation.

Fixes fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")
---
 Documentation/kbuild/llvm.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/kbuild/llvm.rst +2 -2
index 334df758dce3..dae90c21aed3 100644
@@ -39,10 +39,10 @@ which can help simplify cross compiling. ::
 	ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang
 
 ``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead
-``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For
+``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For
 example: ::
 
-	clang --target aarch64-linux-gnu foo.c
+	clang --target=aarch64-linux-gnu foo.c
 
 LLVM Utilities
 --------------
Signature · 1 line
2.25.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Florian Fainelli

clang --target=<triple> is how we can specify a particular toolchain triple to be use, fix the two occurences in the documentation.

Ah right, my mistake. It's either double dash+equals, or single dash+space. Thanks for the patch. Masahiro, would you mind picking this up?

Quoted 27 lines
Fixes fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")
---
 Documentation/kbuild/llvm.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/kbuild/llvm.rst +2 -3
index 334df758dce3..dae90c21aed3 100644
@@ -39,10 +39,10 @@ which can help simplify cross compiling. ::
        ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang
 
 ``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead
-``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For
+``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For
 example: ::
 
-       clang --target aarch64-linux-gnu foo.c
+       clang --target=aarch64-linux-gnu foo.c
 
 LLVM Utilities
 --------------
--

2.25.1

Signature · 2 lines
Thanks,
~Nick Desaulniers
#2 lore raw
Quoted 9 lines · Nick Desaulniers
Quoted 3 lines · Florian Fainelli

clang --target=<triple> is how we can specify a particular toolchain triple to be use, fix the two occurences in the documentation.

Ah right, my mistake. It's either double dash+equals, or single dash+space. Thanks for the patch. Masahiro, would you mind picking this up?

Sure.
Applied to linux-kbuild/fixes. Thanks.

Quoted 34 lines
Quoted 25 lines
Fixes fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")
---
 Documentation/kbuild/llvm.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/kbuild/llvm.rst +2 -3
index 334df758dce3..dae90c21aed3 100644
@@ -39,10 +39,10 @@ which can help simplify cross compiling. ::
        ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang
 
 ``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead
-``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For
+``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For
 example: ::
 
-       clang --target aarch64-linux-gnu foo.c
+       clang --target=aarch64-linux-gnu foo.c
 
 LLVM Utilities
 --------------
--
Quoted 2 lines

2.25.1

--
Thanks,
~Nick Desaulniers

Signature · 2 lines
Best Regards
Masahiro Yamada
Reviewed-by on v1 1/1
#3 lore raw
In reply to Florian Fainelli
Quoted 5 lines · Florian Fainelli

clang --target=<triple> is how we can specify a particular toolchain triple to be use, fix the two occurences in the documentation.

Fixes fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")

Thank you for the patch!

Quoted 24 lines
---
 Documentation/kbuild/llvm.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/kbuild/llvm.rst +2 -2
index 334df758dce3..dae90c21aed3 100644
@@ -39,10 +39,10 @@ which can help simplify cross compiling. ::
 	ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang
 
 ``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead
-``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For
+``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For
 example: ::
 
-	clang --target aarch64-linux-gnu foo.c
+	clang --target=aarch64-linux-gnu foo.c
 
 LLVM Utilities
 --------------
Signature · 1 line
2.25.1