Skip to contentSkip to conversation

habanalabs/gaudi: use correct define for qman init

PATCH In review Oded Gabbay 2 participants 3 messages Sep 25, 2020 – Sep 30, 2020 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 habanalabs/gaudi: use correct define for qman init

There was a copy-paste error, and the wrong define was used for initializing the QMAN.

---
 drivers/misc/habanalabs/gaudi/gaudi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/habanalabs/gaudi/gaudi.c +1 -1
index a227806be328..5f65a1691551 100644
@@ -2039,7 +2039,7 @@ static void gaudi_init_hbm_dma_qman(struct hl_device *hdev, int dma_id,
 		WREG32(mmDMA0_QM_CP_LDMA_SRC_BASE_LO_OFFSET_0 + q_off,
 							QMAN_LDMA_SRC_OFFSET);
 		WREG32(mmDMA0_QM_CP_LDMA_DST_BASE_LO_OFFSET_0 + q_off,
-							QMAN_LDMA_SIZE_OFFSET);
+							QMAN_LDMA_DST_OFFSET);
 
 		/* Configure RAZWI IRQ */
 		dma_qm_err_cfg = HBM_DMA_QMAN_GLBL_ERR_CFG_MSG_EN_MASK;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 23 lines · Oded Gabbay

There was a copy-paste error, and the wrong define was used for initializing the QMAN.

---
 drivers/misc/habanalabs/gaudi/gaudi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/habanalabs/gaudi/gaudi.c +1 -2
index a227806be328..5f65a1691551 100644
@@ -2039,7 +2039,7 @@ static void gaudi_init_hbm_dma_qman(struct hl_device *hdev, int dma_id,
                WREG32(mmDMA0_QM_CP_LDMA_SRC_BASE_LO_OFFSET_0 + q_off,
                                                        QMAN_LDMA_SRC_OFFSET);
                WREG32(mmDMA0_QM_CP_LDMA_DST_BASE_LO_OFFSET_0 + q_off,
-                                                       QMAN_LDMA_SIZE_OFFSET);
+                                                       QMAN_LDMA_DST_OFFSET);
 
                /* Configure RAZWI IRQ */
                dma_qm_err_cfg = HBM_DMA_QMAN_GLBL_ERR_CFG_MSG_EN_MASK;
--
Quoted 2 lines

2.17.1

Hi Greg,
Do you think you can apply this patch directly to your char-misc-next branch before the merge window opens ?
I don't have anything pending and I don't want to send a pull request for a single patch.

Thanks,
Oded

#2 lore raw
Quoted 21 lines · Oded Gabbay
Quoted 20 lines · Oded Gabbay

There was a copy-paste error, and the wrong define was used for initializing the QMAN.

---
 drivers/misc/habanalabs/gaudi/gaudi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/habanalabs/gaudi/gaudi.c +1 -1
index a227806be328..5f65a1691551 100644
@@ -2039,7 +2039,7 @@ static void gaudi_init_hbm_dma_qman(struct hl_device *hdev, int dma_id,
                WREG32(mmDMA0_QM_CP_LDMA_SRC_BASE_LO_OFFSET_0 + q_off,
                                                        QMAN_LDMA_SRC_OFFSET);
                WREG32(mmDMA0_QM_CP_LDMA_DST_BASE_LO_OFFSET_0 + q_off,
-                                                       QMAN_LDMA_SIZE_OFFSET);
+                                                       QMAN_LDMA_DST_OFFSET);
 
Quoted 11 lines
Quoted 5 lines
drivers/misc/habanalabs/gaudi/gaudi.c +0 -1
                /* Configure RAZWI IRQ */
                dma_qm_err_cfg = HBM_DMA_QMAN_GLBL_ERR_CFG_MSG_EN_MASK;
--

2.17.1

Hi Greg,
Do you think you can apply this patch directly to your char-misc-next branch before the merge window opens ?
I don't have anything pending and I don't want to send a pull request for a single patch.

Sure, I'll be glad to queue it up now.

thanks,

greg k-h