Skip to contentSkip to conversation

net/bnxt: fix vector mode for 32-bit x86

PATCH In review Lance Richardson 2 participants 2 messages Sep 25, 2020 – Sep 26, 2020 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/bnxt: fix vector mode for 32-bit x86

Descriptor valid mask should be 64-bit all ones, use appropriate initializer type (unsigned long long) to obtain correct value in 32-bit mode.

Fixes deae85145c64 ("net/bnxt: handle multiple packets per loop in vector Rx")
---
 drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_rxtx_vec_sse.c +1 -1
index 3a5a50afd8..271e7908e3 100644
@@ -164,7 +164,7 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
 	uint16_t cp_ring_size = cpr->cp_ring_struct->ring_size;
 	uint16_t rx_ring_size = rxr->rx_ring_struct->ring_size;
 	struct cmpl_base *cp_desc_ring = cpr->cp_desc_ring;
-	uint64_t valid, desc_valid_mask = ~0UL;
+	uint64_t valid, desc_valid_mask = ~0ULL;
 	const __m128i info3_v_mask = _mm_set_epi32(CMPL_BASE_V, CMPL_BASE_V,
 						   CMPL_BASE_V, CMPL_BASE_V);
 	uint32_t raw_cons = cpr->cp_raw_cons;
Signature · 1 line
2.25.1
#1 lore raw
Quoted 8 lines · Lance Richardson

Descriptor valid mask should be 64-bit all ones, use appropriate initializer type (unsigned long long) to obtain correct value in 32-bit mode.

Fixes deae85145c64 ("net/bnxt: handle multiple packets per loop in vector Rx")

Patch applied to dpdk-next-net-brcm. Thanks

Quoted 20 lines
---
 drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_rxtx_vec_sse.c +1 -2
index 3a5a50afd8..271e7908e3 100644
@@ -164,7 +164,7 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
        uint16_t cp_ring_size = cpr->cp_ring_struct->ring_size;
        uint16_t rx_ring_size = rxr->rx_ring_struct->ring_size;
        struct cmpl_base *cp_desc_ring = cpr->cp_desc_ring;
-       uint64_t valid, desc_valid_mask = ~0UL;
+       uint64_t valid, desc_valid_mask = ~0ULL;
        const __m128i info3_v_mask = _mm_set_epi32(CMPL_BASE_V, CMPL_BASE_V,
                                                   CMPL_BASE_V, CMPL_BASE_V);
        uint32_t raw_cons = cpr->cp_raw_cons;
--

2.25.1