leds: omnia: fix leak of device node iterator
Subsystems (2)
PATCH 1/1 leds: omnia: fix leak of device node iterator
In the error path of the for_each_available_child_of_node loop in omnia_leds_probe, add missing call to of_node_put to fix leaking the iterator.
Fixes 089381b27abe ("leds: initial support for Turris Omnia LEDs")
Signed-off-by Tobias Jordan <[email protected]>
--- drivers/leds/leds-turris-omnia.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/leds/leds-turris-omnia.c +3 -1
@@ -236,8 +236,10 @@ static int omnia_leds_probe(struct i2c_client *client, led = &leds->leds[0 ];for_each_available_child_of_node (np, child) { ret =omnia_led_register (client, led, child); -if (ret <0 ) +if (ret <0 ) { +of_node_put (child);return ret; + } led += ret; }
Signature · 1 line
2.20.1
Already fixed in Pavel's for-next
https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=62aa40d0e907849d740ceba2a7f6bcc88896699f