HID: hid-input: fix stylus battery reporting
PATCH 1/1 HID: hid-input: fix stylus battery reporting
With commit 4f3882177240 hid-input started clearing of "ignored" usages to avoid using garbage that might have been left in them. However "battery strength" usages should not be ignored, as we do want to use them.
---
Kenneth, can you please try this one and see if it fixes your issue?
drivers/hid/hid-input.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hid/hid-input.c +2 -2
@@ -797,7 +797,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fielcase 0x3b :/* Battery Strength */ hidinput_setup_battery (device,HID_INPUT_REPORT , field); usage->type =EV_PWR ; - goto ignore; +return ;case 0x3c :/* Invert */ map_key_clear (BTN_TOOL_RUBBER );
@@ -1059,7 +1059,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fielcase HID_DC_BATTERYSTRENGTH :hidinput_setup_battery (device,HID_INPUT_REPORT , field); usage->type =EV_PWR ; - goto ignore; +return ; } goto unknown;
Signature · 5 lines
2.28.0.681.g6f77f65b4e-goog -- Dmitry
Quoted 8 lines · Dmitry Torokhov
With commit
4f3882177240hid-input started clearing of "ignored" usages to avoid using garbage that might have been left in them. However "battery strength" usages should not be ignored, as we do want to use them.Fixes 4f3882177240 ("HID: hid-input: clear unmapped usages")Reported-by Kenneth Albanowski <[email protected]>Signed-off-by Dmitry Torokhov <[email protected]>
Applied, thanks Dmitry and Kenneth.
Signature · 2 lines
Jiri Kosina SUSE Labs
[Re-send to appease the mail daemons]
Confirmed, I've validated this on a 4.19 derivative, this fixes the problem and battery strength gets reported again.
- Kenneth Albanowski
Quoted 44 lines · Dmitry Torokhov
With commit
4f3882177240hid-input started clearing of "ignored" usages to avoid using garbage that might have been left in them. However "battery strength" usages should not be ignored, as we do want to use them.Fixes 4f3882177240 ("HID: hid-input: clear unmapped usages")Reported-by Kenneth Albanowski <[email protected]>Signed-off-by Dmitry Torokhov <[email protected]>---
Kenneth, can you please try this one and see if it fixes your issue?
drivers/hid/hid-input.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/hid/hid-input.c +2
-3@@ -797,7 +797,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fielcase 0x3b :/* Battery Strength */ hidinput_setup_battery (device,HID_INPUT_REPORT , field); usage->type =EV_PWR ; - goto ignore; +return ;case 0x3c :/* Invert */ map_key_clear (BTN_TOOL_RUBBER );@@ -1059,7 +1059,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fielcase HID_DC_BATTERYSTRENGTH :hidinput_setup_battery (device,HID_INPUT_REPORT , field); usage->type =EV_PWR ; - goto ignore; +return ; } goto unknown; --2.28.0.681.g6f77f65b4e-goog
--
Dmitry