dvb-apps: fix build failure with glibc 2.31
PATCH 1/1 dvb-apps: fix build failure with glibc 2.31
dvb-apps fails to build with glibc 2.31 with the following error:
| dvbdate.c: In function set_time:
| dvbdate.c:312:6: warning: implicit declaration of function stime; did you mean ctime? [-Wimplicit-function-declaration]
| 312 | if (stime(new_time)) {
| | ^~~~~
| | ctimethis patch takes from the first entry in the reference fixes it.
reference:
1. https://gitweb.gentoo.org/repo/gentoo.git/commit/media-tv/linuxtv-dvb-apps/files/linuxtv-dvb-apps-glibc-2.31.patch?id=eb705f892eae45b93306c1de1407c1c22ac23956
2. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964223
--- package/dvb-apps/0006-fix-glibc-2.31.patch | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 package/dvb-apps/0006-fix-glibc-2.31.patch
package/dvb-apps/0006-fix-glibc-2.31.patch new file +14 -0
@@ -0,0 +1,14 @@ +--- a/util/dvbdate/dvbdate.c ++++ b/util/dvbdate/dvbdate.c +@@ -309,7 +309,10 @@ + */ + int set_time(time_t * new_time) + { +- if (stime(new_time)) { ++ struct timespec s = {0}; ++ s.tv_sec = new_time; ++ ++ if (clock_settime(CLOCK_REALTIME, &s)) { + perror("Unable to set time"); + return -1; + }
--
2.28.0
PATCH 1/1 dvb-apps: fix build failure with glibc 2.31
Hello,
Thanks for the patch. There are however a few coding style issues. First, the commit title must always have the following format:
package/<foo>: <something>
I.e you forgot the package/ prefix.
Quoted 7 lines · On Sat, 26 Sep 2020 12:55:50 +0300 Dagg Stompler <[email protected]> wrote:
dvb-apps fails to build with glibc 2.31 with the following error:
| dvbdate.c: In function set_time: | dvbdate.c:312:6: warning: implicit declaration of function stime; did you mean ctime? [-Wimplicit-function-declaration] | 312 | if (stime(new_time)) { | | ^~~~~ | | ctime
Quoted 5 lines
this patch takes from the first entry in the reference fixes it.
reference:
1. https://gitweb.gentoo.org/repo/gentoo.git/commit/media-tv/linuxtv-dvb-apps/files/linuxtv-dvb-apps-glibc-2.31.patch?id=eb705f892eae45b93306c1de1407c1c22ac23956
2. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964223
Please add a reference to the autobuilder failure, like this:
Fixes:
http://autobuild.buildroot.net/results/95f30c5e6af2274418bb44a20da7caac69f1dd68/
package/dvb-apps/0006-fix-glibc-2.31.patch
Quoted 5 lines
package/dvb-apps/0006-fix-glibc-2.31.patch new file +0
-0
All patches must have a description and Signed-off-by.
Could you fix those details, and send an updated version? Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 dvb-apps: fix build failure with glibc 2.31
Greetings Thomas,
Quoted 6 lines
Sent: Saturday, September 26, 2020 at 4:39 PM
From: "Thomas Petazzoni" <[email protected]>
To: "Dagg Stompler" <[email protected]>
Cc: buildroot at buildroot.org
Subject: Re: [Buildroot] [PATCH] dvb-apps: fix build failure with glibc 2.31
Quoted 8 lines
Hello,
Thanks for the patch. There are however a few coding style issues. First, the commit title must always have the following format:
package/<foo>: <something>
I.e you forgot the package/ prefix.
you are correct, I've forgot about this, will fix
Quoted 17 lines
Quoted 7 lines · On Sat, 26 Sep 2020 12:55:50 +0300 Dagg Stompler <[email protected]> wrote:
dvb-apps fails to build with glibc 2.31 with the following error:
| dvbdate.c: In function set_time: | dvbdate.c:312:6: warning: implicit declaration of function stime; did you mean ctime? [-Wimplicit-function-declaration] | 312 | if (stime(new_time)) { | | ^~~~~ | | ctimeQuoted 5 lines
this patch takes from the first entry in the reference fixes it.
reference:
1. https://gitweb.gentoo.org/repo/gentoo.git/commit/media-tv/linuxtv-dvb-apps/files/linuxtv-dvb-apps-glibc-2.31.patch?id=eb705f892eae45b93306c1de1407c1c22ac23956
2. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=964223
Quoted 5 lines
Please add a reference to the autobuilder failure, like this:
Fixes:
http://autobuild.buildroot.net/results/95f30c5e6af2274418bb44a20da7caac69f1dd68/
frankly speaking, I had no idea this issue was marked by the autobuilder, I've encountered it when trying to build an image with dvb-apps installed.
I'll reference the failure in my next revision.
Quoted 11 lines
package/dvb-apps/0006-fix-glibc-2.31.patch
Quoted 6 lines
package/dvb-apps/0006-fix-glibc-2.31.patch new file +0
-0All patches must have a description and Signed-off-by.
Could you fix those details, and send an updated version? Thanks a lot!
as mentioned in the commit mail, I took the patch as is from the first reference. I'll try to find a more detailed commit or will rewrite it.
Thanks,
Dagg.
PATCH 1/1 dvb-apps: fix build failure with glibc 2.31
Hello,
Quoted 7 lines · On Sat, 26 Sep 2020 18:06:25 +0200 daggs <[email protected]> wrote:
Quoted 3 lines
Fixes:
http://autobuild.buildroot.net/results/95f30c5e6af2274418bb44a20da7caac69f1dd68/
frankly speaking, I had no idea this issue was marked by the autobuilder, I've encountered it when trying to build an image with dvb-apps installed.
No problem. But when you have a failure, it makes sense to check if we have encountered it in the autobuilders. You can easily search by doing this:
http://autobuild.buildroot.org/?reason=dvb-apps%
The % at the end is important, as it acts as a wildcard.
And if the failure was not found by the autobuilders, it is interesting to investigate why. Is it because the failure is related to a very specific system configuration? Or an architecture/toolchain combination we are not testing?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 dvb-apps: fix build failure with glibc 2.31
Greetings Thomas,
Quoted 23 lines
Sent: Monday, September 28, 2020 at 10:22 PM
From: "Thomas Petazzoni" <[email protected]>
To: "daggs" <[email protected]>
Cc: buildroot at buildroot.org
Subject: Re: [Buildroot] [PATCH] dvb-apps: fix build failure with glibc 2.31Hello,
Quoted 7 lines · On Sat, 26 Sep 2020 18:06:25 +0200 daggs <[email protected]> wrote:
Quoted 3 lines
Fixes:
http://autobuild.buildroot.net/results/95f30c5e6af2274418bb44a20da7caac69f1dd68/
frankly speaking, I had no idea this issue was marked by the autobuilder, I've encountered it when trying to build an image with dvb-apps installed.
No problem. But when you have a failure, it makes sense to check if we have encountered it in the autobuilders. You can easily search by doing this:
Quoted 9 lines
http://autobuild.buildroot.org/?reason=dvb-apps%
The % at the end is important, as it acts as a wildcard.
And if the failure was not found by the autobuilders, it is interesting to investigate why. Is it because the failure is related to a very specific system configuration? Or an architecture/toolchain combination we are not testing?
I'll take that under advisement for the future
Dagg