mmc: sdhci-of-esdhc: fix reference clock source selection
PATCH 1/1 mmc: sdhci-of-esdhc: fix reference clock source selection
The bit ESDHC_PERIPHERAL_CLK_SEL to select using peripheral clock or platform clock is not able to be reset by SDHCI_RESET_ALL. So driver needs to initialize it as 1 or 0 once, to override the different value which may be configured in bootloader.
Signed-off-by Yangbo Lu <[email protected]>
--- drivers/mmc/host/sdhci-of-esdhc.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/mmc/host/sdhci-of-esdhc.c +12 -6
@@ -1360,13 +1360,19 @@ static void esdhc_init(struct platform_device *pdev, struct sdhci_host *host)clk_put (clk); } -if (esdhc->peripheral_clock) { -esdhc_clock_enable (host, false); - val =sdhci_readl (host,ESDHC_DMA_SYSCTL ); +esdhc_clock_enable (host, false); + val =sdhci_readl (host,ESDHC_DMA_SYSCTL ); +/* +* This bit is not able to be reset by SDHCI_RESET_ALL. Need to +* initialize it as 1 or 0 once, to override the different value +* which may be configured in bootloader. +*/ +if (esdhc->peripheral_clock) val |=ESDHC_PERIPHERAL_CLK_SEL ; -sdhci_writel (host, val,ESDHC_DMA_SYSCTL ); -esdhc_clock_enable (host, true); - } +else + val &= ~ESDHC_PERIPHERAL_CLK_SEL ; +sdhci_writel (host, val,ESDHC_DMA_SYSCTL ); +esdhc_clock_enable (host, true); }static int esdhc_hs400_prepare_ddr (struct mmc_host *mmc)
Signature · 1 line
2.7.4
Quoted 7 lines · Yangbo Lu
The bit
ESDHC_PERIPHERAL_CLK_SELto select using peripheral clock or platform clock is not able to be reset bySDHCI_RESET_ALL. So driver needs to initialize it as 1 or 0 once, to override the different value which may be configured in bootloader.Signed-off-by Yangbo Lu <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 37 lines
--- drivers/mmc/host/sdhci-of-esdhc.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)drivers/mmc/host/sdhci-of-esdhc.c +12
-7@@ -1360,13 +1360,19 @@ static void esdhc_init(struct platform_device *pdev, struct sdhci_host *host)clk_put (clk); } -if (esdhc->peripheral_clock) { -esdhc_clock_enable (host, false); - val =sdhci_readl (host,ESDHC_DMA_SYSCTL ); +esdhc_clock_enable (host, false); + val =sdhci_readl (host,ESDHC_DMA_SYSCTL ); +/* +* This bit is not able to be reset by SDHCI_RESET_ALL. Need to +* initialize it as 1 or 0 once, to override the different value +* which may be configured in bootloader. +*/ +if (esdhc->peripheral_clock) val |=ESDHC_PERIPHERAL_CLK_SEL ; -sdhci_writel (host, val,ESDHC_DMA_SYSCTL ); -esdhc_clock_enable (host, true); - } +else + val &= ~ESDHC_PERIPHERAL_CLK_SEL ; +sdhci_writel (host, val,ESDHC_DMA_SYSCTL ); +esdhc_clock_enable (host, true); }static int esdhc_hs400_prepare_ddr (struct mmc_host *mmc) --2.7.4