dpaa2-mac: Fix potential null pointer dereference
Subsystems (3)
PATCH 1/1 dpaa2-mac: Fix potential null pointer dereference
In dpaa2_pcs_destroy, variable pcs is dereference before it is null-checked. Fix this.
Addresses-Coverity: CID 1497159: Null pointer dereferences (REVERSE_INULL)
Signed-off-by Alex Dewar <[email protected]>
--- drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +1 -2
@@ -291,11 +291,10 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,static void dpaa2_pcs_destroy (struct dpaa2_mac *mac) {struct lynx_pcs *pcs = mac->pcs; -struct device *dev = &pcs->mdio->dev;if (pcs) {lynx_pcs_destroy (pcs); -put_device (dev); +put_device (&pcs->mdio->dev); mac->pcs =NULL ; } }
Signature · 1 line
2.28.0
Ioana Ciornei
maintainerQuoted 16 lines · Alex Dewar
In
dpaa2_pcs_destroy, variable pcs is dereference before it is null-checked. Fix this.Addresses-Coverity: CID 1497159: Null pointer dereferences (
REVERSE_INULL)Signed-off-by Alex Dewar <[email protected]>--- drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +0
-0@@ -291,11 +291,10 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,static void dpaa2_pcs_destroy (struct dpaa2_mac *mac) {
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c static int dpaa2_pcs_create(struct dpaa2_mac *mac, · line 300
Quoted 10 lines
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +1
-2struct lynx_pcs *pcs = mac->pcs; -struct device *dev = &pcs->mdio->dev;if (pcs) {lynx_pcs_destroy (pcs); -put_device (dev); +put_device (&pcs->mdio->dev); mac->pcs =NULL ; } }
This would introduce another problem because you would access an already freed pcs. Maybe just move the declaration and initialization of dev inside the if statement.
Thanks, Ioana