Skip to contentSkip to conversation

config/uploadpack.txt: fix typo in `--filter=tree:<n>`

PATCH In review Martin Ågren 2 participants 2 messages Sep 27, 2020 – Sep 28, 2020 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 config/uploadpack.txt: fix typo in `--filter=tree:<n>`

That should be a ":", not a second "=". While at it, refer to the placeholder "<n>" as "<n>", not "n" (see, e.g., the entry just before this one).

---
On tb/upload-pack-filters.

 Documentation/config/uploadpack.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/config/uploadpack.txt +1 -1
index ee7b3ac94f..b0d761282c 100644
@@ -65,17 +65,17 @@ uploadpackfilter.allow::
 uploadpackfilter.<filter>.allow::
 	Explicitly allow or ban the object filter corresponding to
 	`<filter>`, where `<filter>` may be one of: `blob:none`,
 	`blob:limit`, `tree`, `sparse:oid`, or `combine`. If using
 	combined filters, both `combine` and all of the nested filter
 	kinds must be allowed. Defaults to `uploadpackfilter.allow`.
 
 uploadpackfilter.tree.maxDepth::
-	Only allow `--filter=tree=<n>` when `n` is no more than the value of
+	Only allow `--filter=tree:<n>` when `<n>` is no more than the value of
 	`uploadpackfilter.tree.maxDepth`. If set, this also implies
 	`uploadpackfilter.tree.allow=true`, unless this configuration
 	variable had already been set. Has no effect if unset.
 
 uploadpack.allowRefInWant::
 	If this option is set, `upload-pack` will support the `ref-in-want`
 	feature of the protocol version 2 `fetch` command.  This feature
 	is intended for the benefit of load-balanced servers which may
Signature · 1 line
2.28.0.277.g9b3c35fffd
Acked-by on v1 1/1
#1 lore raw

Hi Martin,

Quoted 3 lines · Martin Ågren

That should be a ":", not a second "=". While at it, refer to the placeholder "<n>" as "<n>", not "n" (see, e.g., the entry just before this one).

Thanks for catching this. The patch below looks great to me.

Quoted 1 line

Thanks,
Taylor