Skip to contentSkip to conversation

rcu: Clarify nocb kthreads naming in RCU_NOCB_CPU config

PATCH In review Neeraj Upadhyay 3 participants 5 messages Sep 24, 2020 – Sep 28, 2020 RCU

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rcu: Clarify nocb kthreads naming in RCU_NOCB_CPU config

Clarify the "x" in rcuox/N naming in RCU_NOCB_CPU config description.

---
 kernel/rcu/Kconfig | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
kernel/rcu/Kconfig +6 -5
index b71e21f..5b22747 100644
@@ -227,11 +227,12 @@ config RCU_NOCB_CPU
 	  specified at boot time by the rcu_nocbs parameter.  For each
 	  such CPU, a kthread ("rcuox/N") will be created to invoke
 	  callbacks, where the "N" is the CPU being offloaded, and where
-	  the "p" for RCU-preempt (PREEMPTION kernels) and "s" for RCU-sched
-	  (!PREEMPTION kernels).  Nothing prevents this kthread from running
-	  on the specified CPUs, but (1) the kthreads may be preempted
-	  between each callback, and (2) affinity or cgroups can be used
-	  to force the kthreads to run on whatever set of CPUs is desired.
+	  the "x" is "p" for RCU-preempt (PREEMPTION kernels) and "s" for
+	  RCU-sched (!PREEMPTION kernels).  Nothing prevents this kthread
+	  from running on the specified CPUs, but (1) the kthreads may be
+	  preempted between each callback, and (2) affinity or cgroups can
+	  be used to force the kthreads to run on whatever set of CPUs is
+	  desired.
 
 	  Say Y here if you want to help to debug reduced OS jitter.
 	  Say N here if you are unsure.
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer
#1 lore raw
Quoted 4 lines · Neeraj Upadhyay

Clarify the "x" in rcuox/N naming in RCU_NOCB_CPU config description.

Applied with a few additional updates as shown below. As always, please let me know if I messed anything up.

Thanx, Paul

------------------------------------------------------------------------

commit 8d1d776b4998896a6f8f4608edb0b258bd37ec9f

Author: Neeraj Upadhyay <[email protected]>
Date:   Thu Sep 24 12:04:10 2020 +0530

rcu: Clarify nocb kthreads naming in RCU_NOCB_CPU config

This commit clarifies that the "p" and the "s" in the in the RCU_NOCB_CPU config-option description refer to the "x" in the "rcuox/N" kthread name.

[ paulmck: While in the area, update description and advice. ]
kernel/rcu/Kconfig +12 -8
index b71e21f..cdc57b4 100644
@@ -221,19 +221,23 @@ config RCU_NOCB_CPU
 	  Use this option to reduce OS jitter for aggressive HPC or
 	  real-time workloads.	It can also be used to offload RCU
 	  callback invocation to energy-efficient CPUs in battery-powered
-	  asymmetric multiprocessors.
+	  asymmetric multiprocessors.  The price of this reduced jitter
+	  is that the overhead of call_rcu() increases and that some
+	  workloads will incur significant increases in context-switch
+	  rates.
 
 	  This option offloads callback invocation from the set of CPUs
 	  specified at boot time by the rcu_nocbs parameter.  For each
 	  such CPU, a kthread ("rcuox/N") will be created to invoke
 	  callbacks, where the "N" is the CPU being offloaded, and where
-	  the "p" for RCU-preempt (PREEMPTION kernels) and "s" for RCU-sched
-	  (!PREEMPTION kernels).  Nothing prevents this kthread from running
-	  on the specified CPUs, but (1) the kthreads may be preempted
-	  between each callback, and (2) affinity or cgroups can be used
-	  to force the kthreads to run on whatever set of CPUs is desired.
-
-	  Say Y here if you want to help to debug reduced OS jitter.
+	  the "x" is "p" for RCU-preempt (PREEMPTION kernels) and "s" for
+	  RCU-sched (!PREEMPTION kernels).  Nothing prevents this kthread
+	  from running on the specified CPUs, but (1) the kthreads may be
+	  preempted between each callback, and (2) affinity or cgroups can
+	  be used to force the kthreads to run on whatever set of CPUs is
+	  desired.
+
+	  Say Y here if you need reduced OS jitter, despite added overhead.
 	  Say N here if you are unsure.
 
 config TASKS_TRACE_RCU_READ_MB
#2 lore raw

Hi Paul,

Quoted 9 lines · Paul E. McKenney
Quoted 4 lines · Neeraj Upadhyay

Clarify the "x" in rcuox/N naming in RCU_NOCB_CPU config description.

Applied with a few additional updates as shown below. As always, please let me know if I messed anything up.

Looks good! thanks!

Thanks
Neeraj

Quoted 54 lines

Thanx, Paul

------------------------------------------------------------------------

commit 8d1d776b4998896a6f8f4608edb0b258bd37ec9f

Author: Neeraj Upadhyay <[email protected]>
Date:   Thu Sep 24 12:04:10 2020 +0530

rcu: Clarify nocb kthreads naming in RCU_NOCB_CPU config

This commit clarifies that the "p" and the "s" in the in the RCU_NOCB_CPU config-option description refer to the "x" in the "rcuox/N" kthread name.

[ paulmck: While in the area, update description and advice. ]
kernel/rcu/Kconfig +12 -8
index b71e21f..cdc57b4 100644
@@ -221,19 +221,23 @@ config RCU_NOCB_CPU
  	  Use this option to reduce OS jitter for aggressive HPC or
  	  real-time workloads.	It can also be used to offload RCU
  	  callback invocation to energy-efficient CPUs in battery-powered
-	  asymmetric multiprocessors.
+	  asymmetric multiprocessors.  The price of this reduced jitter
+	  is that the overhead of call_rcu() increases and that some
+	  workloads will incur significant increases in context-switch
+	  rates.
 
  	  This option offloads callback invocation from the set of CPUs
  	  specified at boot time by the rcu_nocbs parameter.  For each
  	  such CPU, a kthread ("rcuox/N") will be created to invoke
  	  callbacks, where the "N" is the CPU being offloaded, and where
-	  the "p" for RCU-preempt (PREEMPTION kernels) and "s" for RCU-sched
-	  (!PREEMPTION kernels).  Nothing prevents this kthread from running
-	  on the specified CPUs, but (1) the kthreads may be preempted
-	  between each callback, and (2) affinity or cgroups can be used
-	  to force the kthreads to run on whatever set of CPUs is desired.
-
-	  Say Y here if you want to help to debug reduced OS jitter.
+	  the "x" is "p" for RCU-preempt (PREEMPTION kernels) and "s" for
+	  RCU-sched (!PREEMPTION kernels).  Nothing prevents this kthread
+	  from running on the specified CPUs, but (1) the kthreads may be
+	  preempted between each callback, and (2) affinity or cgroups can
+	  be used to force the kthreads to run on whatever set of CPUs is
+	  desired.
+
+	  Say Y here if you need reduced OS jitter, despite added overhead.
  	  Say N here if you are unsure.
 
  config TASKS_TRACE_RCU_READ_MB
Signature · 1 line
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v1 1/1
#3 lore raw
In reply to Neeraj Upadhyay
Quoted 3 lines · Neeraj Upadhyay

Clarify the "x" in rcuox/N naming in RCU_NOCB_CPU config description.

thanks,

- Joel

Quoted 31 lines
---
 kernel/rcu/Kconfig | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
kernel/rcu/Kconfig +6 -5
index b71e21f..5b22747 100644
@@ -227,11 +227,12 @@ config RCU_NOCB_CPU
 	  specified at boot time by the rcu_nocbs parameter.  For each
 	  such CPU, a kthread ("rcuox/N") will be created to invoke
 	  callbacks, where the "N" is the CPU being offloaded, and where
-	  the "p" for RCU-preempt (PREEMPTION kernels) and "s" for RCU-sched
-	  (!PREEMPTION kernels).  Nothing prevents this kthread from running
-	  on the specified CPUs, but (1) the kthreads may be preempted
-	  between each callback, and (2) affinity or cgroups can be used
-	  to force the kthreads to run on whatever set of CPUs is desired.
+	  the "x" is "p" for RCU-preempt (PREEMPTION kernels) and "s" for
+	  RCU-sched (!PREEMPTION kernels).  Nothing prevents this kthread
+	  from running on the specified CPUs, but (1) the kthreads may be
+	  preempted between each callback, and (2) affinity or cgroups can
+	  be used to force the kthreads to run on whatever set of CPUs is
+	  desired.
 
 	  Say Y here if you want to help to debug reduced OS jitter.
 	  Say N here if you are unsure.
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer
#4 lore raw
Quoted 6 lines · Joel Fernandes
Quoted 3 lines · Neeraj Upadhyay

Clarify the "x" in rcuox/N naming in RCU_NOCB_CPU config description.

Thank you, I will apply your Reviewed-by on the next rebase.

Thanx, Paul

Quoted 35 lines

thanks,

- Joel

Quoted 31 lines
---
 kernel/rcu/Kconfig | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
kernel/rcu/Kconfig +6 -5
index b71e21f..5b22747 100644
@@ -227,11 +227,12 @@ config RCU_NOCB_CPU
 	  specified at boot time by the rcu_nocbs parameter.  For each
 	  such CPU, a kthread ("rcuox/N") will be created to invoke
 	  callbacks, where the "N" is the CPU being offloaded, and where
-	  the "p" for RCU-preempt (PREEMPTION kernels) and "s" for RCU-sched
-	  (!PREEMPTION kernels).  Nothing prevents this kthread from running
-	  on the specified CPUs, but (1) the kthreads may be preempted
-	  between each callback, and (2) affinity or cgroups can be used
-	  to force the kthreads to run on whatever set of CPUs is desired.
+	  the "x" is "p" for RCU-preempt (PREEMPTION kernels) and "s" for
+	  RCU-sched (!PREEMPTION kernels).  Nothing prevents this kthread
+	  from running on the specified CPUs, but (1) the kthreads may be
+	  preempted between each callback, and (2) affinity or cgroups can
+	  be used to force the kthreads to run on whatever set of CPUs is
+	  desired.
 
 	  Say Y here if you want to help to debug reduced OS jitter.
 	  Say N here if you are unsure.
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project