Skip to contentSkip to conversation

net/mlx5: support item type error message in flow Verbs

PATCH In review Li Zhang 3 participants 3 messages Sep 28, 2020 – Oct 27, 2020 Network drivers

lore
Share & tools
lore

Li Zhang

author
#0 lore raw

PATCH 1/1 net/mlx5: support item type error message in flow Verbs

Update the flow verbs error message to "item type X not supported", when it is not supported,
instead of a generic error message "item not supported".

---
 drivers/net/mlx5/mlx5_flow_verbs.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/net/mlx5/mlx5_flow_verbs.c +8 -3
index 62c18b834f..0e0042f17b 100644
@@ -1258,6 +1258,7 @@ flow_verbs_validate(struct rte_eth_dev *dev,
 	uint64_t last_item = 0;
 	uint8_t next_protocol = 0xff;
 	uint16_t ether_type = 0;
+	char errstr[32];
 
 	if (items == NULL)
 		return -1;
@@ -1408,9 +1409,11 @@ flow_verbs_validate(struct rte_eth_dev *dev,
 			last_item = MLX5_FLOW_LAYER_MPLS;
 			break;
 		default:
+			snprintf(errstr, sizeof(errstr), "item type %d not supported",
+				 items->type);
 			return rte_flow_error_set(error, ENOTSUP,
 						  RTE_FLOW_ERROR_TYPE_ITEM,
-						  NULL, "item not supported");
+						  NULL, errstr);
 		}
 		item_flags |= last_item;
 	}
@@ -1704,6 +1707,7 @@ flow_verbs_translate(struct rte_eth_dev *dev,
 	struct mlx5_flow_rss_desc *rss_desc = &((struct mlx5_flow_rss_desc *)
 					      priv->rss_desc)
 					      [!!priv->flow_nested_idx];
+	char errstr[32];
 
 	if (priority == MLX5_FLOW_PRIO_RSVD)
 		priority = priv->config.flow_prio - 1;
@@ -1849,10 +1853,11 @@ flow_verbs_translate(struct rte_eth_dev *dev,
 			item_flags |= MLX5_FLOW_LAYER_MPLS;
 			break;
 		default:
+			snprintf(errstr, sizeof(errstr), "item type %d not supported",
+				 items->type);
 			return rte_flow_error_set(error, ENOTSUP,
 						  RTE_FLOW_ERROR_TYPE_ITEM,
-						  NULL,
-						  "item not supported");
+						  NULL, errstr);
 		}
 	}
 	dev_flow->handle->layers = item_flags;
Signature · 1 line
2.21.0
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Li Zhang <[email protected]>
Sent: Monday, September 28, 2020 9:56
To: Dekel Peled <[email protected]>; Ori Kam <[email protected]>; Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>
Cc: [email protected]; NBU-Contact-Thomas Monjalon <[email protected]>; Raslan Darawsheh <[email protected]>
Subject: [PATCH V1 1/1] net/mlx5: support item type error message in flow Verbs

Quoted 5 lines

Update the flow verbs error message to "item type X not supported", when it is not supported, instead of a generic error message "item not supported".

---

#2 lore raw
In reply to Li Zhang

Hi,

Quoted 74 lines

-----Original Message-----
From: Li Zhang <[email protected]>
Sent: Monday, September 28, 2020 9:56 AM
To: Dekel Peled <[email protected]>; Ori Kam <[email protected]>; Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>
Cc: [email protected]; NBU-Contact-Thomas Monjalon <[email protected]>; Raslan Darawsheh <[email protected]>
Subject: [PATCH V1 1/1] net/mlx5: support item type error message in flow Verbs

Update the flow verbs error message to "item type X not supported", when it is not supported,
instead of a generic error message "item not supported".

---
 drivers/net/mlx5/mlx5_flow_verbs.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/net/mlx5/mlx5_flow_verbs.c +4 -1
index 62c18b834f..0e0042f17b 100644
@@ -1258,6 +1258,7 @@ flow_verbs_validate(struct rte_eth_dev *dev,
 	uint64_t last_item = 0;
 	uint8_t next_protocol = 0xff;
 	uint16_t ether_type = 0;
+	char errstr[32];
 
 	if (items == NULL)
 		return -1;
@@ -1408,9 +1409,11 @@ flow_verbs_validate(struct rte_eth_dev *dev,
 			last_item = MLX5_FLOW_LAYER_MPLS;
 			break;
 		default:
+			snprintf(errstr, sizeof(errstr), "item type %d not
 supported",
+				 items->type);
 			return rte_flow_error_set(error, ENOTSUP,
 
 RTE_FLOW_ERROR_TYPE_ITEM,
-						  NULL, "item not
 supported");
+						  NULL, errstr);
drivers/net/mlx5/mlx5_flow_verbs.c +1 -0
 		}
 		item_flags |= last_item;
 	}
@@ -1704,6 +1707,7 @@ flow_verbs_translate(struct rte_eth_dev *dev,
 	struct mlx5_flow_rss_desc *rss_desc = &((struct
 mlx5_flow_rss_desc *)
 					      priv->rss_desc)
 					      [!!priv->flow_nested_idx];
+	char errstr[32];
 
 	if (priority == MLX5_FLOW_PRIO_RSVD)
drivers/net/mlx5/mlx5_flow_verbs.c +3 -2
 		priority = priv->config.flow_prio - 1;
@@ -1849,10 +1853,11 @@ flow_verbs_translate(struct rte_eth_dev *dev,
 			item_flags |= MLX5_FLOW_LAYER_MPLS;
 			break;
 		default:
+			snprintf(errstr, sizeof(errstr), "item type %d not
 supported",
+				 items->type);
 			return rte_flow_error_set(error, ENOTSUP,
 
 RTE_FLOW_ERROR_TYPE_ITEM,
-						  NULL,
-						  "item not supported");
+						  NULL, errstr);
 		}
drivers/net/mlx5/mlx5_flow_verbs.c +0 -1
 	}
 	dev_flow->handle->layers = item_flags;
--
Quoted 1 line

2.21.0

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh