package/zstd: avoid compilation during host-zstd install step
PATCH 1/2 package/zstd: avoid compilation during host-zstd install step
From: Thomas De Schampheleire <[email protected]>
The host-zstd-build step was not actually compiling the library:
make[1]: Entering directory '/buildroot/output/build/host-zstd-1.4.5/lib' make[1]: Nothing to be done for 'default'.
make[1]: Leaving directory '/buildroot/output/build/host-zstd-1.4.5/lib'
and the actual compilation was part of the install step. This is not how other Buildroot packages work.
Make sure to specify which library targets we want instead. The total amount of compiled files does not change with this patch.
--- package/zstd/zstd.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/zstd/zstd.mk +1 -1
@@ -71,7 +71,7 @@ endef # note: no 'HAVE_...' options for host library build only define HOST_ZSTD_BUILD_CMDS $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \ - -C $(@D)/lib + -C $(@D)/lib libzstd.a libzstd $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \ -C $(@D) zstd endef
Signature · 1 line
2.26.2
PATCH 2/2 package/zstd: link programs dynamically with libzstd to save space
From: Thomas De Schampheleire <[email protected]>
Even when a shared libzstd is built, the zstd command-line programs are statically linked with libzstd, causing a large rootfs footprint.
While the cmake backend in zstd already supported a flag ZSTD_PROGRAMS_LINK_SHARED, the make backend did not.
This commit adds support for ZSTD_PROGRAMS_LINK_SHARED in the make system and applies it for the target compilation, unless only static libs are supported.
--- ...D_PROGRAMS_LINK_SHARED-to-link-zstd-.patch | 80 +++++++++++++++++++ package/zstd/zstd.mk | 10 +++ 2 files changed, 90 insertions(+) create mode 100644 package/zstd/0002-make-support-ZSTD_PROGRAMS_LINK_SHARED-to-link-zstd-.patch
package/zstd/0002-make-support-ZSTD_PROGRAMS_LINK_SHARED-to-link-zstd-.patch new file +80 -0
@@ -0,0 +1,80 @@ +From afc368e7247abfe89250def5b7673a9ccb79e0b1 Mon Sep 17 00:00:00 2001 +From: Thomas De Schampheleire <[email protected]> +Date: Wed, 5 Aug 2020 15:35:01 +0200 +Subject: [PATCH] make: support ZSTD_PROGRAMS_LINK_SHARED to link zstd with + libzstd + +zstd allows building via make, cmake, meson, and others, but unfortunately +the features and flags used for these build systems are inconsistent. + +The cmake version respects an option 'ZSTD_PROGRAMS_LINK_SHARED' to let the +zstd binary link dynamically with its own libzstd. Without it, the zstd +program uses static linking and thus has a big size. + +This option is not provided in the 'make' system. There does exist a target +'zstd-dll' which intends to do exactly this, but it does not work out of the +box due to linking issues. These in turn are caused because the lib makefile +passes '-fvisibility=hidden' to the linker, which hides certain symbols that +the zstd program needs. The cmake-based compilation does not pass this +visibility flag, due to which all symbols are visible. + +Unfortunately, there is no 'install' rule that will install zstd-dll and +create the derived programs like zstdless etc. + +With the above in mind, when ZSTD_PROGRAMS_LINK_SHARED is set in make +context: +- remove '-fvisibility=hidden' from the lib compilation +- alter the 'zstd' target to not include the lib objects directly but link + dynamically with libzstd. + +See also https://github.com/facebook/zstd/issues/2261 which reported these +inconsistencies between make and cmake compilation. + +Signed-off-by: Thomas De Schampheleire <[email protected]> + +--- + lib/Makefile | 5 ++++- + programs/Makefile | 8 +++++++- + 2 files changed, 11 insertions(+), 2 deletions(-) + +diff --git a/lib/Makefile b/lib/Makefile +index 7c6dff02..8f9f36a6 100644 +--- a/lib/Makefile ++++ b/lib/Makefile +@@ -204,7 +204,10 @@ $(LIBZSTD): $(ZSTD_FILES) + else + + LIBZSTD = libzstd.$(SHARED_EXT_VER) +-$(LIBZSTD): LDFLAGS += -shared -fPIC -fvisibility=hidden ++$(LIBZSTD): LDFLAGS += -shared -fPIC ++ifndef ZSTD_PROGRAMS_LINK_SHARED ++$(LIBZSTD): LDFLAGS += -fvisibility=hidden ++endif + $(LIBZSTD): $(ZSTD_FILES) + @echo compiling dynamic library $(LIBVER) + $(Q)$(CC) $(FLAGS) $^ $(LDFLAGS) $(SONAME_FLAGS) -o $@ +diff --git a/programs/Makefile b/programs/Makefile +index 418ad4e6..8897dcf9 100644 +--- a/programs/Makefile ++++ b/programs/Makefile +@@ -169,10 +169,16 @@ $(ZSTDDECOMP_O): CFLAGS += $(ALIGN_LOOP) + zstd : CPPFLAGS += $(THREAD_CPP) $(ZLIBCPP) $(LZMACPP) $(LZ4CPP) + zstd : LDFLAGS += $(THREAD_LD) $(ZLIBLD) $(LZMALD) $(LZ4LD) $(DEBUGFLAGS_LD) + zstd : CPPFLAGS += -DZSTD_LEGACY_SUPPORT=$(ZSTD_LEGACY_SUPPORT) ++ifdef ZSTD_PROGRAMS_LINK_SHARED ++# link dynamically against own library ++zstd : LDFLAGS += -L$(ZSTDDIR) -lzstd ++else ++zstd : $(ZSTDLIB_FILES) ++endif + ifneq (,$(filter Windows%,$(OS))) + zstd : $(RES_FILE) + endif +-zstd : $(ZSTDLIB_FILES) $(ZSTD_CLI_OBJ) ++zstd : $(ZSTD_CLI_OBJ) + @echo "$(THREAD_MSG)" + @echo "$(ZLIB_MSG)" + @echo "$(LZMA_MSG)" +-- +2.26.2 +
package/zstd/zstd.mk +10 -0
@@ -43,9 +43,19 @@ ZSTD_INSTALL_LIBS = install-static else ifeq ($(BR2_SHARED_LIBS),y) ZSTD_BUILD_LIBS = libzstd ZSTD_INSTALL_LIBS = install-shared +ZSTD_OPTS += ZSTD_PROGRAMS_LINK_SHARED=1 else ZSTD_BUILD_LIBS = libzstd.a libzstd ZSTD_INSTALL_LIBS = install-static install-shared +ZSTD_OPTS += ZSTD_PROGRAMS_LINK_SHARED=1 +endif + +# The HAVE_THREAD flag is read by the 'programs' makefile but not by the 'lib' +# one. Building a multi-threaded binary with a library (which defaults to +# single-threaded) gives a runtime error when compressing files. +# The 'lib' makefile provides specific '%-mt' targets for this purpose. +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) +ZSTD_BUILD_LIBS := $(addsuffix -mt,$(ZSTD_BUILD_LIBS)) endif define ZSTD_BUILD_CMDS
Signature · 1 line
2.26.2
PATCH 2/2 package/zstd: link programs dynamically with libzstd to save space
Thomas, All,
On 2020-09-28 13:42 +0200, Thomas De Schampheleire spake thusly:
Quoted 7 lines
From: Thomas De Schampheleire <[email protected]>
Even when a shared libzstd is built, the zstd command-line programs are statically linked with libzstd, causing a large rootfs footprint.
While the cmake backend in zstd already supported a flag
ZSTD_PROGRAMS_LINK_SHARED, the make backend did not.
Any reason why we do not switch over to using cmake or meson? Both seem to be officially supported, see README.md:
## Build instructions
### Makefile
[...]
### cmake
[...]
### meson
[...]So, I'd rather we expend the effort to switch to cmake, as it already has ZSTD_PROGRAMS_LINK_SHARED (or to meson if it also fits the bill, whatever floats your boat), rather than patching the Makefile-based buildsystem.
Regards,
Yann E. MORIN.
Quoted 128 lines
This commit adds support for
ZSTD_PROGRAMS_LINK_SHAREDin the make system and applies it for the target compilation, unless only static libs are supported.Signed-off-by Thomas De Schampheleire <[email protected]>--- ...D_PROGRAMS_LINK_SHARED-to-link-zstd-.patch | 80 +++++++++++++++++++ package/zstd/zstd.mk | 10 +++ 2 files changed, 90 insertions(+) create mode 100644 package/zstd/0002-make-support-ZSTD_PROGRAMS_LINK_SHARED-to-link-zstd-.patchpackage/zstd/0002-make-support-ZSTD_PROGRAMS_LINK_SHARED-to-link-zstd-.patch new file +80
-0@@ -0,0 +1,80 @@ +From afc368e7247abfe89250def5b7673a9ccb79e0b1 Mon Sep 17 00:00:00 2001 +From: Thomas De Schampheleire <[email protected]> +Date: Wed, 5 Aug 2020 15:35:01 +0200 +Subject: [PATCH] make: support ZSTD_PROGRAMS_LINK_SHARED to link zstd with + libzstd + +zstd allows building via make, cmake, meson, and others, but unfortunately +the features and flags used for these build systems are inconsistent. + +The cmake version respects an option 'ZSTD_PROGRAMS_LINK_SHARED' to let the +zstd binary link dynamically with its own libzstd. Without it, the zstd +program uses static linking and thus has a big size. + +This option is not provided in the 'make' system. There does exist a target +'zstd-dll' which intends to do exactly this, but it does not work out of the +box due to linking issues. These in turn are caused because the lib makefile +passes '-fvisibility=hidden' to the linker, which hides certain symbols that +the zstd program needs. The cmake-based compilation does not pass this +visibility flag, due to which all symbols are visible. + +Unfortunately, there is no 'install' rule that will install zstd-dll and +create the derived programs like zstdless etc. + +With the above in mind, when ZSTD_PROGRAMS_LINK_SHARED is set in make +context: +- remove '-fvisibility=hidden' from the lib compilation +- alter the 'zstd' target to not include the lib objects directly but link + dynamically with libzstd. + +See also https://github.com/facebook/zstd/issues/2261 which reported these +inconsistencies between make and cmake compilation. + +Signed-off-by: Thomas De Schampheleire <[email protected]> + +--- + lib/Makefile | 5 ++++- + programs/Makefile | 8 +++++++- + 2 files changed, 11 insertions(+), 2 deletions(-) + +diff --git a/lib/Makefile b/lib/Makefile +index 7c6dff02..8f9f36a6 100644 +--- a/lib/Makefile ++++ b/lib/Makefile +@@ -204,7 +204,10 @@ $(LIBZSTD): $(ZSTD_FILES) + else + + LIBZSTD = libzstd.$(SHARED_EXT_VER) +-$(LIBZSTD): LDFLAGS += -shared -fPIC -fvisibility=hidden ++$(LIBZSTD): LDFLAGS += -shared -fPIC ++ifndef ZSTD_PROGRAMS_LINK_SHARED ++$(LIBZSTD): LDFLAGS += -fvisibility=hidden ++endif + $(LIBZSTD): $(ZSTD_FILES) + @echo compiling dynamic library $(LIBVER) + $(Q)$(CC) $(FLAGS) $^ $(LDFLAGS) $(SONAME_FLAGS) -o $@ +diff --git a/programs/Makefile b/programs/Makefile +index 418ad4e6..8897dcf9 100644 +--- a/programs/Makefile ++++ b/programs/Makefile +@@ -169,10 +169,16 @@ $(ZSTDDECOMP_O): CFLAGS += $(ALIGN_LOOP) + zstd : CPPFLAGS += $(THREAD_CPP) $(ZLIBCPP) $(LZMACPP) $(LZ4CPP) + zstd : LDFLAGS += $(THREAD_LD) $(ZLIBLD) $(LZMALD) $(LZ4LD) $(DEBUGFLAGS_LD) + zstd : CPPFLAGS += -DZSTD_LEGACY_SUPPORT=$(ZSTD_LEGACY_SUPPORT) ++ifdef ZSTD_PROGRAMS_LINK_SHARED ++# link dynamically against own library ++zstd : LDFLAGS += -L$(ZSTDDIR) -lzstd ++else ++zstd : $(ZSTDLIB_FILES) ++endif + ifneq (,$(filter Windows%,$(OS))) + zstd : $(RES_FILE) + endif +-zstd : $(ZSTDLIB_FILES) $(ZSTD_CLI_OBJ) ++zstd : $(ZSTD_CLI_OBJ) + @echo "$(THREAD_MSG)" + @echo "$(ZLIB_MSG)" + @echo "$(LZMA_MSG)" +-- +2.26.2 +package/zstd/zstd.mk +10
-0@@ -43,9 +43,19 @@ ZSTD_INSTALL_LIBS = install-static else ifeq ($(BR2_SHARED_LIBS),y) ZSTD_BUILD_LIBS = libzstd ZSTD_INSTALL_LIBS = install-shared +ZSTD_OPTS += ZSTD_PROGRAMS_LINK_SHARED=1 else ZSTD_BUILD_LIBS = libzstd.a libzstd ZSTD_INSTALL_LIBS = install-static install-shared +ZSTD_OPTS += ZSTD_PROGRAMS_LINK_SHARED=1 +endif + +# The HAVE_THREAD flag is read by the 'programs' makefile but not by the 'lib' +# one. Building a multi-threaded binary with a library (which defaults to +# single-threaded) gives a runtime error when compressing files. +# The 'lib' makefile provides specific '%-mt' targets for this purpose. +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) +ZSTD_BUILD_LIBS := $(addsuffix -mt,$(ZSTD_BUILD_LIBS)) endif define ZSTD_BUILD_CMDSSignature · 6 lines
2.26.2 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 2/2 package/zstd: link programs dynamically with libzstd to save space
Hi Yann,
Quoted 25 lines · On Mon, Sep 28, 2020, 21:40 Yann E. MORIN <[email protected]> wrote:
Thomas, All,
On 2020-09-28 13:42 +0200, Thomas De Schampheleire spake thusly:
Quoted 7 lines
From: Thomas De Schampheleire <[email protected]>
Even when a shared libzstd is built, the zstd command-line programs are statically linked with libzstd, causing a large rootfs footprint.
While the cmake backend in zstd already supported a flag
ZSTD_PROGRAMS_LINK_SHARED, the make backend did not.Any reason why we do not switch over to using cmake or meson? Both seem to be officially supported, see README.md:
## Build instructions ### Makefile [...] ### cmake [...] ### meson [...]
Quoted 5 lines
So, I'd rather we expend the effort to switch to cmake, as it already has
ZSTD_PROGRAMS_LINK_SHARED(or to meson if it also fits the bill, whatever floats your boat), rather than patching the Makefile-based buildsystem.
In fact, only the make system is 'official'. The other build systems are considered 'community-maintained'.
See e.g.
https://github.com/facebook/zstd/issues/1512
https://github.com/facebook/zstd/issues/1503
https://github.com/facebook/zstd/issues/1401
So from the perspective of the authors, only make is guaranteed to work.
Even though I think their makefiles are definitely not a good example, the cmake build rules are not equivalent in operation to make, see the issue I created myself:
https://github.com/facebook/zstd/issues/2261
So I wouldn't conclude that we better switch away from the make build system of zstd.
(I don't understand why they have rules for so many different build systems, which are then not aligned nor officially maintained. IMHO they better pick one and make sure it works well.)
Best regards
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200928/7a0d4650/attachment.html>
PATCH 2/2 package/zstd: link programs dynamically with libzstd to save space
In reply to Thomas De SchampheleireThomas, All,
Second review, as I forgot to read down to the end before replying...
On 2020-09-28 13:42 +0200, Thomas De Schampheleire spake thusly:
Quoted 8 lines
From: Thomas De Schampheleire <[email protected]>
Even when a shared libzstd is built, the zstd command-line programs are statically linked with libzstd, causing a large rootfs footprint.
While the cmake backend in zstd already supported a flag
ZSTD_PROGRAMS_LINK_SHARED, the make backend did not.
Quoted 6 lines
This commit adds support for
ZSTD_PROGRAMS_LINK_SHAREDin the make system and applies it for the target compilation, unless only static libs are supported.Signed-off-by Thomas De Schampheleire <[email protected]>---
[--SNIP--]
Quoted 12 lines
package/zstd/zstd.mk +1
-0@@ -43,9 +43,19 @@ ZSTD_INSTALL_LIBS = install-static else ifeq ($(BR2_SHARED_LIBS),y) ZSTD_BUILD_LIBS = libzstd ZSTD_INSTALL_LIBS = install-shared +ZSTD_OPTS += ZSTD_PROGRAMS_LINK_SHARED=1 else ZSTD_BUILD_LIBS = libzstd.a libzstd ZSTD_INSTALL_LIBS = install-static install-shared
package/zstd/zstd.mk ZSTD_INSTALL_LIBS = install-static · line 59
Quoted 10 lines
package/zstd/zstd.mk +9
-0+ZSTD_OPTS += ZSTD_PROGRAMS_LINK_SHARED=1 +endif + +# The HAVE_THREAD flag is read by the 'programs' makefile but not by the 'lib' +# one. Building a multi-threaded binary with a library (which defaults to +# single-threaded) gives a runtime error when compressing files. +# The 'lib' makefile provides specific '%-mt' targets for this purpose. +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) +ZSTD_BUILD_LIBS := $(addsuffix -mt,$(ZSTD_BUILD_LIBS)) endif
This last part seems unrelated, and should be in its own patch. If not, then it should be explained in the commit log.
Regards,
Yann E. MORIN.
Quoted 8 lines
package/zstd/zstd.mk +0
-0define ZSTD_BUILD_CMDSSignature · 6 lines
2.26.2 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 2/2 package/zstd: link programs dynamically with libzstd to save space
Quoted 40 lines · On Mon, Sep 28, 2020, 21:47 Yann E. MORIN <[email protected]> wrote:
Thomas, All,
Second review, as I forgot to read down to the end before replying...
On 2020-09-28 13:42 +0200, Thomas De Schampheleire spake thusly:
Quoted 5 lines
From: Thomas De Schampheleire <[email protected]>
Even when a shared libzstd is built, the zstd command-line programs are statically linked with libzstd, causing a large rootfs footprint.
Quoted 8 lines
While the cmake backend in zstd already supported a flag
ZSTD_PROGRAMS_LINK_SHARED, the make backend did not.This commit adds support for
ZSTD_PROGRAMS_LINK_SHAREDin the make system and applies it for the target compilation, unless only static libs are supported.Signed-off-by Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
Quoted 1 line
---
[--SNIP--]
Quoted 6 lines
package/zstd/zstd.mk +0
-0@@ -43,9 +43,19 @@ ZSTD_INSTALL_LIBS = install-static else ifeq ($(BR2_SHARED_LIBS),y)package/zstd/zstd.mk ZSTD_INSTALL_LIBS = install-static · line 53
Quoted 10 lines
package/zstd/zstd.mk +5
-0ZSTD_BUILD_LIBS = libzstd ZSTD_INSTALL_LIBS = install-shared +ZSTD_OPTS += ZSTD_PROGRAMS_LINK_SHARED=1 else ZSTD_BUILD_LIBS = libzstd.a libzstd ZSTD_INSTALL_LIBS = install-static install-shared +ZSTD_OPTS += ZSTD_PROGRAMS_LINK_SHARED=1 +endif + +# The HAVE_THREAD flag is read by the 'programs' makefile but not bythe 'lib'
package/zstd/zstd.mk ZSTD_INSTALL_LIBS = install-static · line 54
Quoted 1 line
package/zstd/zstd.mk +1
-0+# one. Building a multi-threaded binary with a library (which defaultsto
Quoted 9 lines
package/zstd/zstd.mk ZSTD_INSTALL_LIBS = install-static · line 59
Quoted 5 lines
package/zstd/zstd.mk +4
-0+# single-threaded) gives a runtime error when compressing files. +# The 'lib' makefile provides specific '%-mt' targets for this purpose. +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y) +ZSTD_BUILD_LIBS := $(addsuffix -mt,$(ZSTD_BUILD_LIBS)) endifThis last part seems unrelated, and should be in its own patch. If not, then it should be explained in the commit log.
The comment tries to explain it but it's probably not clear enough: the HAVE_THREAD flag that buildroot passes is interpreted by programs/Makefile. Before this patch, that makefile will build and link the library files directly together with the cli programs. This means that all these compilations use flags defined by this programs/Makefile.
When we change to use dynamic libraries, such that libzstd.so is built first, and that the programs just dynamically link with it, then there are two makefiles of importance:
- lib/Makefile : this makefile does not interpret HAVE_DEBUG and thus builds a single threaded library.
- programs/Makefile: would build a multithreaded program if Buildroot requests it.
We are thus left with a multithreaded program that links dynamically with a library which is build for singlethreaded operation, which is checked at runtime, resulting in an error.
As lib/Makefile already provides -mt rules to produce the libs for multithreaded operation, use them instead.
I think we could add this change as first patch, as it seems that today Buildroot would produce a libzstd.so supporting single-threaded operation only?
Best regards
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200928/f20940c2/attachment.html>
Yann E. MORIN
AppliedPATCH 1/2 package/zstd: avoid compilation during host-zstd install step
In reply to Thomas De SchampheleireThomas, All,
On 2020-09-28 13:42 +0200, Thomas De Schampheleire spake thusly:
Quoted 8 lines
From: Thomas De Schampheleire <[email protected]>
The host-zstd-build step was not actually compiling the library:
make[1]: Entering directory '/buildroot/output/build/host-zstd-1.4.5/lib' make[1]: Nothing to be done for 'default'.
make[1]: Leaving directory '/buildroot/output/build/host-zstd-1.4.5/lib'
Quoted 7 lines
and the actual compilation was part of the install step. This is not how other Buildroot packages work.
Make sure to specify which library targets we want instead. The total amount of compiled files does not change with this patch.
Signed-off-by Thomas De Schampheleire <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 24 lines
--- package/zstd/zstd.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/zstd/zstd.mk +1
-1@@ -71,7 +71,7 @@ endef # note: no 'HAVE_...' options for host library build only define HOST_ZSTD_BUILD_CMDS $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \ - -C $(@D)/lib + -C $(@D)/lib libzstd.a libzstd $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) \ -C $(@D) zstd endefSignature · 6 lines
2.26.2 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/2 package/zstd: avoid compilation during host-zstd install step
In reply to Thomas De SchampheleireQuoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas De Schampheleire <[email protected]> writes:
From: Thomas De Schampheleire <[email protected]> The host-zstd-build step was not actually compiling the library:
make[1]: Entering directory '/buildroot/output/build/host-zstd-1.4.5/lib' make[1]: Nothing to be done for 'default'.
make[1]: Leaving directory '/buildroot/output/build/host-zstd-1.4.5/lib'
Quoted 7 lines
and the actual compilation was part of the install step. This is not how other Buildroot packages work.
Make sure to specify which library targets we want instead. The total amount of compiled files does not change with this patch.
Signed-off-by Thomas De Schampheleire <[email protected]>
Committed to 2020.02.x, 2020.05.x and 2020.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard