perf stat: Expand events for each cgroup
Namhyung Kim
maintainerv5 cover perf stat: Expand events for each cgroup
Hello,
When we profile cgroup events with perf stat, it's very annoying to specify events and cgroups on the command line as it requires the mapping between events and cgroups. (Note that perf record can use cgroup sampling but it's not usable for perf stat).
I guess most cases we just want to use a same set of events (N) for all cgroups (M), but we need to specify NxM events and NxM cgroups. This is not good especially when profiling large number of cgroups:
say M=200.
So I added --for-each-cgroup option to make it easy for that case. It will create NxM events from N events and M cgroups. One more upside is that it can handle metrics too.
For example, the following example measures IPC metric for 3 cgroups
$ cat perf-expand-cgrp.sh #!/bin/sh
METRIC=${1:-IPC}
CGROUP_DIR=/sys/fs/cgroup/perf_eventsudo mkdir $CGROUP_DIR/A $CGROUP_DIR/B $CGROUP_DIR/C
# add backgroupd workload for each cgroup echo $$ | sudo tee $CGROUP_DIR/A/cgroup.procs > /dev/null yes > /dev/null & echo $$ | sudo tee $CGROUP_DIR/B/cgroup.procs > /dev/null yes > /dev/null & echo $$ | sudo tee $CGROUP_DIR/C/cgroup.procs > /dev/null yes > /dev/null &
# run 'perf stat' in the root cgroup echo $$ | sudo tee $CGROUP_DIR/cgroup.procs > /dev/null perf stat -a -M $METRIC --for-each-cgroup A,B,C sleep 1
kill %1 %2 %3
sudo rmdir $CGROUP_DIR/A $CGROUP_DIR/B $CGROUP_DIR/C
$ ./perf-expand-cgrp.sh IPC
Performance counter stats for 'system wide':
11,284,850,010 inst_retired.any A # 2.71 IPC
4,157,915,982 cpu_clk_unhalted.thread A
11,342,188,640 inst_retired.any B # 2.72 IPC
4,173,014,732 cpu_clk_unhalted.thread B
11,135,863,604 inst_retired.any C # 2.67 IPC
4,171,375,184 cpu_clk_unhalted.thread C 1.011948803 seconds time elapsed
* Changes from v4:
- fix python import error (Kernel test robot)
- make metric-related function calls conditional (Jiri)
* Changes from v3:
- rename to evlist__find_evsel (Jiri)
- add documentation (Arnaldo)
- check -G option together with --for-each-cgroup
* Changes from v2:
- put relevant fields in evsel together (Jiri)
- add various error checks (Jiri)
- split cgroup open patch (Jiri)
* Changes from v1:
- rename the option to --for-each-cgroup (Jiri)
- copy evsel fields explicitly (Jiri)
- add libpfm4 test (Ian)
The code is available at 'perf/cgroup-multiply-v5' branch on
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Thanks
Namhyung
Namhyung Kim (5):
perf evsel: Add evsel__clone() function
perf stat: Add --for-each-cgroup option
perf tools: Copy metric events properly when expand cgroups perf tools: Allow creation of cgroup without open perf test: Add expand cgroup event test
tools/perf/Documentation/perf-stat.txt | 5 + tools/perf/builtin-stat.c | 28 ++- tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test.c | 4 + tools/perf/tests/expand-cgroup.c | 241 +++++++++++++++++++++++++ tools/perf/tests/tests.h | 1 + tools/perf/util/cgroup.c | 115 +++++++++++- tools/perf/util/cgroup.h | 3 + tools/perf/util/evlist.c | 11 ++ tools/perf/util/evlist.h | 1 + tools/perf/util/evsel.c | 104 +++++++++++ tools/perf/util/evsel.h | 93 ++++++---- tools/perf/util/metricgroup.c | 85 +++++++++ tools/perf/util/metricgroup.h | 6 + tools/perf/util/python.c | 19 ++ tools/perf/util/stat.h | 1 + 16 files changed, 673 insertions(+), 45 deletions(-) create mode 100644 tools/perf/tests/expand-cgroup.c
Signature · 1 line
2.28.0.681.g6f77f65b4e-goog
Namhyung Kim
maintainerPATCH v5 1/5 perf evsel: Add evsel__clone() function
The evsel__clone() is to create an exactly same evsel from same attributes. The function assumes the given evsel is not configured yet so it cares fields set during event parsing. Those fields are now moved together as Jiri suggested. Note that metric events will be handled by later patch.
It will be used by perf stat to generate separate events for each cgroup.
--- tools/perf/util/evsel.c | 104 ++++++++++++++++++++++++++++++++++++++++ tools/perf/util/evsel.h | 93 ++++++++++++++++++++--------------- 2 files changed, 158 insertions(+), 39 deletions(-)
tools/perf/util/evsel.c +104 -0
@@ -331,6 +331,110 @@ struct evsel *evsel__new_cycles(bool precise) goto out; } +static int evsel__copy_config_terms (struct evsel *dst,struct evsel *src) +{ +struct evsel_config_term *pos, *tmp; + +list_for_each_entry (pos, &src->config_terms, list) { + tmp =malloc (sizeof (*tmp)); +if (tmp ==NULL ) +return -ENOMEM ; + + *tmp = *pos; +if (tmp->free_str) { + tmp->val.str =strdup (pos->val.str); +if (tmp->val.str ==NULL ) { +free (tmp); +return -ENOMEM ; + } + } +list_add_tail (&tmp->list, &dst->config_terms); + } +return 0 ; +} + +/** +* evsel__clone - create a new evsel copied from @orig +* @orig: original evsel +* +* The assumption is that @orig is not configured nor opened yet. +* So we only care about the attributes that can be set while it's parsed. +*/ +struct evsel *evsel__clone (struct evsel *orig) +{ +struct evsel *evsel; + +BUG_ON (orig->core.fd); +BUG_ON (orig->counts); +BUG_ON (orig->priv); +BUG_ON (orig->per_pkg_mask); + +/* cannot handle BPF objects for now */ +if (orig->bpf_obj) +return NULL ; + + evsel =evsel__new (&orig->core.attr); +if (evsel ==NULL ) +return NULL ; + + evsel->core.cpus =perf_cpu_map__get (orig->core.cpus); + evsel->core.own_cpus =perf_cpu_map__get (orig->core.own_cpus); + evsel->core.threads =perf_thread_map__get (orig->core.threads); + evsel->core.nr_members = orig->core.nr_members; + evsel->core.system_wide = orig->core.system_wide; + +if (orig->name) { + evsel->name =strdup (orig->name); +if (evsel->name ==NULL ) + goto out_err; + } +if (orig->group_name) { + evsel->group_name =strdup (orig->group_name); +if (evsel->group_name ==NULL ) + goto out_err; + } +if (orig->pmu_name) { + evsel->pmu_name =strdup (orig->pmu_name); +if (evsel->pmu_name ==NULL ) + goto out_err; + } +if (orig->filter) { + evsel->filter =strdup (orig->filter); +if (evsel->filter ==NULL ) + goto out_err; + } + evsel->cgrp =cgroup__get (orig->cgrp); + evsel->tp_format = orig->tp_format; + evsel->handler = orig->handler; + evsel->leader = orig->leader; + + evsel->max_events = orig->max_events; + evsel->tool_event = orig->tool_event; + evsel->unit = orig->unit; + evsel->scale = orig->scale; + evsel->snapshot = orig->snapshot; + evsel->per_pkg = orig->per_pkg; + evsel->percore = orig->percore; + evsel->precise_max = orig->precise_max; + evsel->use_uncore_alias = orig->use_uncore_alias; + evsel->is_libpfm_event = orig->is_libpfm_event; + + evsel->exclude_GH = orig->exclude_GH; + evsel->sample_read = orig->sample_read; + evsel->auto_merge_stats = orig->auto_merge_stats; + evsel->collect_stat = orig->collect_stat; + evsel->weak_group = orig->weak_group; + +if (evsel__copy_config_terms (evsel, orig) <0 ) + goto out_err; + +return evsel; + +out_err: +evsel__delete (evsel); +return NULL ; +} +/* * Returns pointer with encoded error via <linux/err.h> interface. */
tools/perf/util/evsel.h +54 -39
125 lines not on this page · raw message
Signature · 1 line
2.28.0.681.g6f77f65b4e-goog
Namhyung Kim
maintainerPATCH v5 2/5 perf stat: Add --for-each-cgroup option
In reply to Namhyung KimThe --for-each-cgroup option is a syntax sugar to monitor large number of cgroups easily. Current command line requires to list all the events and cgroups even if users want to monitor same events for each cgroup. This patch addresses that usage by copying given events for each cgroup on user's behalf.
For instance, if they want to monitor 6 events for 200 cgroups each they should write 1200 event names (with -e) AND 1200 cgroup names (with -G) on the command line. But with this change, they can just specify 6 events and 200 cgroups with a new option.
A simpler example below: It wants to measure 3 events for 2 cgroups ('A' and 'B'). The result is that total 6 events are counted like below.
$ ./perf stat -a -e cpu-clock,cycles,instructions --for-each-cgroup A,B sleep 1
Performance counter stats for 'system wide':
988.18 msec cpu-clock A # 0.987 CPUs utilized
3,153,761,702 cycles A # 3.200 GHz (100.00%)
8,067,769,847 instructions A # 2.57 insn per cycle (100.00%)
982.71 msec cpu-clock B # 0.982 CPUs utilized
3,136,093,298 cycles B # 3.182 GHz (99.99%)
8,109,619,327 instructions B # 2.58 insn per cycle (99.99%)1.001228054 seconds time elapsed
--- tools/perf/Documentation/perf-stat.txt | 5 ++ tools/perf/builtin-stat.c | 27 ++++++++- tools/perf/util/cgroup.c | 79 ++++++++++++++++++++++++++ tools/perf/util/cgroup.h | 1 + tools/perf/util/stat.h | 1 + 5 files changed, 112 insertions(+), 1 deletion(-)
tools/perf/Documentation/perf-stat.txt +5 -0
@@ -166,6 +166,11 @@ use '-e e1 -e e2 -G foo,foo' or just use '-e e1 -e e2 -G foo'. If wanting to monitor, say, 'cycles' for a cgroup and also for system wide, this command line can be used: 'perf stat -e cycles -G cgroup_name -a -e cycles'. +--for-each-cgroup name:: +Expand event list for each cgroup in "name" (allow multiple cgroups separated +by comma). This has same effect that repeating -e option and -G option for +each event x name. This option cannot be used with -G/--cgroup option. + -o file:: --output file:: Print the output into the designated file.
tools/perf/builtin-stat.c +26 -1
@@ -1060,6 +1060,17 @@ static int parse_control_option(const struct option *opt,return evlist__parse_control (str, &config->ctl_fd, &config->ctl_fd_ack, &config->ctl_fd_close); } +static int parse_stat_cgroups (const struct option *opt, +const char *str,int unset) +{ +if (stat_config.cgroup_list) { +pr_err ("--cgroup and --for-each-cgroup cannot be used together\n" ); +return -1 ; + } + +return parse_cgroups (opt, str, unset); +} +static struct option stat_options[] = {OPT_BOOLEAN ('T' ,"transaction" , &transaction_run,"hardware transaction statistics" ),
@@ -1103,7 +1114,9 @@ static struct option stat_options[] = {OPT_STRING ('x' ,"field-separator" , &stat_config.csv_sep,"separator" ,"print counts with custom separator" ),OPT_CALLBACK ('G' ,"cgroup" , &evsel_list,"name" , -"monitor event in cgroup name only" , parse_cgroups), +"monitor event in cgroup name only" , parse_stat_cgroups), +OPT_STRING (0 ,"for-each-cgroup" , &stat_config.cgroup_list,"name" , +"expand events for each cgroup" ),OPT_STRING ('o' ,"output" , &output_name,"file" ,"output file name" ),OPT_BOOLEAN (0 ,"append" , &append_file,"append to the output file" ), OPT_INTEGER(0, "log-fd", &output_fd,
@@ -2213,6 +2226,18 @@ int cmd_stat(int argc, const char **argv)if (add_default_attributes ()) goto out; +if (stat_config.cgroup_list) { +if (nr_cgroups >0 ) { +pr_err ("--cgroup and --for-each-cgroup cannot be used together\n" ); +parse_options_usage (stat_usage, stat_options,"G" ,1 ); +parse_options_usage (NULL , stat_options,"for-each-cgroup" ,0 ); + goto out; + } + +if (evlist__expand_cgroup (evsel_list, stat_config.cgroup_list) <0 ) + goto out; + } +target__validate (&target);if ((stat_config.aggr_mode ==AGGR_THREAD ) && (target.system_wide))
tools/perf/util/cgroup.c +79 -0
85 lines not on this page · raw message
tools/perf/util/cgroup.h +1 -0
@@ -24,6 +24,7 @@ void cgroup__put(struct cgroup *cgroup);struct evlist ;struct cgroup *evlist__findnew_cgroup (struct evlist *evlist,const char *name); +int evlist__expand_cgroup (struct evlist *evlist,const char *cgroups);void evlist__set_default_cgroup (struct evlist *evlist,struct cgroup *cgroup);
tools/perf/util/stat.h +1 -0
@@ -145,6 +145,7 @@ struct perf_stat_config {int ctl_fd;int ctl_fd_ack;bool ctl_fd_close; +const char *cgroup_list; };void perf_stat__set_big_num (int set);
Signature · 1 line
2.28.0.681.g6f77f65b4e-goog
Namhyung Kim
maintainerPATCH v5 3/5 perf tools: Copy metric events properly when expand cgroups
In reply to Namhyung KimThe metricgroup__copy_metric_events() is to handle metrics events when expanding event for cgroups. As the metric events keep pointers to evsel, it should be refreshed when events are cloned during the operation.
The perf_stat__collect_metric_expr() is also called in case an event has a metric directly.
During the copy, it references evsel by index as the evlist now has cloned evsels for the given cgroup.
Also kernel test robot found an issue in the python module import so add empty implementations of those two functions to fix it.
--- tools/perf/builtin-stat.c | 3 +- tools/perf/util/cgroup.c | 23 +++++++++- tools/perf/util/cgroup.h | 4 +- tools/perf/util/evlist.c | 11 +++++ tools/perf/util/evlist.h | 1 + tools/perf/util/metricgroup.c | 85 +++++++++++++++++++++++++++++++++++ tools/perf/util/metricgroup.h | 6 +++ tools/perf/util/python.c | 19 ++++++++ 8 files changed, 149 insertions(+), 3 deletions(-)
tools/perf/builtin-stat.c +2 -1
@@ -2234,7 +2234,8 @@ int cmd_stat(int argc, const char **argv) goto out; } -if (evlist__expand_cgroup (evsel_list, stat_config.cgroup_list) <0 ) +if (evlist__expand_cgroup (evsel_list, stat_config.cgroup_list, + &stat_config.metric_events) <0 ) goto out; }
tools/perf/util/cgroup.c +22 -1
@@ -3,6 +3,9 @@#include "evsel.h" #include "cgroup.h" #include "evlist.h" +#include "rblist.h" +#include "metricgroup.h" +#include "stat.h" #include <linux/zalloc.h> #include <sys/types.h> #include <sys/stat.h>
@@ -193,10 +196,12 @@ int parse_cgroups(const struct option *opt, const char *str,return 0 ; } -int evlist__expand_cgroup (struct evlist *evlist,const char *str) +int evlist__expand_cgroup (struct evlist *evlist,const char *str, +struct rblist *metric_events) {struct evlist *orig_list, *tmp_list;struct evsel *pos, *evsel, *leader; +struct rblist orig_metric_events;struct cgroup *cgrp =NULL ;const char *p, *e, *eos = str +strlen (str);int ret =-1 ;
@@ -217,6 +222,13 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str)perf_evlist__splice_list_tail (orig_list, &evlist->core.entries); evlist->core.nr_entries =0 ; +if (metric_events) { + orig_metric_events = *metric_events; +rblist__init (metric_events); + }else { +rblist__init (&orig_metric_events); + } +for (;;) { p =strchr (str,',' ); e = p ? p : eos;
@@ -255,6 +267,14 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str)cgroup__put (cgrp); nr_cgroups++; +if (metric_events) { +perf_stat__collect_metric_expr (tmp_list); +if (metricgroup__copy_metric_events (tmp_list, cgrp, + metric_events, + &orig_metric_events) <0 ) +break ; + } +perf_evlist__splice_list_tail (evlist, &tmp_list->core.entries); tmp_list->core.nr_entries =0 ;
@@ -268,6 +288,7 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str) out_err:evlist__delete (orig_list);evlist__delete (tmp_list); +rblist__exit (&orig_metric_events);return ret; }
tools/perf/util/cgroup.h +3 -1
@@ -22,9 +22,11 @@ struct cgroup *cgroup__get(struct cgroup *cgroup);void cgroup__put (struct cgroup *cgroup);struct evlist ; +struct rblist ;struct cgroup *evlist__findnew_cgroup (struct evlist *evlist,const char *name); -int evlist__expand_cgroup (struct evlist *evlist,const char *cgroups); +int evlist__expand_cgroup (struct evlist *evlist,const char *cgroups, +struct rblist *metric_events);void evlist__set_default_cgroup (struct evlist *evlist,struct cgroup *cgroup);
tools/perf/util/evlist.c +11 -0
@@ -1969,3 +1969,14 @@ int evlist__ctlfd_process(struct evlist *evlist, enum evlist_ctl_cmd *cmd)return err; } + +struct evsel *evlist__find_evsel (struct evlist *evlist,int idx) +{ +struct evsel *evsel; + +evlist__for_each_entry (evlist, evsel) { +if (evsel->idx == idx) +return evsel; + } +return NULL ; +}
tools/perf/util/evlist.h +1 -0
@@ -386,4 +386,5 @@ int evlist__ctlfd_ack(struct evlist *evlist);#define EVLIST_ENABLED_MSG "Events enabled\n"#define EVLIST_DISABLED_MSG "Events disabled\n" +struct evsel *evlist__find_evsel (struct evlist *evlist,int idx);#endif /* __PERF_EVLIST_H */
tools/perf/util/metricgroup.c +85 -0
94 lines not on this page · raw message
tools/perf/util/metricgroup.h +6 -0
@@ -7,11 +7,13 @@#include <stdbool.h> #include "pmu-events/pmu-events.h" +struct evlist ;struct evsel ;struct evlist ;struct option ;struct rblist ;struct pmu_events_map ; +struct cgroup ;struct metric_event {struct rb_node nd;
@@ -55,4 +57,8 @@ void metricgroup__print(bool metrics, bool groups, char *filter,bool metricgroup__has_metric (const char *metric);int arch_get_runtimeparam (struct pmu_event *pe__maybe_unused );void metricgroup__rblist_exit (struct rblist *metric_events); + +int metricgroup__copy_metric_events (struct evlist *evlist,struct cgroup *cgrp, +struct rblist *new_metric_events, +struct rblist *old_metric_events);#endif
tools/perf/util/python.c +19 -0
@@ -15,6 +15,8 @@#include "thread_map.h" #include "trace-event.h" #include "mmap.h" +#include "stat.h" +#include "metricgroup.h" #include "util/env.h" #include <internal/lib.h> #include "util.h"
@@ -60,6 +62,23 @@ int parse_callchain_record(const char *arg __maybe_unused,*/ struct perf_env perf_env; +/* +* Add this one here not to drag util/stat-shadow.c +*/ +void perf_stat__collect_metric_expr (struct evlist *evsel_list) +{ +} + +/* +* Add this one here not to drag util/metricgroup.c +*/ +int metricgroup__copy_metric_events (struct evlist *evlist,struct cgroup *cgrp, +struct rblist *new_metric_events, +struct rblist *old_metric_events) +{ +return 0 ; +} +/* * Support debug printing even though util/debug.c is not linked. That means * implementing 'verbose' and 'eprintf'.
Signature · 1 line
2.28.0.681.g6f77f65b4e-goog
Re: [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups
On Thu, Sep 24, 2020 at 09:44:53PM +0900, Namhyung Kim wrote:
SNIP
Quoted 12 lines
tools/perf/util/cgroup.c +7
-0+if (metric_events) { + orig_metric_events = *metric_events; +rblist__init (metric_events); + }else { +rblist__init (&orig_metric_events); + } +for (;;) { p =strchr (str,',' ); e = p ? p : eos;
tools/perf/util/cgroup.c int evlist__expand_cgroup(struct evlist *evlist, const char *str) · line 276
Quoted 10 lines
tools/perf/util/cgroup.c +7
-0@@ -255,6 +267,14 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str)cgroup__put (cgrp); nr_cgroups++; +if (metric_events) { +perf_stat__collect_metric_expr (tmp_list); +if (metricgroup__copy_metric_events (tmp_list, cgrp, + metric_events, + &orig_metric_events) <0 ) +break ; + }
looks good, do you plan to actualy add support for record? my ack from last version stays
thanks,
jirka
Namhyung Kim
maintainerRe: [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups
Quoted 20 lines · Jiri Olsa
On Thu, Sep 24, 2020 at 09:44:53PM +0900, Namhyung Kim wrote:
SNIP
Quoted 15 lines
tools/perf/util/cgroup.c +7
-0+if (metric_events) { + orig_metric_events = *metric_events; +rblist__init (metric_events); + }else { +rblist__init (&orig_metric_events); + } +for (;;) { p =strchr (str,',' ); e = p ? p : eos;@@ -255,6 +267,14 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str)cgroup__put (cgrp); nr_cgroups++;
Quoted 9 lines
tools/perf/util/cgroup.c int evlist__expand_cgroup(struct evlist *evlist, const char *str) · line 276
Quoted 7 lines
tools/perf/util/cgroup.c +7
-0+if (metric_events) { +perf_stat__collect_metric_expr (tmp_list); +if (metricgroup__copy_metric_events (tmp_list, cgrp, + metric_events, + &orig_metric_events) <0 ) +break ; + }looks good, do you plan to actualy add support for record?
No actually, I still think perf record should use --all-cgroups.
Quoted 1 line
my ack from last version stays
Thanks! But I didn't see your ack for this patch set. (I've only seen it for the perf inject patchset..)
Thanks
Namhyung
Jiri Olsa
Acked-byRe: [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups
Quoted 31 lines · Namhyung Kim
Quoted 20 lines · Jiri Olsa
On Thu, Sep 24, 2020 at 09:44:53PM +0900, Namhyung Kim wrote:
SNIP
Quoted 15 lines
tools/perf/util/cgroup.c +7
-0+if (metric_events) { + orig_metric_events = *metric_events; +rblist__init (metric_events); + }else { +rblist__init (&orig_metric_events); + } +for (;;) { p =strchr (str,',' ); e = p ? p : eos;@@ -255,6 +267,14 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str)cgroup__put (cgrp); nr_cgroups++;Quoted 9 lines
tools/perf/util/cgroup.c int evlist__expand_cgroup(struct evlist *evlist, const char *str) · line 276
Quoted 7 lines
tools/perf/util/cgroup.c +7
-0+if (metric_events) { +perf_stat__collect_metric_expr (tmp_list); +if (metricgroup__copy_metric_events (tmp_list, cgrp, + metric_events, + &orig_metric_events) <0 ) +break ; + }looks good, do you plan to actualy add support for record?
Quoted 6 lines
No actually, I still think perf record should use --all-cgroups.
Quoted 1 line
my ack from last version stays
Thanks! But I didn't see your ack for this patch set. (I've only seen it for the perf inject patchset..)
ah that was for the build id inject speed up.. too many patchsets flying around ;-)
thanks,
jirka
Arnaldo Carvalho de Melo
maintainerRe: [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups
Em Fri, Sep 25, 2020 at 03:51:33PM +0200, Jiri Olsa escreveu:
Quoted 7 lines · Namhyung Kim
Quoted 5 lines · Jiri Olsa
Quoted 1 line · Namhyung Kim
No actually, I still think perf record should use --all-cgroups.
Quoted 1 line
my ack from last version stays
Quoted 7 lines
Quoted 2 lines
Thanks! But I didn't see your ack for this patch set. (I've only seen it for the perf inject patchset..)
ah that was for the build id inject speed up.. too many patchsets flying around ;-)
Acked-by Jiri Olsa <[email protected]>
I take this is for the entire patchset, right?
- Arnaldo
Re: [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups
Quoted 11 lines · Arnaldo Carvalho de Melo
Em Fri, Sep 25, 2020 at 03:51:33PM +0200, Jiri Olsa escreveu:
Quoted 9 lines · Namhyung Kim
Quoted 8 lines · Jiri Olsa
Quoted 1 line · Namhyung Kim
No actually, I still think perf record should use --all-cgroups.
Quoted 1 line
my ack from last version stays
Thanks! But I didn't see your ack for this patch set. (I've only seen it for the perf inject patchset..)
Quoted 6 lines
Quoted 4 lines
ah that was for the build id inject speed up.. too many patchsets flying around ;-)
Acked-by Jiri Olsa <[email protected]>I take this is for the entire patchset, right?
yes
jirka
Arnaldo Carvalho de Melo
maintainerRe: [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups
In reply to Namhyung KimEm Thu, Sep 24, 2020 at 09:44:53PM +0900, Namhyung Kim escreveu:
Quoted 5 lines
The
metricgroup__copy_metric_events()is to handle metrics events when expanding event for cgroups. As the metric events keep pointers to evsel, it should be refreshed when events are cloned during the operation.
Quoted 8 lines
The
perf_stat__collect_metric_expr()is also called in case an event has a metric directly.During the copy, it references evsel by index as the evlist now has cloned evsels for the given cgroup.
Also kernel test robot found an issue in the python module import so add empty implementations of those two functions to fix it.
So, this is the alias I have to building perf:
alias m='perf stat -e cycles:u,instructions:u make -k O=/tmp/build/perf -C tools/perf install-bin ; perf test python'
:-)
Thanks, applying the whole series.
- Arnaldo
Quoted 308 lines
Cc John Garry <[email protected]>Cc Kajol Jain <[email protected]>Cc Ian Rogers <[email protected]>Reported-by kernel test robot <[email protected]>Signed-off-by Namhyung Kim <[email protected]>--- tools/perf/builtin-stat.c | 3 +- tools/perf/util/cgroup.c | 23 +++++++++- tools/perf/util/cgroup.h | 4 +- tools/perf/util/evlist.c | 11 +++++ tools/perf/util/evlist.h | 1 + tools/perf/util/metricgroup.c | 85 +++++++++++++++++++++++++++++++++++ tools/perf/util/metricgroup.h | 6 +++ tools/perf/util/python.c | 19 ++++++++ 8 files changed, 149 insertions(+), 3 deletions(-)tools/perf/builtin-stat.c +2
-1@@ -2234,7 +2234,8 @@ int cmd_stat(int argc, const char **argv) goto out; } -if (evlist__expand_cgroup (evsel_list, stat_config.cgroup_list) <0 ) +if (evlist__expand_cgroup (evsel_list, stat_config.cgroup_list, + &stat_config.metric_events) <0 ) goto out; }tools/perf/util/cgroup.c +22
-1@@ -3,6 +3,9 @@#include "evsel.h" #include "cgroup.h" #include "evlist.h" +#include "rblist.h" +#include "metricgroup.h" +#include "stat.h" #include <linux/zalloc.h> #include <sys/types.h> #include <sys/stat.h> @@ -193,10 +196,12 @@ int parse_cgroups(const struct option *opt, const char *str,return 0 ; } -int evlist__expand_cgroup (struct evlist *evlist,const char *str) +int evlist__expand_cgroup (struct evlist *evlist,const char *str, +struct rblist *metric_events) {struct evlist *orig_list, *tmp_list;struct evsel *pos, *evsel, *leader; +struct rblist orig_metric_events;struct cgroup *cgrp =NULL ;const char *p, *e, *eos = str +strlen (str);int ret =-1 ;@@ -217,6 +222,13 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str)perf_evlist__splice_list_tail (orig_list, &evlist->core.entries); evlist->core.nr_entries =0 ; +if (metric_events) { + orig_metric_events = *metric_events; +rblist__init (metric_events); + }else { +rblist__init (&orig_metric_events); + } +for (;;) { p =strchr (str,',' ); e = p ? p : eos;@@ -255,6 +267,14 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str)cgroup__put (cgrp); nr_cgroups++; +if (metric_events) { +perf_stat__collect_metric_expr (tmp_list); +if (metricgroup__copy_metric_events (tmp_list, cgrp, + metric_events, + &orig_metric_events) <0 ) +break ; + } +perf_evlist__splice_list_tail (evlist, &tmp_list->core.entries); tmp_list->core.nr_entries =0 ;@@ -268,6 +288,7 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str) out_err:evlist__delete (orig_list);evlist__delete (tmp_list); +rblist__exit (&orig_metric_events);return ret; }tools/perf/util/cgroup.h +3
-1@@ -22,9 +22,11 @@ struct cgroup *cgroup__get(struct cgroup *cgroup);void cgroup__put (struct cgroup *cgroup);struct evlist ; +struct rblist ;struct cgroup *evlist__findnew_cgroup (struct evlist *evlist,const char *name); -int evlist__expand_cgroup (struct evlist *evlist,const char *cgroups); +int evlist__expand_cgroup (struct evlist *evlist,const char *cgroups, +struct rblist *metric_events);void evlist__set_default_cgroup (struct evlist *evlist,struct cgroup *cgroup);tools/perf/util/evlist.c +11
-0@@ -1969,3 +1969,14 @@ int evlist__ctlfd_process(struct evlist *evlist, enum evlist_ctl_cmd *cmd)return err; } + +struct evsel *evlist__find_evsel (struct evlist *evlist,int idx) +{ +struct evsel *evsel; + +evlist__for_each_entry (evlist, evsel) { +if (evsel->idx == idx) +return evsel; + } +return NULL ; +}tools/perf/util/evlist.h +1
-0@@ -386,4 +386,5 @@ int evlist__ctlfd_ack(struct evlist *evlist);#define EVLIST_ENABLED_MSG "Events enabled\n"#define EVLIST_DISABLED_MSG "Events disabled\n" +struct evsel *evlist__find_evsel (struct evlist *evlist,int idx);#endif /* __PERF_EVLIST_H */ tools/perf/util/metricgroup.c +85
-0@@ -24,6 +24,7 @@#include <api/fs/fs.h> #include "util.h" #include <asm/bug.h> +#include "cgroup.h" struct metric_event *metricgroup__lookup(struct rblist *metric_events, struct evsel *evsel,@@ -1120,3 +1121,87 @@ bool metricgroup__has_metric(const char *metric) }return false; } + +int metricgroup__copy_metric_events (struct evlist *evlist,struct cgroup *cgrp, +struct rblist *new_metric_events, +struct rblist *old_metric_events) +{ +unsigned i; + +for (i =0 ; i <rblist__nr_entries (old_metric_events); i++) { +struct rb_node *nd; +struct metric_event *old_me, *new_me; +struct metric_expr *old_expr, *new_expr; +struct evsel *evsel; +size_t alloc_size; +int idx, nr; + + nd =rblist__entry (old_metric_events, i); + old_me = container_of(nd, struct metric_event, nd); + + evsel =evlist__find_evsel (evlist, old_me->evsel->idx); +if (!evsel) +return -EINVAL ; + new_me =metricgroup__lookup (new_metric_events, evsel, true); +if (!new_me) +return -ENOMEM ; + +pr_debug ("copying metric event for cgroup '%s': %s (idx=%d)\n" , + cgrp ? cgrp->name :"root" , evsel->name, evsel->idx); + +list_for_each_entry (old_expr, &old_me->head, nd) { + new_expr =malloc (sizeof (*new_expr)); +if (!new_expr) +return -ENOMEM ; + + new_expr->metric_expr = old_expr->metric_expr; + new_expr->metric_name = old_expr->metric_name; + new_expr->metric_unit = old_expr->metric_unit; + new_expr->runtime = old_expr->runtime; + +if (old_expr->metric_refs) { +/* calculate number of metric_events */ +for (nr =0 ; old_expr->metric_refs[nr].metric_name; nr++) +continue ; + alloc_size =sizeof (*new_expr->metric_refs); + new_expr->metric_refs =calloc (nr +1 , alloc_size); +if (!new_expr->metric_refs) { +free (new_expr); +return -ENOMEM ; + } + +memcpy (new_expr->metric_refs, old_expr->metric_refs, + nr * alloc_size); + }else { + new_expr->metric_refs =NULL ; + } + +/* calculate number of metric_events */ +for (nr =0 ; old_expr->metric_events[nr]; nr++) +continue ; + alloc_size =sizeof (*new_expr->metric_events); + new_expr->metric_events =calloc (nr +1 , alloc_size); +if (!new_expr->metric_events) { +free (new_expr->metric_refs); +free (new_expr); +return -ENOMEM ; + } + +/* copy evsel in the same position */ +for (idx =0 ; idx < nr; idx++) { + evsel = old_expr->metric_events[idx]; + evsel =evlist__find_evsel (evlist, evsel->idx); +if (evsel ==NULL ) { +free (new_expr->metric_events); +free (new_expr->metric_refs); +free (new_expr); +return -EINVAL ; + } + new_expr->metric_events[idx] = evsel; + } + +list_add (&new_expr->nd, &new_me->head); + } + } +return 0 ; +}tools/perf/util/metricgroup.h +6
-0@@ -7,11 +7,13 @@#include <stdbool.h> #include "pmu-events/pmu-events.h" +struct evlist ;struct evsel ;struct evlist ;struct option ;struct rblist ;struct pmu_events_map ; +struct cgroup ;struct metric_event {struct rb_node nd;@@ -55,4 +57,8 @@ void metricgroup__print(bool metrics, bool groups, char *filter,bool metricgroup__has_metric (const char *metric);int arch_get_runtimeparam (struct pmu_event *pe__maybe_unused );void metricgroup__rblist_exit (struct rblist *metric_events); + +int metricgroup__copy_metric_events (struct evlist *evlist,struct cgroup *cgrp, +struct rblist *new_metric_events, +struct rblist *old_metric_events);#endif tools/perf/util/python.c +19
-0@@ -15,6 +15,8 @@#include "thread_map.h" #include "trace-event.h" #include "mmap.h" +#include "stat.h" +#include "metricgroup.h" #include "util/env.h" #include <internal/lib.h> #include "util.h" @@ -60,6 +62,23 @@ int parse_callchain_record(const char *arg __maybe_unused,*/ struct perf_env perf_env; +/* +* Add this one here not to drag util/stat-shadow.c +*/ +void perf_stat__collect_metric_expr (struct evlist *evsel_list) +{ +} + +/* +* Add this one here not to drag util/metricgroup.c +*/ +int metricgroup__copy_metric_events (struct evlist *evlist,struct cgroup *cgrp, +struct rblist *new_metric_events, +struct rblist *old_metric_events) +{ +return 0 ; +} +/* * Support debug printing even though util/debug.c is not linked. That means * implementing 'verbose' and 'eprintf'. Signature · 1 line
2.28.0.681.g6f77f65b4e-goog
Signature · 1 line
- Arnaldo
Namhyung Kim
maintainerPATCH v5 4/5 perf tools: Allow creation of cgroup without open
In reply to Namhyung KimThis is a preparation for a test case of expanding events for multiple cgroups. Instead of using real system cgroup, the test will use fake cgroups so it needs a way to have them without a open file descriptor.
--- tools/perf/builtin-stat.c | 2 +- tools/perf/util/cgroup.c | 19 ++++++++++++------- tools/perf/util/cgroup.h | 2 +- 3 files changed, 14 insertions(+), 9 deletions(-)
tools/perf/builtin-stat.c +1 -1
@@ -2235,7 +2235,7 @@ int cmd_stat(int argc, const char **argv) }if (evlist__expand_cgroup (evsel_list, stat_config.cgroup_list, - &stat_config.metric_events) <0 ) + &stat_config.metric_events, true) <0 ) goto out; }
tools/perf/util/cgroup.c +12 -7
@@ -51,7 +51,7 @@ static struct cgroup *evlist__find_cgroup(struct evlist *evlist, const char *strreturn NULL ; } -static struct cgroup *cgroup__new (const char *name) +static struct cgroup *cgroup__new (const char *name,bool do_open) {struct cgroup *cgroup =zalloc (sizeof (*cgroup));
@@ -61,9 +61,14 @@ static struct cgroup *cgroup__new(const char *name) cgroup->name =strdup (name);if (!cgroup->name) goto out_err; - cgroup->fd =open_cgroup (name); -if (cgroup->fd ==-1 ) - goto out_free_name; + +if (do_open) { + cgroup->fd =open_cgroup (name); +if (cgroup->fd ==-1 ) + goto out_free_name; + }else { + cgroup->fd =-1 ; + } }return cgroup;
@@ -79,7 +84,7 @@ struct cgroup *evlist__findnew_cgroup(struct evlist *evlist, const char *name) {struct cgroup *cgroup =evlist__find_cgroup (evlist, name); -return cgroup ?:cgroup__new (name); +return cgroup ?:cgroup__new (name, true); }static int add_cgroup (struct evlist *evlist,const char *str)
@@ -197,7 +202,7 @@ int parse_cgroups(const struct option *opt, const char *str, }int evlist__expand_cgroup (struct evlist *evlist,const char *str, -struct rblist *metric_events) +struct rblist *metric_events,bool open_cgroup) {struct evlist *orig_list, *tmp_list;struct evsel *pos, *evsel, *leader;
@@ -240,7 +245,7 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str,if (!name) goto out_err; - cgrp =cgroup__new (name); + cgrp =cgroup__new (name, open_cgroup);free (name);if (cgrp ==NULL ) goto out_err;
tools/perf/util/cgroup.h +1 -1
@@ -26,7 +26,7 @@ struct rblist;struct cgroup *evlist__findnew_cgroup (struct evlist *evlist,const char *name);int evlist__expand_cgroup (struct evlist *evlist,const char *cgroups, -struct rblist *metric_events); +struct rblist *metric_events,bool open_cgroup);void evlist__set_default_cgroup (struct evlist *evlist,struct cgroup *cgroup);
Signature · 1 line
2.28.0.681.g6f77f65b4e-goog
Namhyung Kim
maintainerPATCH v5 5/5 perf test: Add expand cgroup event test
In reply to Namhyung KimIt'll expand given events for cgroups A, B and C.
$ ./perf test -v expansion
69: Event expansion for cgroups :
--- start ---
test child forked, pid 983140
metric expr 1 / IPC for CPI
metric expr instructions / cycles for IPC
found event instructions
found event cycles
adding {instructions,cycles}:W
copying metric event for cgroup 'A': instructions (idx=0)
copying metric event for cgroup 'B': instructions (idx=0)
copying metric event for cgroup 'C': instructions (idx=0)
test child finished with 0
---- end ----
Event expansion for cgroups: Ok--- tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test.c | 4 + tools/perf/tests/expand-cgroup.c | 241 +++++++++++++++++++++++++++++++ tools/perf/tests/tests.h | 1 + 4 files changed, 247 insertions(+) create mode 100644 tools/perf/tests/expand-cgroup.c
tools/perf/tests/Build +1 -0
@@ -61,6 +61,7 @@ perf-y += demangle-java-test.o perf-y += pfm.o perf-y += parse-metric.o perf-y += pe-file-parsing.o +perf-y += expand-cgroup.o $(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c tests/Build $(call rule_mkdir)
tools/perf/tests/builtin-test.c +4 -0
@@ -345,6 +345,10 @@ static struct test generic_tests[] = { .desc = "PE file support", .func = test__pe_file_parsing, }, + { + .desc = "Event expansion for cgroups", + .func = test__expand_cgroup_events, + }, { .func = NULL, },
tools/perf/tests/expand-cgroup.c new file +241 -0
241 lines not on this page · raw message
tools/perf/tests/tests.h +1 -0
@@ -123,6 +123,7 @@ const char *test__pfm_subtest_get_desc(int subtest);int test__pfm_subtest_get_nr (void );int test__parse_metric (struct test *test,int subtest);int test__pe_file_parsing (struct test *test,int subtest); +int test__expand_cgroup_events (struct test *test,int subtest);bool test__bp_signal_is_supported (void );bool test__bp_account_is_supported (void );
Signature · 1 line
2.28.0.681.g6f77f65b4e-goog