Skip to contentSkip to conversation

dt-bindings: serial: fsl-imx-uart: fix i.MX 53 and 6 compatible matching

PATCH Applied Krzysztof Kozlowski 3 participants 5 messages Sep 25, 2020 – Oct 6, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: serial: fsl-imx-uart: fix i.MX 53 and 6 compatible matching

The i.MX 53 and i.MX6Q DTS use two compatibles, i.MX 6SL/6SLL/SX three so update the binding to fix dtbs_check warnings like:

serial@21ec000: compatible: ['fsl,imx6q-uart', 'fsl,imx21-uart'] is not valid under any of the given schemas

---
 .../devicetree/bindings/serial/fsl-imx-uart.yaml          | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml +6 -2
index 3d896173b3b0..9ff85bc6859c 100644
@@ -18,8 +18,6 @@ properties:
     oneOf:
       - const: fsl,imx1-uart
       - const: fsl,imx21-uart
-      - const: fsl,imx53-uart
-      - const: fsl,imx6q-uart
       - items:
           - enum:
             - fsl,imx25-uart
@@ -28,12 +26,18 @@ properties:
             - fsl,imx35-uart
             - fsl,imx50-uart
             - fsl,imx51-uart
+            - fsl,imx53-uart
+            - fsl,imx6q-uart
           - const: fsl,imx21-uart
       - items:
           - enum:
             - fsl,imx6sl-uart
             - fsl,imx6sll-uart
             - fsl,imx6sx-uart
+          - const: fsl,imx6q-uart
+          - const: fsl,imx21-uart
+      - items:
+          - enum:
             - fsl,imx6ul-uart
             - fsl,imx7d-uart
             - fsl,imx8mm-uart
Signature · 1 line
2.17.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Krzysztof Kozlowski

The i.MX 53 and i.MX6Q DTS use two compatibles, i.MX 6SL/6SLL/SX three so update the binding to fix dtbs_check warnings like:

serial@21ec000: compatible: ['fsl,imx6q-uart', 'fsl,imx21-uart'] is not valid under any of the given schemas

---
 .../devicetree/bindings/serial/fsl-imx-uart.yaml          | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
#2 lore raw
In reply to Krzysztof Kozlowski
Quoted 9 lines · Krzysztof Kozlowski

The i.MX 53 and i.MX6Q DTS use two compatibles, i.MX 6SL/6SLL/SX three so update the binding to fix dtbs_check warnings like:

serial@21ec000: compatible: ['fsl,imx6q-uart', 'fsl,imx21-uart'] is not valid under any of the given schemas

---
 .../devicetree/bindings/serial/fsl-imx-uart.yaml          | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

This doesn't apply to my tty tree :(

#3 lore raw
Quoted 5 lines · Greg Kroah-Hartman
Quoted 3 lines · Krzysztof Kozlowski

The i.MX 53 and i.MX6Q DTS use two compatibles, i.MX 6SL/6SLL/SX three so update the binding to fix dtbs_check warnings like:

Quoted 8 lines
Quoted 6 lines

serial@21ec000: compatible: ['fsl,imx6q-uart', 'fsl,imx21-uart'] is not valid under any of the given schemas

---
 .../devicetree/bindings/serial/fsl-imx-uart.yaml          | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

This doesn't apply to my tty tree :(

It is rebased on my previous fsl-imx-uart dt-bindings patch which was picked up by Rob. Otherwise there would be conflicts.

Rob,
Could you pick this up as well?

Best regards,
Krzysztof

maintainer Applied
#4 lore raw
Quoted 14 lines · Krzysztof Kozlowski
Quoted 12 lines · Greg Kroah-Hartman
Quoted 9 lines · Krzysztof Kozlowski

The i.MX 53 and i.MX6Q DTS use two compatibles, i.MX 6SL/6SLL/SX three so update the binding to fix dtbs_check warnings like:

serial@21ec000: compatible: ['fsl,imx6q-uart', 'fsl,imx21-uart'] is not valid under any of the given schemas

---
 .../devicetree/bindings/serial/fsl-imx-uart.yaml          | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Quoted 7 lines
Quoted 1 line

This doesn't apply to my tty tree :(

It is rebased on my previous fsl-imx-uart dt-bindings patch which was picked up by Rob. Otherwise there would be conflicts.

Rob,
Could you pick this up as well?

Applied.

Rob