Skip to contentSkip to conversation

ARM: dts: bcm2835: Change firmware compatible from simple-bus to simple-mfd

PATCH Applied Maxime Ripard 2 participants 2 messages Sep 24, 2020 – Sep 28, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: bcm2835: Change firmware compatible from simple-bus to simple-mfd

The current binding for the RPi firmware uses the simple-bus compatible as a fallback to benefit from its automatic probing of child nodes.

However, simple-bus also comes with some constraints, like having the ranges, our case.

Let's switch to simple-mfd that provides the same probing logic without those constraints.

---
 .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml        | 4 ++--
 arch/arm/boot/dts/bcm2835-rpi.dtsi                            | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml +2 -2
index 17e4f20c8d39..6834f5e8df5f 100644
@@ -23,7 +23,7 @@ properties:
   compatible:
     items:
       - const: raspberrypi,bcm2835-firmware
-      - const: simple-bus
+      - const: simple-mfd
 
   mboxes:
     $ref: '/schemas/types.yaml#/definitions/phandle'
@@ -57,7 +57,7 @@ required:
 examples:
   - |
     firmware {
-        compatible = "raspberrypi,bcm2835-firmware", "simple-bus";
+        compatible = "raspberrypi,bcm2835-firmware", "simple-mfd";
         mboxes = <&mailbox>;
 
         firmware_clocks: clocks {
arch/arm/boot/dts/bcm2835-rpi.dtsi +1 -1
index f7ae5a4530b8..d94357b21f7e 100644
@@ -13,7 +13,7 @@ act {
 
 	soc {
 		firmware: firmware {
-			compatible = "raspberrypi,bcm2835-firmware", "simple-bus";
+			compatible = "raspberrypi,bcm2835-firmware", "simple-mfd";
 			#address-cells = <1>;
 			#size-cells = <1>;
 
Signature · 7 lines
2.26.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer Applied
#1 lore raw
Quoted 6 lines · Maxime Ripard

The current binding for the RPi firmware uses the simple-bus compatible as a fallback to benefit from its automatic probing of child nodes.

However, simple-bus also comes with some constraints, like having the ranges, our case.

Quoted 9 lines

Let's switch to simple-mfd that provides the same probing logic without those constraints.

---
 .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml        | 4 ++--
 arch/arm/boot/dts/bcm2835-rpi.dtsi                            | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks!