Skip to contentSkip to conversation

collectd: make rrdtool and rrdcached optional

PATCH In review Sinan Kaya 2 participants 3 messages Sep 29, 2020

lore
Share & tools
lore

Sinan Kaya

author
#0 lore raw

PATCH 1/1 collectd: make rrdtool and rrdcached optional

rrdtool plugin pulls x11 library dependencies into the target. It should be only set on need basis.

---
 meta-oe/recipes-extended/collectd/collectd_5.12.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-extended/collectd/collectd_5.12.0.bb +2 -0
index 40a8442a53..b9e735f27d 100644
@@ -49,6 +49,8 @@ PACKAGECONFIG[libesmtp] = "--with-libesmtp,--without-libesmtp,libesmtp"
 PACKAGECONFIG[libmnl] = "--with-libmnl,--without-libmnl,libmnl"
 PACKAGECONFIG[libatasmart] = "--with-libatasmart,--without-libatasmart,libatasmart"
 PACKAGECONFIG[ldap] = "--enable-openldap --with-libldap,--disable-openldap --without-libldap, openldap"
+PACKAGECONFIG[rrdtool] = "--enable-rrdtool,--disable-rrdtool,rrdtool"
+PACKAGECONFIG[rrdcached] = "--enable-rrdcached,--disable-rrdcached,rrdcached"
 
 EXTRA_OECONF = " \
                 ${FPLAYOUT} \
Signature · 1 line
2.17.1
#1 lore raw
Quoted 4 lines · Sinan Kaya

rrdtool plugin pulls x11 library dependencies into the target. It should be only set on need basis.

I do not see x11 in either collectd dependencies or rrdtools, is that an oversight ?

Quoted 24 lines
---
 meta-oe/recipes-extended/collectd/collectd_5.12.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-extended/collectd/collectd_5.12.0.bb +2 -1
index 40a8442a53..b9e735f27d 100644
@@ -49,6 +49,8 @@ PACKAGECONFIG[libesmtp] = "--with-libesmtp,--without-libesmtp,libesmtp"
 PACKAGECONFIG[libmnl] = "--with-libmnl,--without-libmnl,libmnl"
 PACKAGECONFIG[libatasmart] = "--with-libatasmart,--without-libatasmart,libatasmart"
 PACKAGECONFIG[ldap] = "--enable-openldap --with-libldap,--disable-openldap --without-libldap, openldap"
+PACKAGECONFIG[rrdtool] = "--enable-rrdtool,--disable-rrdtool,rrdtool"
+PACKAGECONFIG[rrdcached] = "--enable-rrdcached,--disable-rrdcached,rrdcached"
 
 EXTRA_OECONF = " \
                 ${FPLAYOUT} \
--

2.17.1

author
#2 lore raw
Quoted 7 lines · Khem Raj
Quoted 3 lines · Sinan Kaya

rrdtool plugin pulls x11 library dependencies into the target. It should be only set on need basis.

I do not see x11 in either collectd dependencies or rrdtools, is that an oversight ?

Here is the dependency tree. It gets pulled because of pango.

"rrdtool" -> "/bin/sh"
"rrdtool" -> "ld-linux.so.3"
"rrdtool" -> "ld-linux.so.3(GLIBC_2.4)"
"rrdtool" -> "libc6" [label=">= 2.28"]
"rrdtool" -> "libcairo2" [label=">= 1.14.12"]
"rrdtool" -> "libcairo.so.2"
"rrdtool" -> "libc.so.6"
"rrdtool" -> "libc.so.6(GLIBC_2.11)"
"rrdtool" -> "libc.so.6(GLIBC_2.27)"
"rrdtool" -> "libc.so.6(GLIBC_2.28)"
"rrdtool" -> "libc.so.6(GLIBC_2.4)"
"rrdtool" -> "libc.so.6(GLIBC_2.8)"
"rrdtool" -> "libglib-2.0-0" [label=">= 2.58.0"]
"rrdtool" -> "libglib-2.0.so.0"
"rrdtool" -> "libgobject-2.0.so.0"
"rrdtool" -> "libm.so.6"
"rrdtool" -> "libm.so.6(GLIBC_2.4)"
"rrdtool" -> "libpango-1.0.so.0"
"rrdtool" -> "libpangocairo-1.0.so.0"
"rrdtool" -> "libpng16-16" [label=">= 1.6.36"]
"rrdtool" -> "libpng16.so.16"
"rrdtool" -> "libpng16.so.16(PNG16_0)"
"rrdtool" -> "libpthread.so.0"
"rrdtool" -> "libpthread.so.0(GLIBC_2.4)"
"rrdtool" -> "librrd.so.8"
"rrdtool" -> "libxml2" [label=">= 2.9.8"]
"rrdtool" -> "libxml2.so.2"
"rrdtool" -> "libxml2.so.2(LIBXML2_2.4.30)"
"rrdtool" -> "libxml2.so.2(LIBXML2_2.6.0)"
"rrdtool" -> "libxml2.so.2(LIBXML2_2.6.17)"
"rrdtool" -> "pango" [label=">= 1.42.4"]
"rrdtool" -> "perl"
"rrdtool" -> "rtld(GNU_HASH)"

"pango" -> "/bin/sh"
"pango" -> "ld-linux.so.3"
"pango" -> "ld-linux.so.3(GLIBC_2.4)"
"pango" -> "libc6" [label=">= 2.28"]
"pango" -> "libcairo2" [label=">= 1.14.12"]
"pango" -> "libcairo.so.2"
"pango" -> "libc.so.6"
"pango" -> "libc.so.6(GLIBC_2.4)"
"pango" -> "libc.so.6(GLIBC_2.7)"
"pango" -> "libfontconfig1" [label=">= 2.12.6"]
"pango" -> "libfontconfig.so.1"
"pango" -> "libfreetype6" [label=">= 2.9.1"]
"pango" -> "libfreetype.so.6"
"pango" -> "libfribidi0" [label=">= 1.0.5"]
"pango" -> "libfribidi.so.0"
"pango" -> "libglib-2.0-0" [label=">= 2.58.0"]
"pango" -> "libglib-2.0.so.0"
"pango" -> "libgobject-2.0.so.0"
"pango" -> "libgthread-2.0.so.0"
"pango" -> "libharfbuzz0" [label=">= 1.8.8"]
"pango" -> "libharfbuzz.so.0"
"pango" -> "libm.so.6"
"pango" -> "libm.so.6(GLIBC_2.4)"
"pango" -> "libpango-1.0.so.0"
"pango" -> "libpangocairo-1.0.so.0"
"pango" -> "libpangoft2-1.0.so.0"
"pango" -> "libpangoxft-1.0.so.0"
"pango" -> "libpthread.so.0"
"pango" -> "libpthread.so.0(GLIBC_2.4)"
"pango" -> "libx11-6" [label=">= 1.6.6"]
"pango" -> "libX11.so.6"
"pango" -> "libxft2" [label=">= 2.3.2"]
"pango" -> "libXft.so.2"
"pango" -> "libxrender1" [label=">= 0.9.10"]
"pango" -> "libXrender.so.1"
"pango" -> "rtld(GNU_HASH)"