Skip to contentSkip to conversation

dt-bindings: arm: fsl: Add imx8mn ddr3l evk board

PATCH In review Jacky Bai 3 participants 5 messages Sep 27, 2020 – Sep 29, 2020

Subsystems (2)
lore
Share & tools
lore

Jacky Bai

author
#0 lore raw

PATCH 1/2 dt-bindings: arm: fsl: Add imx8mn ddr3l evk board

Add entry for i.MX8MN DDR3L EVK board.

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 1ca9dfa8ce9a..8199528b47ed 100644
@@ -417,6 +417,7 @@ properties:
       - description: i.MX8MN based Boards
         items:
           - enum:
+              - fsl,imx8mn-ddr3l-evk      # i.MX8MN DDR3L EVK Board
               - fsl,imx8mn-ddr4-evk       # i.MX8MN DDR4 EVK Board
               - fsl,imx8mn-evk            # i.MX8MN LPDDR4 EVK Board
           - const: fsl,imx8mn
Signature · 1 line
2.26.2
author
#1 lore raw

PATCH 2/2 arm64: dts: freescale: Add imx8mn ddr3l evk board support

For i.MX8MN DDR3L EVK board, it populates with the 11x11 package with no GPU, no display module compared to 14x14 package. For the board design, it is same as LPDDR4 board except that the display related interface is removed.

---
 arch/arm64/boot/dts/freescale/Makefile             |  1 +
 arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts | 11 +++++++++++
 2 files changed, 12 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts
arch/arm64/boot/dts/freescale/Makefile +1 -0
index f8d59433af01..4edcbd920a8f 100644
@@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr3l-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-var-som-symphony.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb
arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts new file +11 -0
new file mode 100644
index 000000000000..854cb3a525f0
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+ /*
+  * Copyright 2020 NXP
+  */
+
+#include "imx8mn-evk.dts"
+
+/ {
+	model = "NXP i.MX8MNano DDR3L EVK board";
+	compatible = "fsl,imx8mn-ddr3l-evk", "fsl,imx8mn";
+};
Signature · 1 line
2.26.2
#2 lore raw

Re: [PATCH 2/2] arm64: dts: freescale: Add imx8mn ddr3l evk board support

Quoted 30 lines · Jacky Bai

For i.MX8MN DDR3L EVK board, it populates with the 11x11 package with no GPU, no display module compared to 14x14 package. For the board design, it is same as LPDDR4 board except that the display related interface is removed.

---
 arch/arm64/boot/dts/freescale/Makefile             |  1 +
 arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts | 11 +++++++++++
 2 files changed, 12 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts
arch/arm64/boot/dts/freescale/Makefile +1 -0
index f8d59433af01..4edcbd920a8f 100644
@@ -33,6 +33,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr3l-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-var-som-symphony.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb
arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts new file +0 -0
new file mode 100644
index 000000000000..854cb3a525f0

arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts line 6

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts new file +6 -0
@@ -0,0 +1,11 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+ /*
+  * Copyright 2020 NXP
+  */
+
+#include "imx8mn-evk.dts"

This should be an include of shared DTSI. You could avoid splitting/renaming if you started with DTSI at beginning, knowing that there will be multiple boards like that, with only minor differences.

arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts line 9

Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8mn-ddr3l-evk.dts new file +3 -0
+
+/ {
+	model = "NXP i.MX8MNano DDR3L EVK board";

NXP advertises it as "i.MX 8M Nano" (with spaces).

Best regards,
Krzysztof