drm/vmwgfx: Fix error handling in get_node
Subsystems (3)
PATCH 1/1 drm/vmwgfx: Fix error handling in get_node
From: Zack Rusin <[email protected]>
ttm_mem_type_manager_func.get_node was changed to return -ENOSPC instead of setting the node pointer to NULL. Unfortunately vmwgfx still had two places where it was explicitly converting -ENOSPC to 0 causing regressions. This fixes those spots by allowing -ENOSPC to be returned. That seems to fix recent regressions with vmwgfx.
Signed-off-by Zack Rusin <[email protected]>
Reviewed-by Roland Scheidegger <[email protected]>
Reviewed-by Martin Krastev <[email protected]>
Sigend-off-by Roland Scheidegger <[email protected]>
--- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_thp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c +1 -1
@@ -55,7 +55,7 @@ static int vmw_gmrid_man_get_node(struct ttm_mem_type_manager *man, id =ida_alloc_max (&gman->gmr_ida, gman->max_gmr_ids -1 ,GFP_KERNEL );if (id <0 ) -return (id != -ENOMEM ?0 : id); +return id;spin_lock (&gman->lock);
drivers/gpu/drm/vmwgfx/vmwgfx_thp.c +1 -1
@@ -95,7 +95,7 @@ static int vmw_thp_get_node(struct ttm_mem_type_manager *man, mem->start = node->start; } -return 0 ; +return ret; }
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 1 line · Roland Scheidegger (VMware)
Sigend-off-by Roland Scheidegger <[email protected]>
^^^
typo
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel