Skip to contentSkip to conversation

dt-bindings: gpio: pca953x: Add support for the NXP PCAL9554B/C

PATCH Superseded Mike Looijmans 4 participants 12 messages Sep 30, 2020 – Oct 8, 2020 2 messages not in the archive

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: gpio: pca953x: Add support for the NXP PCAL9554B/C

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

This adds the entry to the devicetree bindings.

---
v2: Split devicetree and code into separate patches

 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/gpio/gpio-pca953x.txt +1 -0
index 3126c3817e2a..99dc1936f633 100644
@@ -20,6 +20,7 @@ Required properties:
 	nxp,pcal6416
 	nxp,pcal6524
 	nxp,pcal9535
+	nxp,pcal9554b
 	nxp,pcal9555a
 	maxim,max7310
 	maxim,max7312
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 2/2 gpio: pca953x: Add support for the NXP PCAL9554B/C

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

---
v2: Split devicetree and code into separate patches

 drivers/gpio/gpio-pca953x.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpio/gpio-pca953x.c +2 -0
index bd2e96c34f82..fb946b01512d 100644
@@ -90,6 +90,7 @@ static const struct i2c_device_id pca953x_id[] = {
 	{ "pcal6416", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
 	{ "pcal6524", 24 | PCA953X_TYPE | PCA_LATCH_INT, },
 	{ "pcal9535", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
+	{ "pcal9554b", 8  | PCA953X_TYPE | PCA_LATCH_INT, },
 	{ "pcal9555a", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
 
 	{ "max7310", 8  | PCA953X_TYPE, },
@@ -1237,6 +1238,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
 	{ .compatible = "nxp,pcal6416", .data = OF_953X(16, PCA_LATCH_INT), },
 	{ .compatible = "nxp,pcal6524", .data = OF_953X(24, PCA_LATCH_INT), },
 	{ .compatible = "nxp,pcal9535", .data = OF_953X(16, PCA_LATCH_INT), },
+	{ .compatible = "nxp,pcal9554b", .data = OF_953X( 8, PCA_LATCH_INT), },
 	{ .compatible = "nxp,pcal9555a", .data = OF_953X(16, PCA_LATCH_INT), },
 
 	{ .compatible = "maxim,max7310", .data = OF_953X( 8, 0), },
Signature · 1 line
2.17.1
Reviewed-by on v2 2/2
#2 lore raw

Re: [PATCH v2 2/2] gpio: pca953x: Add support for the NXP PCAL9554B/C

Quoted 7 lines · Mike Looijmans

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

---

I'll let Linus pick it up, I already sent my final PR for v5.10.

Bartosz

#3 lore raw

Re: [PATCH v2 2/2] gpio: pca953x: Add support for the NXP PCAL9554B/C

In reply to Mike Looijmans
Quoted 7 lines · Mike Looijmans

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

---
v2: Split devicetree and code into separate patches

Patch applied.

Yours,
Linus Walleij

Reviewed-by on v2 1/2
#4 lore raw
In reply to Mike Looijmans
Quoted 27 lines · Mike Looijmans

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

This adds the entry to the devicetree bindings.

---
v2: Split devicetree and code into separate patches

 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/gpio/gpio-pca953x.txt +1 -1
index 3126c3817e2a..99dc1936f633 100644
@@ -20,6 +20,7 @@ Required properties:
        nxp,pcal6416
        nxp,pcal6524
        nxp,pcal9535
+       nxp,pcal9554b
        nxp,pcal9555a
        maxim,max7310
        maxim,max7312
--
Quoted 2 lines

2.17.1

Reviewed-by on v2 1/2
#5 lore raw
In reply to Mike Looijmans
Quoted 9 lines · Mike Looijmans

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

This adds the entry to the devicetree bindings.

---
v2: Split devicetree and code into separate patches

This patch 1/2 does not apply to my tree, I suppose Rob has to apply it?

I will try to apply 2/2.

Yours,
Linus Walleij

#6 lore raw

Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topicproducts.com

Please consider the environment before printing this e-mail

Quoted 13 lines · Linus Walleij
Quoted 9 lines · Mike Looijmans

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

This adds the entry to the devicetree bindings.

---
v2: Split devicetree and code into separate patches

Quoted 7 lines

This patch 1/2 does not apply to my tree, I suppose Rob has to apply it?

I will try to apply 2/2.

Yours,
Linus Walleij

I based the patches on the current master. Well, master a few days ago. A rebase on current master also had no complaints.

Signature · 1 line
Mike Looijmans
maintainer
#7 lore raw
In reply to Linus Walleij
Quoted 8 lines · Linus Walleij
Quoted 6 lines · Mike Looijmans

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

This adds the entry to the devicetree bindings.

Quoted 8 lines
Quoted 3 lines

---
v2: Split devicetree and code into separate patches

This patch 1/2 does not apply to my tree, I suppose Rob has to apply it?

Nope, no changes in my tree.

Rob

#8 lore raw
Quoted 13 lines · Rob Herring
Quoted 12 lines · Linus Walleij
Quoted 9 lines · Mike Looijmans

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

This adds the entry to the devicetree bindings.

---
v2: Split devicetree and code into separate patches

Quoted 6 lines
Quoted 4 lines

This patch 1/2 does not apply to my tree, I suppose Rob has to apply it?

Nope, no changes in my tree.

Weird, OK Mike apply this wherever it should be applied or rebase on my GPIO tree and resend if you want me to apply it.

Yours,
Linus Walleij

#9 lore raw

Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topicproducts.com

Please consider the environment before printing this e-mail

Quoted 16 lines · Linus Walleij
Quoted 15 lines · Rob Herring
Quoted 14 lines · Linus Walleij
Quoted 9 lines · Mike Looijmans

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

This adds the entry to the devicetree bindings.

---
v2: Split devicetree and code into separate patches

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

This patch 1/2 does not apply to my tree, I suppose Rob has to apply it?

Nope, no changes in my tree.

Weird, OK Mike apply this wherever it should be applied or rebase on my GPIO tree and resend if you want me to apply it.

Could you provide me a git URL + branch to rebase it on, i'll send you a new patch then.

#10 lore raw
Quoted 20 lines · Mike Looijmans
Quoted 19 lines · Linus Walleij
Quoted 18 lines · Rob Herring
Quoted 16 lines · Linus Walleij
Quoted 9 lines · Mike Looijmans

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

This adds the entry to the devicetree bindings.

---
v2: Split devicetree and code into separate patches

This patch 1/2 does not apply to my tree, I suppose Rob has to apply it?

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Nope, no changes in my tree.

Weird, OK Mike apply this wherever it should be applied or rebase on my GPIO tree and resend if you want me to apply it.

Could you provide me a git URL + branch to rebase it on, i'll send you a new patch then.

It's this:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel

git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git devel

Yours,
Linus Walleij

maintainer Acked-by on v2 1/2
#11 lore raw
In reply to Mike Looijmans
Quoted 4 lines · Mike Looijmans

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

Quoted 9 lines

This adds the entry to the devicetree bindings.

---
v2: Split devicetree and code into separate patches

 Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 1 +
 1 file changed, 1 insertion(+)