Skip to contentSkip to conversation

MAINTAINERS: Update section for cpuidle-psci

PATCH In review Ulf Hansson 4 participants 8 messages Aug 14, 2020 – Sep 30, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Update section for cpuidle-psci

Extend the file pattern to also include cpuidle-psci.h and cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer, particularly to help with the support for PM domains.

Cc Sudeep Holla <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -1
index f9ae8ea54e27..66821197175e 100644
@@ -4556,10 +4556,11 @@ F:	drivers/cpuidle/cpuidle-exynos.c
 CPUIDLE DRIVER - ARM PSCI
 M:	Lorenzo Pieralisi <[email protected]>
 M:	Sudeep Holla <[email protected]>
+M:	Ulf Hansson <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Supported
-F:	drivers/cpuidle/cpuidle-psci.c
+F:	drivers/cpuidle/cpuidle-psci*
 
 CRAMFS FILESYSTEM
 M:	Nicolas Pitre <[email protected]>
Signature · 1 line
2.25.1
#1 lore raw
Quoted 8 lines · Ulf Hansson

Extend the file pattern to also include cpuidle-psci.h and cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer, particularly to help with the support for PM domains.

Cc Sudeep Holla <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>

Any objections from the original maintainers?

Quoted 24 lines
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -2
index f9ae8ea54e27..66821197175e 100644
@@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
 CPUIDLE DRIVER - ARM PSCI
 M:     Lorenzo Pieralisi <[email protected]>
 M:     Sudeep Holla <[email protected]>
+M:     Ulf Hansson <[email protected]>
 L:     [email protected]
 L:     [email protected]
 S:     Supported
-F:     drivers/cpuidle/cpuidle-psci.c
+F:     drivers/cpuidle/cpuidle-psci*
 
 CRAMFS FILESYSTEM
 M:     Nicolas Pitre <[email protected]>
--

2.25.1

#2 lore raw
Quoted 11 lines · Rafael J. Wysocki
Quoted 8 lines · Ulf Hansson

Extend the file pattern to also include cpuidle-psci.h and cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer, particularly to help with the support for PM domains.

Cc Sudeep Holla <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>

Any objections from the original maintainers?

The PSCI driver providing support for platform coordinated idle states (that this patch is targeting AFAICS) does not require more maintainers, that support is complete and Sudeep and I will take care of refactoring and fixes.

If the OSI bits in it require a specific maintainer I would prefer those bits to be moved into a specific file and maintainership added _explicitly_ for that file only.

Thanks,
Lorenzo

Quoted 23 lines
Quoted 23 lines
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -2
index f9ae8ea54e27..66821197175e 100644
@@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
 CPUIDLE DRIVER - ARM PSCI
 M:     Lorenzo Pieralisi <[email protected]>
 M:     Sudeep Holla <[email protected]>
+M:     Ulf Hansson <[email protected]>
 L:     [email protected]
 L:     [email protected]
 S:     Supported
-F:     drivers/cpuidle/cpuidle-psci.c
+F:     drivers/cpuidle/cpuidle-psci*
 
 CRAMFS FILESYSTEM
 M:     Nicolas Pitre <[email protected]>
--

2.25.1

#3 lore raw
Quoted 14 lines · Lorenzo Pieralisi
Quoted 11 lines · Rafael J. Wysocki
Quoted 8 lines · Ulf Hansson

Extend the file pattern to also include cpuidle-psci.h and cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer, particularly to help with the support for PM domains.

Cc Sudeep Holla <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>

Any objections from the original maintainers?

Quoted 8 lines

The PSCI driver providing support for platform coordinated idle states (that this patch is targeting AFAICS) does not require more maintainers, that support is complete and Sudeep and I will take care of refactoring and fixes.

If the OSI bits in it require a specific maintainer I would prefer those bits to be moved into a specific file and maintainership added _explicitly_ for that file only.

My main concern is that the OSI support (and some related changes for genpd) is still being worked upon. The corresponding code deserves to be looked after by someone. I offer my help with this.

I guess we can split up the code as you suggest, but perhaps another way would be to explicitly state my part of the responsibility in MAINTAINERS. Along the lines of this:

M: Ulf Hansson <[email protected]> # OSI support / PM domains

Would that be okay to you?

Kind regards
Uffe

Quoted 27 lines

Thanks,
Lorenzo

Quoted 23 lines
Quoted 23 lines
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -2
index f9ae8ea54e27..66821197175e 100644
@@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
 CPUIDLE DRIVER - ARM PSCI
 M:     Lorenzo Pieralisi <[email protected]>
 M:     Sudeep Holla <[email protected]>
+M:     Ulf Hansson <[email protected]>
 L:     [email protected]
 L:     [email protected]
 S:     Supported
-F:     drivers/cpuidle/cpuidle-psci.c
+F:     drivers/cpuidle/cpuidle-psci*
 
 CRAMFS FILESYSTEM
 M:     Nicolas Pitre <[email protected]>
--

2.25.1

#4 lore raw
Quoted 21 lines · Ulf Hansson
Quoted 19 lines · Lorenzo Pieralisi
Quoted 11 lines · Rafael J. Wysocki
Quoted 8 lines · Ulf Hansson

Extend the file pattern to also include cpuidle-psci.h and cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer, particularly to help with the support for PM domains.

Cc Sudeep Holla <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>

Any objections from the original maintainers?

The PSCI driver providing support for platform coordinated idle states (that this patch is targeting AFAICS) does not require more maintainers, that support is complete and Sudeep and I will take care of refactoring and fixes.

Quoted 7 lines
Quoted 3 lines

If the OSI bits in it require a specific maintainer I would prefer those bits to be moved into a specific file and maintainership added _explicitly_ for that file only.

My main concern is that the OSI support (and some related changes for genpd) is still being worked upon. The corresponding code deserves to be looked after by someone. I offer my help with this.

All OSI changes can go into cpuidle-psci-domain.c, you can add a maintainer entry for that.

Quoted 7 lines

I guess we can split up the code as you suggest, but perhaps another way would be to explicitly state my part of the responsibility in MAINTAINERS. Along the lines of this:

M: Ulf Hansson <[email protected]> # OSI support / PM domains

Would that be okay to you?

No because there should be no need, as I have already said. If you need to change cpuidle-psci.c send patches please and we will review them.

Thanks,
Lorenzo

Quoted 26 lines
Quoted 26 lines

Thanks,
Lorenzo

Quoted 23 lines
Quoted 23 lines
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -2
index f9ae8ea54e27..66821197175e 100644
@@ -4556,10 +4556,11 @@ F:      drivers/cpuidle/cpuidle-exynos.c
 CPUIDLE DRIVER - ARM PSCI
 M:     Lorenzo Pieralisi <[email protected]>
 M:     Sudeep Holla <[email protected]>
+M:     Ulf Hansson <[email protected]>
 L:     [email protected]
 L:     [email protected]
 S:     Supported
-F:     drivers/cpuidle/cpuidle-psci.c
+F:     drivers/cpuidle/cpuidle-psci*
 
 CRAMFS FILESYSTEM
 M:     Nicolas Pitre <[email protected]>
--

2.25.1

#5 lore raw
Quoted 27 lines · Lorenzo Pieralisi
Quoted 25 lines · Ulf Hansson
Quoted 22 lines · Lorenzo Pieralisi
Quoted 11 lines · Rafael J. Wysocki
Quoted 8 lines · Ulf Hansson

Extend the file pattern to also include cpuidle-psci.h and cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer, particularly to help with the support for PM domains.

Cc Sudeep Holla <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>

Any objections from the original maintainers?

The PSCI driver providing support for platform coordinated idle states (that this patch is targeting AFAICS) does not require more maintainers, that support is complete and Sudeep and I will take care of refactoring and fixes.

If the OSI bits in it require a specific maintainer I would prefer those bits to be moved into a specific file and maintainership added _explicitly_ for that file only.

Quoted 6 lines
Quoted 3 lines

My main concern is that the OSI support (and some related changes for genpd) is still being worked upon. The corresponding code deserves to be looked after by someone. I offer my help with this.

All OSI changes can go into cpuidle-psci-domain.c, you can add a maintainer entry for that.

Alright. Most of the things are already in there, but I will try to move the rest as well then.

Quoted 11 lines
Quoted 8 lines

I guess we can split up the code as you suggest, but perhaps another way would be to explicitly state my part of the responsibility in MAINTAINERS. Along the lines of this:

M: Ulf Hansson <[email protected]> # OSI support / PM domains

Would that be okay to you?

No because there should be no need, as I have already said. If you need to change cpuidle-psci.c send patches please and we will review them.

I sent a small series "Enable s2idle when using PSCI OSI [1]" a month ago, but haven't received any feedback. I guess moving all OSI parts to cpuidle-psci-domain.c would help, as we wouldn't need to bother you with these OSI specific things then.

[...]

Kind regards
Uffe

[1]
https://www.spinics.net/lists/arm-kernel/msg833933.html

#6 lore raw
Quoted 48 lines · Ulf Hansson
Quoted 27 lines · Lorenzo Pieralisi
Quoted 25 lines · Ulf Hansson
Quoted 22 lines · Lorenzo Pieralisi
Quoted 11 lines · Rafael J. Wysocki
Quoted 8 lines · Ulf Hansson

Extend the file pattern to also include cpuidle-psci.h and cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer, particularly to help with the support for PM domains.

Cc Sudeep Holla <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>

Any objections from the original maintainers?

The PSCI driver providing support for platform coordinated idle states (that this patch is targeting AFAICS) does not require more maintainers, that support is complete and Sudeep and I will take care of refactoring and fixes.

If the OSI bits in it require a specific maintainer I would prefer those bits to be moved into a specific file and maintainership added _explicitly_ for that file only.

Quoted 6 lines
Quoted 3 lines

My main concern is that the OSI support (and some related changes for genpd) is still being worked upon. The corresponding code deserves to be looked after by someone. I offer my help with this.

All OSI changes can go into cpuidle-psci-domain.c, you can add a maintainer entry for that.

Alright. Most of the things are already in there, but I will try to move the rest as well then.

Quoted 9 lines
Quoted 8 lines

I guess we can split up the code as you suggest, but perhaps another way would be to explicitly state my part of the responsibility in MAINTAINERS. Along the lines of this:

M: Ulf Hansson <[email protected]> # OSI support / PM domains

Would that be okay to you?

Quoted 8 lines
Quoted 2 lines

No because there should be no need, as I have already said. If you need to change cpuidle-psci.c send patches please and we will review them.

I sent a small series "Enable s2idle when using PSCI OSI [1]" a month ago, but haven't received any feedback. I guess moving all OSI parts to cpuidle-psci-domain.c would help, as we wouldn't need to bother you with these OSI specific things then.

As I mentioned in one of the thread, I was confused with multiple series at the same time and I believe there were S2I/S2R related patches from you and one more person. I was confused and about to go on vacation. I will take a look at it.

--
Regards,
Sudeep

#7 lore raw
In reply to Lorenzo Pieralisi
Quoted 37 lines · Lorenzo Pieralisi
Quoted 21 lines · Ulf Hansson
Quoted 19 lines · Lorenzo Pieralisi
Quoted 11 lines · Rafael J. Wysocki
Quoted 8 lines · Ulf Hansson

Extend the file pattern to also include cpuidle-psci.h and cpuidle-psci-domain.c. Moreover, add myself as a co-maintainer, particularly to help with the support for PM domains.

Cc Sudeep Holla <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>

Any objections from the original maintainers?

The PSCI driver providing support for platform coordinated idle states (that this patch is targeting AFAICS) does not require more maintainers, that support is complete and Sudeep and I will take care of refactoring and fixes.

Quoted 7 lines
Quoted 3 lines

If the OSI bits in it require a specific maintainer I would prefer those bits to be moved into a specific file and maintainership added _explicitly_ for that file only.

My main concern is that the OSI support (and some related changes for genpd) is still being worked upon. The corresponding code deserves to be looked after by someone. I offer my help with this.

All OSI changes can go into cpuidle-psci-domain.c, you can add a maintainer entry for that.

Quoted 4 lines

I guess we can split up the code as you suggest, but perhaps another way would be to explicitly state my part of the responsibility in MAINTAINERS. Along the lines of this:

Quoted 7 lines
Quoted 3 lines

M: Ulf Hansson <[email protected]> # OSI support / PM domains

Would that be okay to you?

No because there should be no need, as I have already said. If you need to change cpuidle-psci.c send patches please and we will review them.

I agree and recollect that was the main idea when we moved all the OSI specific PM domain code to separate file.

--
Regards,
Sudeep