Skip to contentSkip to conversation

io_setup01: Handle no AIO support in kernel

PATCH New Richard Palethorpe 2 participants 4 messages Sep 30, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 io_setup01: Handle no AIO support in kernel

---

Here are 3 more tests modified to check for ENOSYS. There are other tests which still don't check, but they appear to be only listed under the AIO runtest files.

 testcases/kernel/syscalls/io_setup/io_setup01.c | 2 ++
 1 file changed, 2 insertions(+)
testcases/kernel/syscalls/io_setup/io_setup01.c +2 -0
index 4693f8fbb..28aee7831 100644
@@ -53,6 +53,8 @@ static void verify_success(unsigned int nr, io_context_t *ctx, int init_val)
 	memset(ctx, init_val, sizeof(*ctx));
 
 	TEST(io_setup(nr, ctx));
+	if (TST_RET == -ENOSYS)
+		tst_brk(TCONF | TRERRNO, "io_setup(): AIO not supported by kernel");
 	if (TST_RET != 0) {
 		tst_res(TFAIL, "io_setup() failed unexpectedly with %li (%s)",
 			TST_RET, tst_strerrno(-TST_RET));
Signature · 1 line
2.28.0
#1 lore raw

PATCH 2/3 io_pgetevents{01,02}: Handle no AIO support

---
 testcases/kernel/syscalls/io_pgetevents/io_pgetevents01.c | 8 +++++---
 testcases/kernel/syscalls/io_pgetevents/io_pgetevents02.c | 8 +++++---
 2 files changed, 10 insertions(+), 6 deletions(-)
testcases/kernel/syscalls/io_pgetevents/io_pgetevents01.c +5 -3
index 2a1aad8d9..a0b56d814 100644
@@ -51,9 +51,11 @@ static void run(void)
 	fd = SAFE_OPEN("io_pgetevents_file", O_RDWR | O_CREAT, 0644);
 	io_prep_pwrite(&cb, fd, data, 4096, 0);
 
-	ret = io_setup(1, &ctx);
-	if (ret < 0)
-		tst_brk(TBROK | TERRNO, "io_setup() failed");
+	TEST(io_setup(1, &ctx));
+	if (TST_RET == -ENOSYS)
+		tst_brk(TCONF | TRERRNO, "io_setup(): AIO not supported by kernel");
+	if (TST_RET < 0)
+		tst_brk(TBROK | TRERRNO, "io_setup() failed");
 
 	ret = io_submit(ctx, 1, cbs);
 	if (ret != 1)
testcases/kernel/syscalls/io_pgetevents/io_pgetevents02.c +5 -3
index 28afdb4a0..af71e17fe 100644
@@ -65,9 +65,11 @@ static void setup(void)
 	fd = SAFE_OPEN("io_pgetevents_file", O_RDWR | O_CREAT, 0644);
 	io_prep_pwrite(&cb, fd, data, 4096, 0);
 
-	ret = io_setup(1, &ctx);
-	if (ret < 0)
-		tst_brk(TBROK | TERRNO, "io_setup() failed");
+	TEST(io_setup(1, &ctx));
+	if (TST_RET == -ENOSYS)
+		tst_brk(TCONF | TRERRNO, "io_setup(): AIO not supported by kernel");
+	if (TST_RET < 0)
+		tst_brk(TBROK | TRERRNO, "io_setup() failed");
 
 	ctx_initialized = 1;
 
Signature · 1 line
2.28.0
#2 lore raw

PATCH 3/3 eventfd01: Handle no AIO support

In reply to Richard Palethorpe
---
 testcases/kernel/syscalls/eventfd/eventfd01.c | 5 +++++
 1 file changed, 5 insertions(+)
testcases/kernel/syscalls/eventfd/eventfd01.c +5 -0
index e4f9c804a..4d888910b 100644
@@ -510,6 +510,11 @@ static int trigger_eventfd_overflow(int evfd, int *fd, io_context_t * ctx)
 	ret = io_setup(16, ctx);
 	if (ret < 0) {
 		errno = -ret;
+		if (errno == ENOSYS) {
+			tst_brkm(TCONF | TERRNO, cleanup,
+				 "io_setup(): AIO not supported by kernel");
+		}
+
 		tst_resm(TINFO | TERRNO, "io_setup error");
 		return -1;
 	}
Signature · 1 line
2.28.0