PCI: cadence: Retrain Link to work around Gen2 training defect.
PATCH v3 1/1 PCI: cadence: Retrain Link to work around Gen2 training defect.
Cadence controller will not initiate autonomous speed change if strapped as Gen2. The Retrain Link bit is set as quirk to enable this speed change.
---
Changes in v3:
- To set retrain link bit,checking device capability & link status.
- 32bit read in place of 8bit.
- Minor correction in patch comment.
- Change in variable & macro name.
Changes in v2:
- 16bit read in place of 8bit.
drivers/pci/controller/cadence/pcie-cadence-host.c | 31 ++++++++++++++++++++++ drivers/pci/controller/cadence/pcie-cadence.h | 9 ++++++- 2 files changed, 39 insertions(+), 1 deletion(-)
drivers/pci/controller/cadence/pcie-cadence-host.c +31 -0
@@ -77,6 +77,36 @@ static struct pci_ops cdns_pcie_host_ops = { .write = pci_generic_config_write, }; +static void cdns_pcie_retrain (struct cdns_pcie *pcie) +{ +u32 lnk_cap_sls, pcie_cap_off =CDNS_PCIE_RP_CAP_OFFSET ; +u16 lnk_stat, lnk_ctl; + +if (!cdns_pcie_link_up (pcie)) +return ; + +/* +* Set retrain bit if current speed is 2.5 GB/s, +* but the PCIe root port support is > 2.5 GB/s. +*/ + + lnk_cap_sls =cdns_pcie_readl (pcie, (CDNS_PCIE_RP_BASE + pcie_cap_off + +PCI_EXP_LNKCAP )); +if ((lnk_cap_sls &PCI_EXP_LNKCAP_SLS ) <=PCI_EXP_LNKCAP_SLS_2_5GB ) +return ; + + lnk_stat =cdns_pcie_rp_readw (pcie, pcie_cap_off +PCI_EXP_LNKSTA ); +if ((lnk_stat &PCI_EXP_LNKSTA_CLS ) ==PCI_EXP_LNKSTA_CLS_2_5GB ) { + lnk_ctl =cdns_pcie_rp_readw (pcie, + pcie_cap_off +PCI_EXP_LNKCTL ); + lnk_ctl |=PCI_EXP_LNKCTL_RL ; +cdns_pcie_rp_writew (pcie, pcie_cap_off +PCI_EXP_LNKCTL , + lnk_ctl); + +if (!cdns_pcie_link_up (pcie)) +return ; + } +}static int cdns_pcie_host_init_root_port (struct cdns_pcie_rc *rc) {
@@ -115,6 +145,7 @@ static int cdns_pcie_host_init_root_port(struct cdns_pcie_rc *rc)cdns_pcie_rp_writeb (pcie,PCI_CLASS_PROG ,0 );cdns_pcie_rp_writew (pcie,PCI_CLASS_DEVICE ,PCI_CLASS_BRIDGE_PCI ); +cdns_pcie_retrain (pcie);return 0 ; }
drivers/pci/controller/cadence/pcie-cadence.h +8 -1
@@ -119,7 +119,7 @@* Root Port Registers (PCI configuration space for the root port function) */ #define CDNS_PCIE_RP_BASE 0x00200000 - +#define CDNS_PCIE_RP_CAP_OFFSET 0xc0/* * Address Translation Registers
@@ -413,6 +413,13 @@ static inline void cdns_pcie_rp_writew(struct cdns_pcie *pcie,cdns_pcie_write_sz (addr,0x2 , value); } +static inline u16 cdns_pcie_rp_readw (struct cdns_pcie *pcie,u32 reg) +{ +void __iomem *addr = pcie->reg_base +CDNS_PCIE_RP_BASE + reg; + +return cdns_pcie_read_sz (addr,0x2 ); +} +/* Endpoint Function register access */ static inline void cdns_pcie_ep_fn_writeb (struct cdns_pcie *pcie,u8 fn,u32 reg,u8 value)
Signature · 1 line
2.15.0
Hi Nadeem,
Quoted 22 lines · Nadeem Athani
Cadence controller will not initiate autonomous speed change if strapped as Gen2. The Retrain Link bit is set as quirk to enable this speed change.
Signed-off-by Nadeem Athani <[email protected]>---
Changes in v3:
- To set retrain link bit,checking device capability & link status.
- 32bit read in place of 8bit.
- Minor correction in patch comment.
- Change in variable & macro name.
Changes in v2:
- 16bit read in place of 8bit.drivers/pci/controller/cadence/pcie-cadence-host.c | 31 ++++++++++++++++++++++ drivers/pci/controller/cadence/pcie-cadence.h | 9 ++++++- 2 files changed, 39 insertions(+), 1 deletion(-)drivers/pci/controller/cadence/pcie-cadence-host.c +0
-0@@ -77,6 +77,36 @@ static struct pci_ops cdns_pcie_host_ops = { .write = pci_generic_config_write,
drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = { · line 87
Quoted 10 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +8
-0}; +static void cdns_pcie_retrain (struct cdns_pcie *pcie) +{ +u32 lnk_cap_sls, pcie_cap_off =CDNS_PCIE_RP_CAP_OFFSET ; +u16 lnk_stat, lnk_ctl; + +if (!cdns_pcie_link_up (pcie)) +return ; +
Is there a IP version that can be used to check if that quirk is applicable?
Quoted 9 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +9
-0+/* +* Set retrain bit if current speed is 2.5 GB/s, +* but the PCIe root port support is > 2.5 GB/s. +*/ + + lnk_cap_sls =cdns_pcie_readl (pcie, (CDNS_PCIE_RP_BASE + pcie_cap_off + +PCI_EXP_LNKCAP )); +if ((lnk_cap_sls &PCI_EXP_LNKCAP_SLS ) <=PCI_EXP_LNKCAP_SLS_2_5GB ) +return ;
drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = { · line 106
Quoted 10 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +10
-0+ + lnk_stat =cdns_pcie_rp_readw (pcie, pcie_cap_off +PCI_EXP_LNKSTA ); +if ((lnk_stat &PCI_EXP_LNKSTA_CLS ) ==PCI_EXP_LNKSTA_CLS_2_5GB ) { + lnk_ctl =cdns_pcie_rp_readw (pcie, + pcie_cap_off +PCI_EXP_LNKCTL ); + lnk_ctl |=PCI_EXP_LNKCTL_RL ; +cdns_pcie_rp_writew (pcie, pcie_cap_off +PCI_EXP_LNKCTL , + lnk_ctl); + +if (!cdns_pcie_link_up (pcie))
Should this rather be a cdns_pcie_host_wait_for_link()?
Thanks
Kishon
Quoted 42 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +4
-0+return ; + } +}static int cdns_pcie_host_init_root_port (struct cdns_pcie_rc *rc) {@@ -115,6 +145,7 @@ static int cdns_pcie_host_init_root_port(struct cdns_pcie_rc *rc)cdns_pcie_rp_writeb (pcie,PCI_CLASS_PROG ,0 );cdns_pcie_rp_writew (pcie,PCI_CLASS_DEVICE ,PCI_CLASS_BRIDGE_PCI ); +cdns_pcie_retrain (pcie);return 0 ; }drivers/pci/controller/cadence/pcie-cadence.h +8
-1@@ -119,7 +119,7 @@* Root Port Registers (PCI configuration space for the root port function) */ #define CDNS_PCIE_RP_BASE 0x00200000 - +#define CDNS_PCIE_RP_CAP_OFFSET 0xc0/* * Address Translation Registers @@ -413,6 +413,13 @@ static inline void cdns_pcie_rp_writew(struct cdns_pcie *pcie,cdns_pcie_write_sz (addr,0x2 , value); } +static inline u16 cdns_pcie_rp_readw (struct cdns_pcie *pcie,u32 reg) +{ +void __iomem *addr = pcie->reg_base +CDNS_PCIE_RP_BASE + reg; + +return cdns_pcie_read_sz (addr,0x2 ); +} +/* Endpoint Function register access */ static inline void cdns_pcie_ep_fn_writeb (struct cdns_pcie *pcie,u8 fn,u32 reg,u8 value)
Hi Kishon,
Quoted 45 lines
-----Original Message-----
From: Kishon Vijay Abraham I <[email protected]>
Sent: Monday, October 19, 2020 10:59 AM
To: Athani Nadeem Ladkhan <[email protected]>; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]; Tom Joseph <[email protected]>
Cc: Swapnil Kashinath Jakhade <[email protected]>; Milind Parab <[email protected]>
Subject: Re: [PATCH v3] PCI: cadence: Retrain Link to work around Gen2 training defect.EXTERNAL MAIL
Hi Nadeem,
Quoted 2 lines · Nadeem Athani
Cadence controller will not initiate autonomous speed change if strapped as Gen2. The Retrain Link bit is set as quirk to enable this speed
change.
Quoted 11 lines
Signed-off-by Nadeem Athani <[email protected]>---
Changes in v3:
- To set retrain link bit,checking device capability & link status.
- 32bit read in place of 8bit.
- Minor correction in patch comment.
- Change in variable & macro name.
Changes in v2:
- 16bit read in place of 8bit.drivers/pci/controller/cadence/pcie-cadence-host.c | 31++++++++++++++++++++++
Quoted 12 lines
drivers/pci/controller/cadence/pcie-cadence.h | 9 ++++++- 2 files changed, 39 insertions(+), 1 deletion(-)drivers/pci/controller/cadence/pcie-cadence-host.c +0
-0@@ -77,6 +77,36 @@ static struct pci_ops cdns_pcie_host_ops = { .write = pci_generic_config_write, };
Quoted 9 lines
drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = { · line 87
Quoted 7 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +7
-0+static void cdns_pcie_retrain (struct cdns_pcie *pcie) { +u32 lnk_cap_sls, pcie_cap_off =CDNS_PCIE_RP_CAP_OFFSET ; +u16 lnk_stat, lnk_ctl; + +if (!cdns_pcie_link_up (pcie)) +return ; +Is there a IP version that can be used to check if that quirk is applicable?
There is no such provision.
Quoted 16 lines
drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = {
Quoted 6 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +6
-0+/* +* Set retrain bit if current speed is 2.5 GB/s, +* but the PCIe root port support is > 2.5 GB/s. +*/ + + lnk_cap_sls = cdns_pcie_readl(pcie, (CDNS_PCIE_RP_BASE +
pcie_cap_off+drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = { · line 94
Quoted 2 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +2
-0+ PCI_EXP_LNKCAP)); + if ((lnk_cap_sls & PCI_EXP_LNKCAP_SLS) <=
PCI_EXP_LNKCAP_SLS_2_5GB)drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = {
Quoted 3 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +3
-0+return ; + + lnk_stat = cdns_pcie_rp_readw(pcie, pcie_cap_off +
PCI_EXP_LNKSTA);drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = { · line 98
Quoted 1 line
drivers/pci/controller/cadence/pcie-cadence-host.c +1
-0+if ((lnk_stat &PCI_EXP_LNKSTA_CLS ) ==PCI_EXP_LNKSTA_CLS_2_5GB ){
Quoted 9 lines
drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = { · line 106
Quoted 7 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +7
-0+ lnk_ctl =cdns_pcie_rp_readw (pcie, + pcie_cap_off +PCI_EXP_LNKCTL ); + lnk_ctl |=PCI_EXP_LNKCTL_RL ; +cdns_pcie_rp_writew (pcie, pcie_cap_off +PCI_EXP_LNKCTL , + lnk_ctl); + +if (!cdns_pcie_link_up (pcie))Should this rather be a
cdns_pcie_host_wait_for_link()?
The use of this api cdns_pcie_link_up was mentioned in earlier reviews.
The mentioned api cdns_pcie_host_wait_for_link is a wrapper in which there are multiple checks. If insist, will replace with it.
Thanks,
Nadeem
Quoted 47 lines
Thanks
Kishondrivers/pci/controller/cadence/pcie-cadence-host.c static int cdns_pcie_host_init_root_port(struct
Quoted 6 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +3
-0+return ; + } +}static int cdns_pcie_host_init_root_port (struct cdns_pcie_rc *rc) {@@ -115,6 +145,7 @@ static int cdns_pcie_host_init_root_port(struct
cdns_pcie_rc*rc)drivers/pci/controller/cadence/pcie-cadence-host.c static int cdns_pcie_host_init_root_port(struct · line 146
Quoted 2 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +0
-0cdns_pcie_rp_writeb (pcie,PCI_CLASS_PROG ,0 ); cdns_pcie_rp_writew(pcie, PCI_CLASS_DEVICE,
PCI_CLASS_BRIDGE_PCI);drivers/pci/controller/cadence/pcie-cadence.h static inline void cdns_pcie_rp_writew(struct
Quoted 20 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +1
-0+cdns_pcie_retrain (pcie);return 0 ; }drivers/pci/controller/cadence/pcie-cadence.h +1
-1@@ -119,7 +119,7 @@* Root Port Registers (PCI configuration space for the root port function) */ #define CDNS_PCIE_RP_BASE 0x00200000 - +#define CDNS_PCIE_RP_CAP_OFFSET 0xc0/* * Address Translation Registers @@ -413,6 +413,13 @@ static inline void cdns_pcie_rp_writew(struct
cdns_pcie*pcie,Quoted 12 lines
drivers/pci/controller/cadence/pcie-cadence.h +6
-0cdns_pcie_write_sz (addr,0x2 , value); } +static inline u16 cdns_pcie_rp_readw (struct cdns_pcie *pcie,u32 reg) +{ +void __iomem *addr = pcie->reg_base +CDNS_PCIE_RP_BASE + reg; + +return cdns_pcie_read_sz (addr,0x2 ); } +/* Endpoint Function register access */ static inline void cdns_pcie_ep_fn_writeb (struct cdns_pcie *pcie,u8 fn,u32 reg,u8 value)
Hi Nadeem,
Quoted 56 lines · Athani Nadeem Ladkhan
Hi Kishon,
Quoted 45 lines
-----Original Message-----
From: Kishon Vijay Abraham I <[email protected]>
Sent: Monday, October 19, 2020 10:59 AM
To: Athani Nadeem Ladkhan <[email protected]>; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]; Tom Joseph <[email protected]>
Cc: Swapnil Kashinath Jakhade <[email protected]>; Milind Parab <[email protected]>
Subject: Re: [PATCH v3] PCI: cadence: Retrain Link to work around Gen2 training defect.EXTERNAL MAIL
Hi Nadeem,
Quoted 2 lines · Nadeem Athani
Cadence controller will not initiate autonomous speed change if strapped as Gen2. The Retrain Link bit is set as quirk to enable this speed
change.
Quoted 11 lines
Signed-off-by Nadeem Athani <[email protected]>---
Changes in v3:
- To set retrain link bit,checking device capability & link status.
- 32bit read in place of 8bit.
- Minor correction in patch comment.
- Change in variable & macro name.
Changes in v2:
- 16bit read in place of 8bit.drivers/pci/controller/cadence/pcie-cadence-host.c | 31++++++++++++++++++++++
Quoted 12 lines
drivers/pci/controller/cadence/pcie-cadence.h | 9 ++++++- 2 files changed, 39 insertions(+), 1 deletion(-)drivers/pci/controller/cadence/pcie-cadence-host.c +0
-0@@ -77,6 +77,36 @@ static struct pci_ops cdns_pcie_host_ops = { .write = pci_generic_config_write, };Quoted 9 lines
drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = { · line 87
Quoted 7 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +7
-0+static void cdns_pcie_retrain (struct cdns_pcie *pcie) { +u32 lnk_cap_sls, pcie_cap_off =CDNS_PCIE_RP_CAP_OFFSET ; +u16 lnk_stat, lnk_ctl; + +if (!cdns_pcie_link_up (pcie)) +return ; +Is there a IP version that can be used to check if that quirk is applicable?
Quoted 1 line
There is no such provision.
hmm okay. Can we add a DT property to indicate the quirk then since AFAIK this is not required in future revisions of IP.
Quoted 25 lines
Quoted 16 lines
drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = {
Quoted 6 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +6
-0+/* +* Set retrain bit if current speed is 2.5 GB/s, +* but the PCIe root port support is > 2.5 GB/s. +*/ + + lnk_cap_sls = cdns_pcie_readl(pcie, (CDNS_PCIE_RP_BASE +
pcie_cap_off+drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = { · line 94
Quoted 2 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +2
-0+ PCI_EXP_LNKCAP)); + if ((lnk_cap_sls & PCI_EXP_LNKCAP_SLS) <=
PCI_EXP_LNKCAP_SLS_2_5GB)drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = {
Quoted 3 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +3
-0+return ; + + lnk_stat = cdns_pcie_rp_readw(pcie, pcie_cap_off +
PCI_EXP_LNKSTA);drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = { · line 98
Quoted 1 line
drivers/pci/controller/cadence/pcie-cadence-host.c +1
-0+if ((lnk_stat &PCI_EXP_LNKSTA_CLS ) ==PCI_EXP_LNKSTA_CLS_2_5GB ){
Quoted 9 lines
drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = { · line 106
Quoted 7 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +7
-0+ lnk_ctl =cdns_pcie_rp_readw (pcie, + pcie_cap_off +PCI_EXP_LNKCTL ); + lnk_ctl |=PCI_EXP_LNKCTL_RL ; +cdns_pcie_rp_writew (pcie, pcie_cap_off +PCI_EXP_LNKCTL , + lnk_ctl); + +if (!cdns_pcie_link_up (pcie))Should this rather be a
cdns_pcie_host_wait_for_link()?
Quoted 3 lines
The use of this api
cdns_pcie_link_upwas mentioned in earlier reviews.
The mentioned apicdns_pcie_host_wait_for_linkis a wrapper in which there are multiple checks. If insist, will replace with it.
yeah, I think we should give some time for the link up to succeed after re-training.
Thanks
Kishon
Rob Herring
reviewerQuoted 61 lines · Kishon Vijay Abraham I
Hi Nadeem,
Quoted 57 lines · Athani Nadeem Ladkhan
Hi Kishon,
Quoted 45 lines
-----Original Message-----
From: Kishon Vijay Abraham I <[email protected]>
Sent: Monday, October 19, 2020 10:59 AM
To: Athani Nadeem Ladkhan <[email protected]>; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]; Tom Joseph <[email protected]>
Cc: Swapnil Kashinath Jakhade <[email protected]>; Milind Parab <[email protected]>
Subject: Re: [PATCH v3] PCI: cadence: Retrain Link to work around Gen2 training defect.EXTERNAL MAIL
Hi Nadeem,
Quoted 2 lines · Nadeem Athani
Cadence controller will not initiate autonomous speed change if strapped as Gen2. The Retrain Link bit is set as quirk to enable this speed
change.
Quoted 11 lines
Signed-off-by Nadeem Athani <[email protected]>---
Changes in v3:
- To set retrain link bit,checking device capability & link status.
- 32bit read in place of 8bit.
- Minor correction in patch comment.
- Change in variable & macro name.
Changes in v2:
- 16bit read in place of 8bit.drivers/pci/controller/cadence/pcie-cadence-host.c | 31++++++++++++++++++++++
Quoted 12 lines
drivers/pci/controller/cadence/pcie-cadence.h | 9 ++++++- 2 files changed, 39 insertions(+), 1 deletion(-)drivers/pci/controller/cadence/pcie-cadence-host.c +0
-0@@ -77,6 +77,36 @@ static struct pci_ops cdns_pcie_host_ops = { .write = pci_generic_config_write, };Quoted 9 lines
drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = { · line 87
Quoted 7 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +7
-0+static void cdns_pcie_retrain (struct cdns_pcie *pcie) { +u32 lnk_cap_sls, pcie_cap_off =CDNS_PCIE_RP_CAP_OFFSET ; +u16 lnk_stat, lnk_ctl; + +if (!cdns_pcie_link_up (pcie)) +return ; +Is there a IP version that can be used to check if that quirk is applicable?
There is no such provision.
Cadence just gives out unversioned IP? There may not be s/w readable version, but there's still a version. Look at DWC.
Quoted 2 lines
hmm okay. Can we add a DT property to indicate the quirk then since AFAIK this is not required in future revisions of IP.
No, add a driver quirk flag, but set flag that based on compatible strings.
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
drivers/pci/controller/cadence/pcie-cadence-host.c static struct pci_ops cdns_pcie_host_ops = { · line 90
Quoted 3 lines
drivers/pci/controller/cadence/pcie-cadence-host.c +3
-0+/* +* Set retrain bit if current speed is 2.5 GB/s, +* but the PCIe root port support is > 2.5 GB/s.
Though wouldn't setting the retrain bit be harmless even if not needed?
Rob
Hi Tom, Nadeem,
Quoted 22 lines · Rob Herring
Quoted 21 lines · Kishon Vijay Abraham I
Hi Nadeem,
Quoted 17 lines · Athani Nadeem Ladkhan
Hi Kishon,
Quoted 15 lines
-----Original Message-----
From: Kishon Vijay Abraham I <[email protected]>
Sent: Monday, October 19, 2020 10:59 AM
To: Athani Nadeem Ladkhan <[email protected]>; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]; Tom Joseph <[email protected]>
Cc: Swapnil Kashinath Jakhade <[email protected]>; Milind Parab <[email protected]>
Subject: Re: [PATCH v3] PCI: cadence: Retrain Link to work around Gen2 training defect.EXTERNAL MAIL
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Hi Nadeem,
Quoted 2 lines · Nadeem Athani
Cadence controller will not initiate autonomous speed change if strapped as Gen2. The Retrain Link bit is set as quirk to enable this speed
change.
Quoted 2 lines
Signed-off-by Nadeem Athani <[email protected]>
Do you have a follow-up patch fixing the review comments?
Thanks
Kishon
Hi Kishon,
Quoted 44 lines
-----Original Message-----
From: Kishon Vijay Abraham I <[email protected]>
Sent: Thursday, November 26, 2020 7:28 PM
To: Rob Herring <[email protected]>
Cc: Athani Nadeem Ladkhan <[email protected]>; [email protected]; [email protected]; linux- [email protected]; [email protected]; Tom Joseph <[email protected]>; Swapnil Kashinath Jakhade <[email protected]>; Milind Parab <[email protected]>
Subject: Re: [PATCH v3] PCI: cadence: Retrain Link to work around Gen2 training defect.EXTERNAL MAIL
Hi Tom, Nadeem,
Quoted 1 line · Rob Herring
On Fri, Oct 23, 2020 at 1:57 AM Kishon Vijay Abraham I <[email protected]>
Quoted 24 lines · wrote:
Quoted 24 lines
Hi Nadeem,
Quoted 20 lines · Athani Nadeem Ladkhan
Hi Kishon,
Quoted 18 lines
-----Original Message-----
From: Kishon Vijay Abraham I <[email protected]>
Sent: Monday, October 19, 2020 10:59 AM
To: Athani Nadeem Ladkhan <[email protected]>; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]; Tom Joseph <[email protected]>
Cc: Swapnil Kashinath Jakhade <[email protected]>; Milind Parab <[email protected]>
Subject: Re: [PATCH v3] PCI: cadence: Retrain Link to work around Gen2 training defect.EXTERNAL MAIL
Hi Nadeem,
On 30/09/20 11:51 pm, Nadeem Athani wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Cadence controller will not initiate autonomous speed change if strapped as Gen2. The Retrain Link bit is set as quirk to enable this speed
change.
Quoted 2 lines
Signed-off-by Nadeem Athani <[email protected]>Do you have a follow-up patch fixing the review comments?
We planned to fix this in coming 3 weeks.
Quoted 3 lines
Thanks
Kishon