Skip to contentSkip to conversation

arch/Config.in.s390x: drop redundant depends on BR2_s390x

PATCH New Thomas Petazzoni 2 participants 2 messages Sep 30, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/Config.in.s390x: drop redundant depends on BR2_s390x

The whole arch/Config.in.s390x file is only included by arch/Config.in if BR2_s390x=y, so having "depends on" conditions on each options of the choice doesn't make much sense.

---
 arch/Config.in.s390x | 3 ---
 1 file changed, 3 deletions(-)
arch/Config.in.s390x +0 -3
index 1d3079c942..fa893608a5 100644
@@ -6,15 +6,12 @@ choice
 
 config BR2_s390x_z13
 	bool "z13"
-	depends on BR2_s390x
 
 config BR2_s390x_z14
 	bool "z14"
-	depends on BR2_s390x
 
 config BR2_s390x_z15
 	bool "z15"
-	depends on BR2_s390x
 
 endchoice
 
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 arch/Config.in.s390x: drop redundant depends on BR2_s390x

Thomas, All,

On 2020-09-30 21:29 +0200, Thomas Petazzoni spake thusly:

Quoted 3 lines

The whole arch/Config.in.s390x file is only included by arch/Config.in if BR2_s390x=y, so having "depends on" conditions on each options of the choice doesn't make much sense.

I removed it from the choice itself, but forgot to remove it from the individual entries in the choice. Sigh... Thanks for fixing it.

Quoted 1 line

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 31 lines
---
 arch/Config.in.s390x | 3 ---
 1 file changed, 3 deletions(-)
arch/Config.in.s390x +0 -3
index 1d3079c942..fa893608a5 100644
@@ -6,15 +6,12 @@ choice
 
 config BR2_s390x_z13
 	bool "z13"
-	depends on BR2_s390x
 
 config BR2_s390x_z14
 	bool "z14"
-	depends on BR2_s390x
 
 config BR2_s390x_z15
 	bool "z15"
-	depends on BR2_s390x
 
 endchoice
 
Signature · 6 lines
2.26.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'