Skip to contentSkip to conversation

ethdev: use rte_pktmbuf_free_bulk()

PATCH Applied Stephen Hemminger 4 participants 4 messages Sep 30, 2020 – Oct 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ethdev: use rte_pktmbuf_free_bulk()

The mbuf library now has routine to free multiple buffers. Loop is no longer needed.

---
 lib/librte_ethdev/rte_ethdev.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
lib/librte_ethdev/rte_ethdev.c +2 -8
index dfe5c1b488a0..307fbeb3a798 100644
@@ -2179,10 +2179,7 @@ void
 rte_eth_tx_buffer_drop_callback(struct rte_mbuf **pkts, uint16_t unsent,
 		void *userdata __rte_unused)
 {
-	unsigned i;
-
-	for (i = 0; i < unsent; i++)
-		rte_pktmbuf_free(pkts[i]);
+	rte_pktmbuf_free_bulk(pkts, unsent);
 }
 
 void
@@ -2190,11 +2187,8 @@ rte_eth_tx_buffer_count_callback(struct rte_mbuf **pkts, uint16_t unsent,
 		void *userdata)
 {
 	uint64_t *count = userdata;
-	unsigned i;
-
-	for (i = 0; i < unsent; i++)
-		rte_pktmbuf_free(pkts[i]);
 
+	rte_pktmbuf_free_bulk(pkts, unsent);
 	*count += unsent;
 }
 
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#3 lore raw
In reply to Stephen Hemminger
Quoted 44 lines

From: dev [mailto:[email protected]] On Behalf Of Stephen Hemminger
Sent: Wednesday, September 30, 2020 11:27 PM

The mbuf library now has routine to free multiple buffers. Loop is no longer needed.

---
 lib/librte_ethdev/rte_ethdev.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
lib/librte_ethdev/rte_ethdev.c +1 -4
index dfe5c1b488a0..307fbeb3a798 100644
@@ -2179,10 +2179,7 @@ void
 rte_eth_tx_buffer_drop_callback(struct rte_mbuf **pkts, uint16_t
 unsent,
 		void *userdata __rte_unused)
 {
-	unsigned i;
-
-	for (i = 0; i < unsent; i++)
-		rte_pktmbuf_free(pkts[i]);
+	rte_pktmbuf_free_bulk(pkts, unsent);
 }
 

void

lib/librte_ethdev/rte_ethdev.c +1 -5
@@ -2190,11 +2187,8 @@ rte_eth_tx_buffer_count_callback(struct rte_mbuf
 **pkts, uint16_t unsent,
 		void *userdata)
 {
 	uint64_t *count = userdata;
-	unsigned i;
-
-	for (i = 0; i < unsent; i++)
-		rte_pktmbuf_free(pkts[i]);
 
+	rte_pktmbuf_free_bulk(pkts, unsent);
 	*count += unsent;
 }
 
--
Quoted 2 lines

2.27.0