Skip to contentSkip to conversation

package/bison: disable libtextstyle

PATCH New Baruch Siach 3 participants 4 messages Sep 27, 2020 – Oct 3, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/bison: disable libtextstyle

Recent bison versions added support for fancy error output using gettext provided libtextstyle. The Buildroot gettext version does not provided all needed features. However host-bison might detect host installed libtextstyle at configure time, but fail at run time because of missing symbols in Buildroot provided libtextstyle.

We don't really need fancy output of host packages, so just disable libtextstyle support.

Fixes (libpcap):
http://autobuild.buildroot.net/results/058e8ec90da3c06e31b31eb94541331cced44db3/
http://autobuild.buildroot.net/results/d99dda99722c53730b5964bd4ff1e1281c4ad759/
http://autobuild.buildroot.net/results/056fd1246554fe7def416429620175e86530c0a7/

---
Hi Xogium,

Can you verify that this indeed fixes libpcap configure on your builder?

Thanks,
baruch

---
 package/bison/bison.mk | 1 +
 1 file changed, 1 insertion(+)
package/bison/bison.mk +1 -0
index 45364e3cd5e6..70111a8d6297 100644
@@ -13,5 +13,6 @@ BISON_LICENSE_FILES = COPYING
 BISON_MAKE = $(MAKE1)
 HOST_BISON_DEPENDENCIES = host-m4
 HOST_BISON_CONF_OPTS = --enable-relocatable
+HOST_BISON_CONF_ENV = ac_cv_libtextstyle=no
 
 $(eval $(host-autotools-package))
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/bison: disable libtextstyle

Hi Buildroot list,

Quoted 2 lines · Baruch Siach

Recent bison versions added support for fancy error output using gettext provided libtextstyle. The Buildroot gettext version does not provided

Typo: s/provided/provide/

Quoted 7 lines

all needed features. However host-bison might detect host installed libtextstyle at configure time, but fail at run time because of missing symbols in Buildroot provided libtextstyle.

We don't really need fancy output of host packages, so just disable libtextstyle support.

Quoted 7 lines

Fixes (libpcap):
http://autobuild.buildroot.net/results/058e8ec90da3c06e31b31eb94541331cced44db3/
http://autobuild.buildroot.net/results/d99dda99722c53730b5964bd4ff1e1281c4ad759/
http://autobuild.buildroot.net/results/056fd1246554fe7def416429620175e86530c0a7/

I'm adding Tested-by on behalf of Xogium, because he is not subscribed to the list. Xogium verified that this patch fixes libpcap configure step on his builder.

baruch

Quoted 22 lines

---
Hi Xogium,

Can you verify that this indeed fixes libpcap configure on your builder?

Thanks,
baruch

---
 package/bison/bison.mk | 1 +
 1 file changed, 1 insertion(+)
package/bison/bison.mk +1 -0
index 45364e3cd5e6..70111a8d6297 100644
@@ -13,5 +13,6 @@ BISON_LICENSE_FILES = COPYING
 BISON_MAKE = $(MAKE1)
 HOST_BISON_DEPENDENCIES = host-m4
 HOST_BISON_CONF_OPTS = --enable-relocatable
+HOST_BISON_CONF_ENV = ac_cv_libtextstyle=no
 
 $(eval $(host-autotools-package))
Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 package/bison: disable libtextstyle

In reply to Baruch Siach
Quoted 14 lines · On Sun, 27 Sep 2020 08:08:29 +0300 Baruch Siach <[email protected]> wrote:

Recent bison versions added support for fancy error output using gettext provided libtextstyle. The Buildroot gettext version does not provided all needed features. However host-bison might detect host installed libtextstyle at configure time, but fail at run time because of missing symbols in Buildroot provided libtextstyle.

We don't really need fancy output of host packages, so just disable libtextstyle support.

Fixes (libpcap):
http://autobuild.buildroot.net/results/058e8ec90da3c06e31b31eb94541331cced44db3/
http://autobuild.buildroot.net/results/d99dda99722c53730b5964bd4ff1e1281c4ad759/
http://autobuild.buildroot.net/results/056fd1246554fe7def416429620175e86530c0a7/

Quoted 4 lines

---
Hi Xogium,

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/bison: disable libtextstyle

In reply to Baruch Siach
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Recent bison versions added support for fancy error output using gettext provided libtextstyle. The Buildroot gettext version does not provided all needed features. However host-bison might detect host installed libtextstyle at configure time, but fail at run time because of missing symbols in Buildroot provided libtextstyle.

We don't really need fancy output of host packages, so just disable libtextstyle support.

Quoted 7 lines

Fixes (libpcap):
http://autobuild.buildroot.net/results/058e8ec90da3c06e31b31eb94541331cced44db3/
http://autobuild.buildroot.net/results/d99dda99722c53730b5964bd4ff1e1281c4ad759/
http://autobuild.buildroot.net/results/056fd1246554fe7def416429620175e86530c0a7/

Committed to 2020.02.x, 2020.05.x and 2020.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard