phy: add support for stingray PAXB PHY controller
PATCH v3 1/1 phy: add support for stingray PAXB PHY controller
From: Srinath Mannam <[email protected]>
Add support for stingray PAXB PHY controller driver. This driver supports maximum 8 PAXB phys using pipemux data.
---
Changes from v2:
-Address review comments from Stefan Roese,
Rearrange the include files.
Remove dm/device.h as its included part of dm.h.
Changes from v1:
-Address review comments from Stefan Roese,
Use GENMASK() instead of hard code value.
Remove unwanted struct declaration.
Get pr_err() into single line.
drivers/phy/Kconfig | 7 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-bcm-sr-pcie.c | 177 ++++++++++++++++++++++++++++++++++ 3 files changed, 185 insertions(+) create mode 100644 drivers/phy/phy-bcm-sr-pcie.c
drivers/phy/Kconfig +7 -0
@@ -84,6 +84,13 @@ config BCM6368_USBH_PHY help Support for the Broadcom MIPS BCM6368 USBH PHY. +config BCM_SR_PCIE_PHY + bool "Broadcom Stingray PCIe PHY driver" + depends on PHY + help + Enable this to support the Broadcom Stingray PCIe PHY + If unsure, say N. + config PHY_DA8XX_USB tristate "TI DA8xx USB PHY Driver" depends on PHY && ARCH_DAVINCI
drivers/phy/Makefile +1 -0
@@ -9,6 +9,7 @@ obj-$(CONFIG_BCM6318_USBH_PHY) += bcm6318-usbh-phy.o obj-$(CONFIG_BCM6348_USBH_PHY) += bcm6348-usbh-phy.o obj-$(CONFIG_BCM6358_USBH_PHY) += bcm6358-usbh-phy.o obj-$(CONFIG_BCM6368_USBH_PHY) += bcm6368-usbh-phy.o +obj-$(CONFIG_BCM_SR_PCIE_PHY) += phy-bcm-sr-pcie.o obj-$(CONFIG_PHY_SANDBOX) += sandbox-phy.o obj-$(CONFIG_$(SPL_)PIPE3_PHY) += ti-pipe3-phy.o obj-$(CONFIG_AM654_PHY) += phy-ti-am654.o
drivers/phy/phy-bcm-sr-pcie.c new file +177 -0
177 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH v3 1/1 phy: add support for stingray PAXB PHY controller
Quoted 20 lines · Rayagonda Kokatanur
From: Srinath Mannam <[email protected]>
Add support for stingray PAXB PHY controller driver. This driver supports maximum 8 PAXB phys using pipemux data.
Signed-off-by Srinath Mannam <[email protected]>Signed-off-by Rayagonda Kokatanur <[email protected]>Reviewed-by Stefan Roese <[email protected]>---
Changes from v2:
-Address review comments from Stefan Roese,
Rearrange the include files.
Removedm/device.has its included part ofdm.h.Changes from v1:
-Address review comments from Stefan Roese,
UseGENMASK()instead of hard code value.
Remove unwanted struct declaration.
Getpr_err()into single line.
Quoted 3 lines
drivers/phy/Kconfig | 7 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-bcm-sr-pcie.c | 177 ++++++++++++++++++++++++++++++++++
The patch itself is fine but I think shows another problem. Can you please add a patch that lists something relevant in the top-level MAINTAINERS file and list this and all of the other drivers, etc, that wouldn't just be listed in the board MAINATINERS file? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200409/5e1ed4d0/attachment.sig>
PATCH v3 1/1 phy: add support for stingray PAXB PHY controller
Quoted 23 lines · Tom Rini
Quoted 20 lines · Rayagonda Kokatanur
From: Srinath Mannam <[email protected]>
Add support for stingray PAXB PHY controller driver. This driver supports maximum 8 PAXB phys using pipemux data.
Signed-off-by Srinath Mannam <[email protected]>Signed-off-by Rayagonda Kokatanur <[email protected]>Reviewed-by Stefan Roese <[email protected]>---
Changes from v2:
-Address review comments from Stefan Roese,
Rearrange the include files.
Removedm/device.has its included part ofdm.h.Changes from v1:
-Address review comments from Stefan Roese,
UseGENMASK()instead of hard code value.
Remove unwanted struct declaration.
Getpr_err()into single line.
Quoted 8 lines
Quoted 3 lines
drivers/phy/Kconfig | 7 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-bcm-sr-pcie.c | 177 ++++++++++++++++++++++++++++++++++The patch itself is fine but I think shows another problem. Can you please add a patch that lists something relevant in the top-level
MAINTAINERSfile and list this and all of the other drivers, etc, that wouldn't just be listed in the board MAINATINERS file? Thanks!
I will be mainitainer going ahead.
I have a plan to update top level MAINTAINER file once I push platform files. Hope this is fine.
Quoted 3 lines
--
Tom
PATCH v3 1/1 phy: add support for stingray PAXB PHY controller
Hi Tom,
Quoted 25 lines · Rayagonda Kokatanur
Quoted 23 lines · Tom Rini
Quoted 20 lines · Rayagonda Kokatanur
From: Srinath Mannam <[email protected]>
Add support for stingray PAXB PHY controller driver. This driver supports maximum 8 PAXB phys using pipemux data.
Signed-off-by Srinath Mannam <[email protected]>Signed-off-by Rayagonda Kokatanur <[email protected]>Reviewed-by Stefan Roese <[email protected]>---
Changes from v2:
-Address review comments from Stefan Roese,
Rearrange the include files.
Removedm/device.has its included part ofdm.h.Changes from v1:
-Address review comments from Stefan Roese,
UseGENMASK()instead of hard code value.
Remove unwanted struct declaration.
Getpr_err()into single line.
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines
drivers/phy/Kconfig | 7 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-bcm-sr-pcie.c | 177 ++++++++++++++++++++++++++++++++++The patch itself is fine but I think shows another problem. Can you please add a patch that lists something relevant in the top-level
MAINTAINERSfile and list this and all of the other drivers, etc, that wouldn't just be listed in the board MAINATINERS file? Thanks!
I have a plan to update the top level MAINTAINER file with all new driver and board files in a separate patch.
Hope this is fine, please let me know.
Thanks,
Rayagonda
Quoted 8 lines
I will be mainitainer going ahead.
I have a plan to update top level MAINTAINER file once I push platform files. Hope this is fine.Quoted 3 lines
--
Tom
PATCH v3 1/1 phy: add support for stingray PAXB PHY controller
Quoted 34 lines · Rayagonda Kokatanur
Hi Tom,
Quoted 29 lines · Rayagonda Kokatanur
Quoted 27 lines · Tom Rini
Quoted 23 lines · Rayagonda Kokatanur
From: Srinath Mannam <[email protected]>
Add support for stingray PAXB PHY controller driver. This driver supports maximum 8 PAXB phys using pipemux data.
Signed-off-by Srinath Mannam <[email protected]>Signed-off-by Rayagonda Kokatanur <[email protected]>Reviewed-by Stefan Roese <[email protected]>---
Changes from v2:
-Address review comments from Stefan Roese,
Rearrange the include files.
Removedm/device.has its included part ofdm.h.Changes from v1:
-Address review comments from Stefan Roese,
UseGENMASK()instead of hard code value.
Remove unwanted struct declaration.
Getpr_err()into single line.drivers/phy/Kconfig | 7 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-bcm-sr-pcie.c | 177 ++++++++++++++++++++++++++++++++++
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
The patch itself is fine but I think shows another problem. Can you please add a patch that lists something relevant in the top-level
MAINTAINERSfile and list this and all of the other drivers, etc, that wouldn't just be listed in the board MAINATINERS file? Thanks!I have a plan to update the top level MAINTAINER file with all new driver and board files in a separate patch.
Hope this is fine, please let me know.
OK, thanks. I'll be picking up more patches again soon for -next.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200626/2698bb91/attachment.sig>
PATCH v3 1/1 phy: add support for stingray PAXB PHY controller
Hi Tom,
Quoted 41 lines · Tom Rini
Quoted 39 lines · Rayagonda Kokatanur
Hi Tom,
Quoted 33 lines · Rayagonda Kokatanur
Quoted 31 lines · Tom Rini
Quoted 20 lines · Rayagonda Kokatanur
From: Srinath Mannam <[email protected]>
Add support for stingray PAXB PHY controller driver. This driver supports maximum 8 PAXB phys using pipemux data.
Signed-off-by Srinath Mannam <[email protected]>Signed-off-by Rayagonda Kokatanur <[email protected]>Reviewed-by Stefan Roese <[email protected]>---
Changes from v2:
-Address review comments from Stefan Roese,
Rearrange the include files.
Removedm/device.has its included part ofdm.h.Changes from v1:
-Address review comments from Stefan Roese,
UseGENMASK()instead of hard code value.
Remove unwanted struct declaration.
Getpr_err()into single line.Quoted 3 lines
drivers/phy/Kconfig | 7 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-bcm-sr-pcie.c | 177 ++++++++++++++++++++++++++++++++++The patch itself is fine but I think shows another problem. Can you please add a patch that lists something relevant in the top-level
MAINTAINERSfile and list this and all of the other drivers, etc, that wouldn't just be listed in the board MAINATINERS file? Thanks!
Quoted 5 lines
Quoted 3 lines
I have a plan to update the top level MAINTAINER file with all new driver and board files in a separate patch.
Hope this is fine, please let me know.OK, thanks. I'll be picking up more patches again soon for -next.
Could you please pick this patch.
If any further review comments, please let me know.
Best regards,
Rayagonda
Quoted 3 lines
--
Tom
PATCH v3 1/1 phy: add support for stingray PAXB PHY controller
In reply to Rayagonda KokatanurQuoted 8 lines · Rayagonda Kokatanur
From: Srinath Mannam <[email protected]>
Add support for stingray PAXB PHY controller driver. This driver supports maximum 8 PAXB phys using pipemux data.
Signed-off-by Srinath Mannam <[email protected]>Signed-off-by Rayagonda Kokatanur <[email protected]>Reviewed-by Stefan Roese <[email protected]>
Applied to u-boot/next, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201001/79b97f69/attachment.sig>