Skip to contentSkip to conversation

x86: Make Hyper-V tests x86_64 only

PATCH In review Sean Christopherson 2 participants 3 messages Sep 29, 2020 – Oct 1, 2020 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: Make Hyper-V tests x86_64 only

Skip the Hyper-V tests on i386, they explicitly run with kvm64 and crash immediately when run in i386, i.e. waste 90 seconds waiting for the timeout to fire.

---
 x86/unittests.cfg | 3 +++
 1 file changed, 3 insertions(+)
x86/unittests.cfg +3 -0
index 3a79151..0651778 100644
@@ -314,18 +314,21 @@ arch = x86_64
 file = hyperv_synic.flat
 smp = 2
 extra_params = -cpu kvm64,hv_vpindex,hv_synic -device hyperv-testdev
+arch = x86_64
 groups = hyperv
 
 [hyperv_connections]
 file = hyperv_connections.flat
 smp = 2
 extra_params = -cpu kvm64,hv_vpindex,hv_synic -device hyperv-testdev
+arch = x86_64
 groups = hyperv
 
 [hyperv_stimer]
 file = hyperv_stimer.flat
 smp = 2
 extra_params = -cpu kvm64,hv_vpindex,hv_time,hv_synic,hv_stimer -device hyperv-testdev
+arch = x86_64
 groups = hyperv
 
 [hyperv_clock]
Signature · 1 line
2.28.0
#1 lore raw
Quoted 23 lines · Sean Christopherson

Skip the Hyper-V tests on i386, they explicitly run with kvm64 and crash immediately when run in i386, i.e. waste 90 seconds waiting for the timeout to fire.

---
 x86/unittests.cfg | 3 +++
 1 file changed, 3 insertions(+)
x86/unittests.cfg +1 -0
index 3a79151..0651778 100644
@@ -314,18 +314,21 @@ arch = x86_64
 file = hyperv_synic.flat
 smp = 2
 extra_params = -cpu kvm64,hv_vpindex,hv_synic -device hyperv-testdev
+arch = x86_64
 groups = hyperv
 
 [hyperv_connections]
 file = hyperv_connections.flat
 smp = 2

x86/unittests.cfg arch = x86_64 · line 332

Quoted 10 lines
x86/unittests.cfg +2 -0
 extra_params = -cpu kvm64,hv_vpindex,hv_synic -device hyperv-testdev
+arch = x86_64
 groups = hyperv
 
 [hyperv_stimer]
 file = hyperv_stimer.flat
 smp = 2
 extra_params = -cpu kvm64,hv_vpindex,hv_time,hv_synic,hv_stimer -device hyperv-testdev
+arch = x86_64
 groups = hyperv

Looks reasonable, but for some funny reason, this test seems to work on Travis in the 32-bit builds:

https://travis-ci.com/github/huth/kvm-unit-tests/jobs/392615222#L699

Any idea why it is still working there?

Thomas

#2 lore raw
Quoted 38 lines · Thomas Huth
Quoted 23 lines · Sean Christopherson

Skip the Hyper-V tests on i386, they explicitly run with kvm64 and crash immediately when run in i386, i.e. waste 90 seconds waiting for the timeout to fire.

---
 x86/unittests.cfg | 3 +++
 1 file changed, 3 insertions(+)
x86/unittests.cfg +1 -0
index 3a79151..0651778 100644
@@ -314,18 +314,21 @@ arch = x86_64
 file = hyperv_synic.flat
 smp = 2
 extra_params = -cpu kvm64,hv_vpindex,hv_synic -device hyperv-testdev
+arch = x86_64
 groups = hyperv
 
 [hyperv_connections]
 file = hyperv_connections.flat
 smp = 2

x86/unittests.cfg arch = x86_64 · line 332

Quoted 10 lines
x86/unittests.cfg +2 -0
 extra_params = -cpu kvm64,hv_vpindex,hv_synic -device hyperv-testdev
+arch = x86_64
 groups = hyperv
 
 [hyperv_stimer]
 file = hyperv_stimer.flat
 smp = 2
 extra_params = -cpu kvm64,hv_vpindex,hv_time,hv_synic,hv_stimer -device hyperv-testdev
+arch = x86_64
 groups = hyperv

Looks reasonable, but for some funny reason, this test seems to work on Travis in the 32-bit builds:

Quoted 3 lines

https://travis-ci.com/github/huth/kvm-unit-tests/jobs/392615222#L699

Any idea why it is still working there?

Hmm, looks like these crash on my end for 64-bit as well, so maybe they are 32-bit compatible and it's my setup that's busted.