Skip to contentSkip to conversation

coreutils: improve coreutils-ptest RDEPENDS

PATCH In review Ross Burton 4 participants 7 messages Oct 1, 2020 – Oct 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 coreutils: improve coreutils-ptest RDEPENDS

Add perl-modules to the RDEPENDS to avoid having to list all perl modules that are required, as this package isn't going to be installed outside of testing builds.

Remove libmodule-build-perl from RDEPENDS, it appears that this isn't needed anymore. With and without this package the test results on my image are the same: 619 tests, 462 pass, 154 skip, 3 fail. This *drastically* reduces the build impact of enabling ptest as packagegroup-core-build-essential (thus target gcc) is in the dependency chain.

---
 meta/recipes-core/coreutils/coreutils_8.32.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/coreutils/coreutils_8.32.bb +1 -1
index f8ae3fd94c..9d1eceef54 100644
@@ -158,7 +158,7 @@ BBCLASSEXTEND = "native nativesdk"
 
 inherit ptest
 
-RDEPENDS_${PN}-ptest += "bash findutils gawk liberror-perl libmodule-build-perl make perl perl-module-file-stat python3-core sed shadow"
+RDEPENDS_${PN}-ptest += "bash findutils gawk liberror-perl make perl perl-modules python3-core sed shadow"
 
 # -dev automatic dependencies fails as we don't want libmodule-build-perl-dev, its too heavy
 # may need tweaking if DEPENDS changes
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/2 parted: improve ptest

Add a RRECOMMENDS on kernel-module-scsi-debug as this module is needed for many of the tests.

Create the udev mount blacklist directory before writing into it, as it doesn't always exist.

Delete any existing log files before calling make, as otherwise the tests cannot be repeated.

---
 meta/recipes-extended/parted/files/run-ptest | 2 ++
 meta/recipes-extended/parted/parted_3.3.bb   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
meta/recipes-extended/parted/files/run-ptest +2 -0
index f39c478ce6..374f1bfbc9 100644
@@ -1,5 +1,7 @@
 #!/bin/sh
 
+mkdir -p /etc/udev/mount.blacklist.d
 echo /dev/sda1 >> /etc/udev/mount.blacklist.d/parted-tmp
+rm -f *.log
 make -C tests test-suite.log
 rm /etc/udev/mount.blacklist.d/parted-tmp
meta/recipes-extended/parted/parted_3.3.bb +1 -1
index aa4d8042cf..a1fd3ef07b 100644
@@ -46,7 +46,7 @@ do_install_ptest() {
 }
 
 RDEPENDS_${PN}-ptest = "bash coreutils perl util-linux-losetup python3 make gawk e2fsprogs-mke2fs"
-
+RRECOMMENDS_${PN}-ptest = "kernel-module-scsi-debug"
 RDEPENDS_${PN}-ptest_append_libc-glibc = "\
         glibc-utils \
         locale-base-en-us \
Signature · 1 line
2.25.1
#2 lore raw
In reply to Ross Burton
Quoted 5 lines · Ross Burton

Add perl-modules to the RDEPENDS to avoid having to list all perl modules that are required, as this package isn't going to be installed
outside of testing builds.

Quoted 7 lines

Remove libmodule-build-perl from RDEPENDS, it appears that this isn't needed anymore. With and without this package the test results on my image are the same: 619 tests, 462 pass, 154 skip, 3 fail. This *drastically* reduces the build impact of enabling ptest as packagegroup-core-build-essential (thus target gcc) is in the dependency
chain.

When you tested that, did you actually test an image just with the coreutils ptest installed? That was how we exposed this originally and without it, the test results werent' consistent.

Cheers,

Richard

#3 lore raw
Quoted 3 lines · Richard Purdie

When you tested that, did you actually test an image just with the coreutils ptest installed? That was how we exposed this originally and without it, the test results werent' consistent.

Yes, core-image-base with coreutils-ptest installed. I can try again with core-image-minimal if you have concerns?

Ross

#4 lore raw
Quoted 9 lines · Ross Burton
Quoted 4 lines · Richard Purdie

When you tested that, did you actually test an image just with the coreutils ptest installed? That was how we exposed this originally and
without it, the test results werent' consistent.

Yes, core-image-base with coreutils-ptest installed. I can try again with core-image-minimal if you have concerns?

I think -base should be ok. I know I had to brute force this with testing a while back, I think I did use minimal for that but base should be ok.

Cheers,

Richard

#5 lore raw
In reply to Ross Burton

Suitable for dunfell? (again adapted for 8.31)

Steve

Quoted 36 lines · Ross Burton

Add perl-modules to the RDEPENDS to avoid having to list all perl modules that are required, as this package isn't going to be installed outside of testing builds.

Remove libmodule-build-perl from RDEPENDS, it appears that this isn't needed anymore. With and without this package the test results on my image are the same: 619 tests, 462 pass, 154 skip, 3 fail. This *drastically* reduces the build impact of enabling ptest as packagegroup-core-build-essential (thus target gcc) is in the dependency chain.

---
 meta/recipes-core/coreutils/coreutils_8.32.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/coreutils/coreutils_8.32.bb +1 -2
index f8ae3fd94c..9d1eceef54 100644
@@ -158,7 +158,7 @@ BBCLASSEXTEND = "native nativesdk"
 
 inherit ptest
 
-RDEPENDS_${PN}-ptest += "bash findutils gawk liberror-perl libmodule-build-perl make perl perl-module-file-stat python3-core sed shadow"
+RDEPENDS_${PN}-ptest += "bash findutils gawk liberror-perl make perl perl-modules python3-core sed shadow"
 
 # -dev automatic dependencies fails as we don't want libmodule-build-perl-dev, its too heavy
 # may need tweaking if DEPENDS changes
--

2.25.1

#6 lore raw
In reply to Ross Burton
Quoted 10 lines · Ross Burton

Add perl-modules to the RDEPENDS to avoid having to list all perl modules that are required, as this package isn't going to be installed outside of testing builds.

Remove libmodule-build-perl from RDEPENDS, it appears that this isn't needed anymore. With and without this package the test results on my image are the same: 619 tests, 462 pass, 154 skip, 3 fail. This *drastically* reduces the build impact of enabling ptest as packagegroup-core-build-essential (thus target gcc) is in the dependency chain.

what changed that helped in removing this dependency

does this mean we dont need [1] now

[1] https://git.openembedded.org/openembedded-core/commit/?id=5463971d45b21512210cf20f3902baf95eacd4c6

Quoted 24 lines
---
  meta/recipes-core/coreutils/coreutils_8.32.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/coreutils/coreutils_8.32.bb +1 -1
index f8ae3fd94c..9d1eceef54 100644
@@ -158,7 +158,7 @@ BBCLASSEXTEND = "native nativesdk"
 
  inherit ptest
 
-RDEPENDS_${PN}-ptest += "bash findutils gawk liberror-perl libmodule-build-perl make perl perl-module-file-stat python3-core sed shadow"
+RDEPENDS_${PN}-ptest += "bash findutils gawk liberror-perl make perl perl-modules python3-core sed shadow"
 
  # -dev automatic dependencies fails as we don't want libmodule-build-perl-dev, its too heavy
  # may need tweaking if DEPENDS changes