Skip to contentSkip to conversation

dmaengine: fsl: remove bad channel update

PATCH Applied Vinod Koul 2 participants 3 messages Oct 1, 2020 – Oct 6, 2020 dmaengine

lore
Share & tools
lore

Vinod Koul

author maintainer
#0 lore raw

PATCH 1/1 dmaengine: fsl: remove bad channel update

Commit 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new tasklet_setup() API") broke this driver by not removing the old channel update method.

Fix this by remove the offending call as channel is queried from tasklet structure.

Fixes 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new tasklet_setup() API")
---
 drivers/dma/fsl_raid.c | 2 --
 1 file changed, 2 deletions(-)
drivers/dma/fsl_raid.c +0 -2
index 1ddd7cee2e7a..fdf3500d96a9 100644
@@ -163,8 +163,6 @@ static void fsl_re_dequeue(struct tasklet_struct *t)
 	unsigned int count, oub_count;
 	int found;
 
-	re_chan = dev_get_drvdata((struct device *)data);
-
 	fsl_re_cleanup_descs(re_chan);
 
 	spin_lock_irqsave(&re_chan->desc_lock, flags);
Signature · 1 line
2.26.2
author maintainer Applied
#1 lore raw
Quoted 6 lines · Vinod Koul

Commit 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new tasklet_setup() API") broke this driver by not removing the old channel update method.

Fix this by remove the offending call as channel is queried from tasklet structure.

Applied, thanks

Signature · 1 line
~Vinod
#2 lore raw
In reply to Vinod Koul
Quoted 27 lines

Commit 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new tasklet_setup() API") broke this driver by not removing the old channel update method.

Fix this by remove the offending call as channel is queried from tasklet structure.

Fixes 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new tasklet_setup() API")
---
 drivers/dma/fsl_raid.c | 2 --
 1 file changed, 2 deletions(-)
drivers/dma/fsl_raid.c +0 -3
index 1ddd7cee2e7a..fdf3500d96a9 100644
@@ -163,8 +163,6 @@ static void fsl_re_dequeue(struct tasklet_struct *t)
        unsigned int count, oub_count;
        int found;
 
-       re_chan = dev_get_drvdata((struct device *)data);
-
        fsl_re_cleanup_descs(re_chan);
 
        spin_lock_irqsave(&re_chan->desc_lock, flags);
--
Quoted 2 lines

2.26.2

Thank you.

Signature · 1 line
       - Allen