Skip to contentSkip to conversation

ARM: dts: am437x-l4: fix compatible for cpsw switch dt node

PATCH In review Grygorii Strashko 2 participants 3 messages Oct 1, 2020 – Nov 10, 2020 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: am437x-l4: fix compatible for cpsw switch dt node

Fix compatible the new CPSW switchdev DT node to avoid probing of legacy CPSW driver which fails:

[    2.781009] cpsw 4a100000.switch: invalid resource
Fixes 7bf8f37aea82 ("ARM: dts: am437x-l4: add dt node for new cpsw switchdev driver")

---
Hi Tony,

This is follow up patch for series [1], not critical.
[1] https://lore.kernel.org/patchwork/cover/1304085/

 arch/arm/boot/dts/am437x-l4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/am437x-l4.dtsi +1 -1
index d82a6eeaf1b3..3643e505e582 100644
@@ -522,7 +522,7 @@
 			ranges = <0x0 0x100000 0x8000>;
 
 			mac_sw: switch@0 {
-				compatible = "ti,am4372-cpsw","ti,cpsw-switch";
+				compatible = "ti,am4372-cpsw-switch", "ti,cpsw-switch";
 				reg = <0x0 0x4000>;
 				ranges = <0 0 0x4000>;
 				clocks = <&cpsw_125mhz_gclk>, <&dpll_clksel_mac_clk>;
Signature · 1 line
2.17.1
#1 lore raw

Hi Tony,

Quoted 11 lines · Grygorii Strashko

Fix compatible the new CPSW switchdev DT node to avoid probing of legacy CPSW driver which fails:

[    2.781009] cpsw 4a100000.switch: invalid resource
Fixes 7bf8f37aea82 ("ARM: dts: am437x-l4: add dt node for new cpsw switchdev driver")

---
Hi Tony,

This is follow up patch for series [1], not critical.
[1] https://lore.kernel.org/patchwork/cover/1304085/

Could this be merged?

Quoted 18 lines
  arch/arm/boot/dts/am437x-l4.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/am437x-l4.dtsi +1 -1
index d82a6eeaf1b3..3643e505e582 100644
@@ -522,7 +522,7 @@
  			ranges = <0x0 0x100000 0x8000>;
 
  			mac_sw: switch@0 {
-				compatible = "ti,am4372-cpsw","ti,cpsw-switch";
+				compatible = "ti,am4372-cpsw-switch", "ti,cpsw-switch";
  				reg = <0x0 0x4000>;
  				ranges = <0 0 0x4000>;
  				clocks = <&cpsw_125mhz_gclk>, <&dpll_clksel_mac_clk>;
Signature · 2 lines
Best regards,
grygorii
#2 lore raw
Quoted 12 lines · Grygorii Strashko

Hi Tony,

Quoted 9 lines · Grygorii Strashko

Fix compatible the new CPSW switchdev DT node to avoid probing of legacy CPSW driver which fails:

[    2.781009] cpsw 4a100000.switch: invalid resource
Fixes 7bf8f37aea82 ("ARM: dts: am437x-l4: add dt node for new cpsw switchdev driver")

---
Hi Tony,

Quoted 4 lines
Quoted 2 lines

This is follow up patch for series [1], not critical.
[1] https://lore.kernel.org/patchwork/cover/1304085/

Could this be merged?

Sorry for the delay, applying into fixes.

Thanks,

Tony