Skip to contentSkip to conversation

selftests/vm: fix up executable bits, and a file name

PATCH In review John Hubbard 2 participants 5 messages Oct 2, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover selftests/vm: fix up executable bits, and a file name

Hi,

Here's v2. I can't use $(CONFIG_SHELL) from the Makefile, because unfortunately this is not kbuild. So this is my proposed fix for these two glitches.

(Actually, the "Fixes:" tags in each refer to linux-next commits, so those commit hashes would ultimately need changing. But I suspect these patches will actually be merged back into Andrew's tree?)

thanks,
John Hubbard
NVIDIA

John Hubbard (2):
selftests/vm: fix: make check_config.sh executable selftests/vm: fix run_vmtest.sh: restore executable bits, and "s" in
name

 tools/testing/selftests/vm/check_config.sh                   | 0
 tools/testing/selftests/vm/{run_vmtest.sh => run_vmtests.sh} | 0
 2 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/vm/check_config.sh
 rename tools/testing/selftests/vm/{run_vmtest.sh => run_vmtests.sh} (100%)
 mode change 100644 => 100755
Signature · 1 line
2.28.0
#1 lore raw

PATCH v2 1/2 selftests/vm: fix: make check_config.sh executable

commit 30fb9454ab23 ("selftests/vm: hmm-tests: remove the libhugetlbfs dependency") created the new check_config.sh file without the execute bits set. This is a problem because the Makefile runs it with "./", so now "make" is failing in that directory.

The posted patch [1] does seem to have it as an executable file, so I'm not sure how this happened. But in any case, make check_config.sh executable again, so that "make" in selftests/vm works once again.

[1] https://lore.kernel.org/linux-doc/[email protected]/

Fixes commit 30fb9454ab23 ("selftests/vm: hmm-tests: remove the libhugetlbfs dependency")
---
 tools/testing/selftests/vm/check_config.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/vm/check_config.sh
tools/testing/selftests/vm/check_config.sh +0 -0
old mode 100644
new mode 100755
Signature · 1 line
2.28.0
#2 lore raw

PATCH v2 2/2 selftests/vm: fix run_vmtest.sh: restore executable bits, and "s" in name

In reply to John Hubbard

commit cb2ab76685d7 ("selftests/vm: rename run_vmtests --> run_vmtests.sh") changed the name of run_vmtests to run_vmtest.sh, but inadvertently dropped the executable bits.

Somehow the name is missing an "s", too. Fix both of these problems by renaming, and restoring the executable bits.

Fixes cb2ab76685d7 ("selftests/vm: rename run_vmtests --> run_vmtests.sh")
---
 tools/testing/selftests/vm/{run_vmtest.sh => run_vmtests.sh} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename tools/testing/selftests/vm/{run_vmtest.sh => run_vmtests.sh} (100%)
 mode change 100644 => 100755
tools/testing/selftests/vm/run_vmtests.sh renamed from tools/testing/selftests/vm/run_vmtest.sh +0 -0
old mode 100644
new mode 100755
similarity index 100%
rename from tools/testing/selftests/vm/run_vmtest.sh
rename to tools/testing/selftests/vm/run_vmtests.sh
Signature · 1 line
2.28.0
maintainer
#3 lore raw

Re: [PATCH v2 2/2] selftests/vm: fix run_vmtest.sh: restore executable bits, and "s" in name

Quoted 3 lines · On Fri, 2 Oct 2020 01:40:49 -0700 John Hubbard <[email protected]> wrote:

commit cb2ab76685d7 ("selftests/vm: rename run_vmtests --> run_vmtests.sh") changed the name of run_vmtests to run_vmtest.sh, but inadvertently dropped the executable bits.

We cannot depend on the x bit. Because downloading linux-foo.patch.gz and installing it with patch(1) is a supported way of obtaining Linux. And patch(1) loses the x bit.

If $(CONFIG_SHELL) is unavailable then invoking the script with "/bin/sh foo.sh" should do the trick.

Quoted 2 lines

Somehow the name is missing an "s", too. Fix both of these problems by renaming, and restoring the executable bits.

But that's what your patch did!

tools/testing/selftests/vm/{run_vmtests => run_vmtest.sh} | 0

Here: https://lkml.kernel.org/r/[email protected]

So all confused. I'll drop this version - please redo and resend when convenient?

#4 lore raw

Re: [PATCH v2 2/2] selftests/vm: fix run_vmtest.sh: restore executable bits, and "s" in name

Quoted 9 lines · Andrew Morton
Quoted 3 lines · On Fri, 2 Oct 2020 01:40:49 -0700 John Hubbard <[email protected]> wrote:

commit cb2ab76685d7 ("selftests/vm: rename run_vmtests --> run_vmtests.sh") changed the name of run_vmtests to run_vmtest.sh, but inadvertently dropped the executable bits.

We cannot depend on the x bit. Because downloading linux-foo.patch.gz and installing it with patch(1) is a supported way of obtaining Linux. And patch(1) loses the x bit.

OK. I was just hoping that, within our processes here, there's still some way to get something committed that does have the bit set. Because it's a nice touch to be able to do

./run_vmtests.sh

Not a big deal of course.

Quoted 3 lines

If $(CONFIG_SHELL) is unavailable then invoking the script with "/bin/sh foo.sh" should do the trick.

OK, I'll use that for the Makefile.

Quoted 10 lines
Quoted 3 lines

Somehow the name is missing an "s", too. Fix both of these problems by renaming, and restoring the executable bits.

But that's what your patch did!

tools/testing/selftests/vm/{run_vmtests => run_vmtest.sh} | 0

Here: https://lkml.kernel.org/r/[email protected]

Yes, the dropped "s" is my mistake!

Quoted 4 lines

So all confused. I'll drop this version - please redo and resend when convenient?

Coming up, sorry about the mess here!

thanks,

Signature · 2 lines
John Hubbard
NVIDIA