remove alloc_vm_area v4
Subsystems (10)
Hi Andrew,
this series removes alloc_vm_area, which was left over from the big vmalloc interface rework. It is a rather arkane interface, basicaly the equivalent of get_vm_area + actually faulting in all PTEs in the allocated area. It was originally addeds for Xen (which isn't modular to start with), and then grew users in zsmalloc and i915 which seems to mostly qualify as abuses of the interface, especially for i915 as a random driver should not set up PTE bits directly.
A git tree is also available here:
git://git.infradead.org/users/hch/misc.git alloc_vm_area
Gitweb:
http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/alloc_vm_area
Changes since v2:
- rebased to include the two conflicting i915 changes in drm-tip / linux-next again. No changes outside of drivers/gpu/drm/i915/
Changes since v2:
- add another missing i initialization
- rebased to mainline instead of drm-tip again
Changes since v1:
- fix a bug in the zsmalloc changes
- fix a bug and rebase to include the recent changes in i915
- add a new vmap flag that allows to free the page array and pages using vfree
- add a vfree documentation updated from Matthew
Diffstat:
arch/x86/xen/grant-table.c | 27 ++++-- drivers/gpu/drm/i915/Kconfig | 1 drivers/gpu/drm/i915/gem/i915_gem_pages.c | 131 +++++++++++++----------------- drivers/gpu/drm/i915/gt/shmem_utils.c | 76 ++++------------- drivers/xen/xenbus/xenbus_client.c | 30 +++--- include/linux/vmalloc.h | 7 - mm/Kconfig | 3 mm/memory.c | 16 ++- mm/nommu.c | 7 - mm/vmalloc.c | 123 ++++++++++++++-------------- mm/zsmalloc.c | 10 +- 11 files changed, 200 insertions(+), 231 deletions(-)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/11 mm: update the documentation for vfree
From: "Matthew Wilcox (Oracle)" <[email protected]>
* Document that you can call vfree() on an address returned from vmap()
* Remove the note about the minimum size -- the minimum size of a vmalloc allocation is one page
* Add a Context: section
* Fix capitalisation
* Reword the prohibition on calling from NMI context to avoid a double negative
--- mm/vmalloc.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)
mm/vmalloc.c +11 -10
@@ -2321,20 +2321,21 @@ static void __vfree(const void *addr) }/** -* vfree - release memory allocated by vmalloc() -* @addr: memory base address +* vfree - Release memory allocated by vmalloc() +* @addr: Memory base address * -* Free the virtually continuous memory area starting at @addr, as -* obtained from vmalloc(), vmalloc_32() or __vmalloc(). If @addr is -* NULL, no operation is performed. +* Free the virtually continuous memory area starting at @addr, as obtained +* from one of the vmalloc() family of APIs. This will usually also free the +* physical memory underlying the virtual allocation, but that memory is +* reference counted, so it will not be freed until the last user goes away. * -* Must not be called in NMI context (strictly speaking, only if we don't -* have CONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG, but making the calling -* conventions for vfree() arch-depenedent would be a really bad idea) +* If @addr is NULL, no operation is performed. * +* Context: * May sleep if called *not* from interrupt context. -* -* NOTE: assumes that the object at @addr has a size >= sizeof(llist_node) +* Must not be called in NMI context (strictly speaking, it could be +* if we have CONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG, but making the calling +* conventions for vfree() arch-depenedent would be a really bad idea). */ void vfree (const void *addr) {
Signature · 1 line
2.28.0
PATCH 2/11 mm: add a VM_MAP_PUT_PAGES flag for vmap
In reply to Christoph HellwigAdd a flag so that vmap takes ownership of the passed in page array. When vfree is called on such an allocation it will put one reference on each page, and free the page array itself.
--- include/linux/vmalloc.h | 1 + mm/vmalloc.c | 9 +++++++-- 2 files changed, 8 insertions(+), 2 deletions(-)
include/linux/vmalloc.h +1 -0
@@ -24,6 +24,7 @@ struct notifier_block; /* in notifier.h */#define VM_UNINITIALIZED 0x00000020/* vm_struct is not fully initialized */ #define VM_NO_GUARD 0x00000040/* don't add guard page */ #define VM_KASAN 0x00000080/* has allocated kasan shadow memory */ +#define VM_MAP_PUT_PAGES 0x00000100/* put pages and free array in vfree */ /* * VM_KASAN is used slighly differently depending on CONFIG_KASAN_VMALLOC.
mm/vmalloc.c +7 -2
@@ -2377,8 +2377,11 @@ EXPORT_SYMBOL(vunmap);* @flags: vm_area->flags * @prot: page protection for the mapping * -* Maps @count pages from @pages into contiguous kernel virtual -* space. +* Maps @count pages from @pages into contiguous kernel virtual space. +* If @flags contains %VM_MAP_PUT_PAGES the ownership of the pages array itself +* (which must be kmalloc or vmalloc memory) and one reference per pages in it +* are transferred from the caller to vmap(), and will be freed / dropped when +* vfree() is called on the return value. * * Return: the address of the area or %NULL on failure */
@@ -2404,6 +2407,8 @@ void *vmap(struct page **pages, unsigned int count,return NULL ; } +if (flags &VM_MAP_PUT_PAGES ) + area->pages = pages;return area->addr; }EXPORT_SYMBOL (vmap);
Signature · 6 lines
2.28.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/11 mm: add a vmap_pfn function
In reply to Christoph HellwigAdd a proper helper to remap PFNs into kernel virtual space so that drivers don't have to abuse alloc_vm_area and open coded PTE manipulation for it.
--- include/linux/vmalloc.h | 1 + mm/Kconfig | 3 +++ mm/vmalloc.c | 45 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 49 insertions(+)
include/linux/vmalloc.h +1 -0
@@ -122,6 +122,7 @@ extern void vfree_atomic(const void *addr);extern void *vmap (struct page **pages,unsigned int count,unsigned long flags,pgprot_t prot); +void *vmap_pfn (unsigned long *pfns,unsigned int count,pgprot_t prot);extern void vunmap (const void *addr); extern int remap_vmalloc_range_partial(struct vm_area_struct *vma,
mm/Kconfig +3 -0
@@ -815,6 +815,9 @@ config DEVICE_PRIVATE memory; i.e., memory that is only accessible from the device (or group of devices). You likely also want to select HMM_MIRROR. +config VMAP_PFN + bool + config FRAME_VECTOR bool
mm/vmalloc.c +45 -0
51 lines not on this page · raw message
Signature · 6 lines
2.28.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/11 mm: allow a NULL fn callback in apply_to_page_range
In reply to Christoph HellwigBesides calling the callback on each page, apply_to_page_range also has the effect of pre-faulting all PTEs for the range. To support callers that only need the pre-faulting, make the callback optional.
Based on a patch from Minchan Kim <[email protected]>.
--- mm/memory.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)
mm/memory.c +9 -7
@@ -2420,13 +2420,15 @@ static int apply_to_pte_range(struct mm_struct *mm, pmd_t *pmd,arch_enter_lazy_mmu_mode (); -do { -if (create || !pte_none (*pte)) { - err =fn (pte++, addr, data); -if (err) -break ; - } - }while (addr +=PAGE_SIZE , addr != end); +if (fn) { +do { +if (create || !pte_none (*pte)) { + err =fn (pte++, addr, data); +if (err) +break ; + } + }while (addr +=PAGE_SIZE , addr != end); + } *mask |=PGTBL_PTE_MODIFIED ;arch_leave_lazy_mmu_mode ();
Signature · 1 line
2.28.0
PATCH 5/11 zsmalloc: switch from alloc_vm_area to get_vm_area
In reply to Christoph HellwigJust manually pre-fault the PTEs using apply_to_page_range.
--- mm/zsmalloc.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
mm/zsmalloc.c +8 -2
@@ -1122,10 +1122,16 @@ static inline int __zs_cpu_up(struct mapping_area *area)*/ if (area->vm)return 0 ; - area->vm =alloc_vm_area (PAGE_SIZE *2 ,NULL ); + area->vm =get_vm_area (PAGE_SIZE *2 ,0 );if (!area->vm)return -ENOMEM ; -return 0 ; + +/* +* Populate ptes in advance to avoid pte allocation with GFP_KERNEL +* in non-preemtible context of zs_map_object. +*/ +return apply_to_page_range (&init_mm, (unsigned long )area->vm->addr, +PAGE_SIZE *2 ,NULL ,NULL ); }static inline void __zs_cpu_down (struct mapping_area *area)
Signature · 1 line
2.28.0
PATCH 6/11 drm/i915: use vmap in shmem_pin_map
In reply to Christoph Hellwigshmem_pin_map somewhat awkwardly reimplements vmap using alloc_vm_area and manual pte setup. The only practical difference is that alloc_vm_area prefeaults the vmalloc area PTEs, which doesn't seem to be required here (and could be added to vmap using a flag if actually required). Switch to use vmap, and use vfree to free both the vmalloc mapping and the page array, as well as dropping the references to each page.
--- drivers/gpu/drm/i915/gt/shmem_utils.c | 76 +++++++-------------------- 1 file changed, 18 insertions(+), 58 deletions(-)
drivers/gpu/drm/i915/gt/shmem_utils.c +18 -58
@@ -49,80 +49,40 @@ struct file *shmem_create_from_object(struct drm_i915_gem_object *obj)return file; } -static size_t shmem_npte (struct file *file) -{ -return file->f_mapping->host->i_size >>PAGE_SHIFT ; -} - -static void __shmem_unpin_map (struct file *file,void *ptr,size_t n_pte) -{ -unsigned long pfn; - -vunmap (ptr); - -for (pfn =0 ; pfn < n_pte; pfn++) { -struct page *page; - - page =shmem_read_mapping_page_gfp (file->f_mapping, pfn, -GFP_KERNEL ); -if (!WARN_ON (IS_ERR (page))) { -put_page (page); -put_page (page); - } - } -} -void *shmem_pin_map (struct file *file) { -const size_t n_pte =shmem_npte (file); -pte_t *stack[32 ], **ptes, **mem; -struct vm_struct *area; -unsigned long pfn; - - mem = stack; -if (n_pte >ARRAY_SIZE (stack)) { - mem =kvmalloc_array (n_pte,sizeof (*mem),GFP_KERNEL ); -if (!mem) -return NULL ; - } +struct page **pages; +size_t n_pages, i; +void *vaddr; - area =alloc_vm_area (n_pte <<PAGE_SHIFT , mem); -if (!area) { -if (mem != stack) -kvfree (mem); + n_pages = file->f_mapping->host->i_size >>PAGE_SHIFT ; + pages =kvmalloc_array (n_pages,sizeof (*pages),GFP_KERNEL ); +if (!pages)return NULL ; - } - ptes = mem; -for (pfn =0 ; pfn < n_pte; pfn++) { -struct page *page; - - page =shmem_read_mapping_page_gfp (file->f_mapping, pfn, -GFP_KERNEL ); -if (IS_ERR (page)) +for (i =0 ; i < n_pages; i++) { + pages[i] =shmem_read_mapping_page_gfp (file->f_mapping, i, +GFP_KERNEL ); +if (IS_ERR (pages[i])) goto err_page; - - **ptes++ =mk_pte (page,PAGE_KERNEL ); } -if (mem != stack) -kvfree (mem); - + vaddr =vmap (pages, n_pages,VM_MAP_PUT_PAGES ,PAGE_KERNEL ); +if (!vaddr) + goto err_page;mapping_set_unevictable (file->f_mapping); -return area->addr; - +return vaddr; err_page: -if (mem != stack) -kvfree (mem); - -__shmem_unpin_map (file, area->addr, pfn); +while (--i >=0 ) +put_page (pages[i]); +kvfree (pages);return NULL ; }void shmem_unpin_map (struct file *file,void *ptr) {mapping_clear_unevictable (file->f_mapping); -__shmem_unpin_map (file, ptr,shmem_npte (file)); +vfree (ptr); } static int __shmem_rw(struct file *file, loff_t off,
Signature · 1 line
2.28.0
PATCH 7/11 drm/i915: stop using kmap in i915_gem_object_map
In reply to Christoph Hellwigkmap for !PageHighmem is just a convoluted way to say page_address, and kunmap is a no-op in that case.
--- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_pages.c +2 -5
@@ -162,8 +162,6 @@ static void unmap_object(struct drm_i915_gem_object *obj, void *ptr) {if (is_vmalloc_addr (ptr))vunmap (ptr); -else -kunmap (kmap_to_page (ptr)); } struct sg_table *
@@ -277,11 +275,10 @@ static void *i915_gem_object_map(struct drm_i915_gem_object *obj,* forever. * * So if the page is beyond the 32b boundary, make an explicit -* vmap. On 64b, this check will be optimised away as we can -* directly kmap any page on the system. +* vmap. */ if (!PageHighMem (page)) -return kmap (page); +return page_address (page); } mem = stack;
Signature · 1 line
2.28.0
PATCH 8/11 drm/i915: use vmap in i915_gem_object_map
In reply to Christoph Hellwigi915_gem_object_map implements fairly low-level vmap functionality in a driver. Split it into two helpers, one for remapping kernel memory which can use vmap, and one for I/O memory that uses vmap_pfn.
The only practical difference is that alloc_vm_area prefeaults the vmalloc area PTEs, which doesn't seem to be required here for the kernel memory case (and could be added to vmap using a flag if actually required).
--- drivers/gpu/drm/i915/Kconfig | 1 + drivers/gpu/drm/i915/gem/i915_gem_pages.c | 127 ++++++++++------------ 2 files changed, 60 insertions(+), 68 deletions(-)
drivers/gpu/drm/i915/Kconfig +1 -0
@@ -25,6 +25,7 @@ config DRM_I915 select CRC32 select SND_HDA_I915 if SND_HDA_CORE select CEC_CORE if CEC_NOTIFIER + select VMAP_PFN help Choose this option if you have a system that has "Intel Graphics Media Accelerator" or "HD Graphics" integrated graphics,
drivers/gpu/drm/i915/gem/i915_gem_pages.c +59 -68
160 lines not on this page · raw message
Signature · 6 lines
2.28.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 9/11 xen/xenbus: use apply_to_page_range directly in xenbus_map_ring_pv
In reply to Christoph HellwigReplacing alloc_vm_area with get_vm_area_caller + apply_page_range allows to fill put the phys_addr values directly instead of doing another loop over all addresses.
--- drivers/xen/xenbus/xenbus_client.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-)
drivers/xen/xenbus/xenbus_client.c +16 -14
@@ -73,16 +73,13 @@ struct map_ring_valloc {struct xenbus_map_node *node;/* Why do we need two arrays? See comment of __xenbus_map_ring */ -union { -unsigned long addrs[XENBUS_MAX_RING_GRANTS ]; -pte_t *ptes[XENBUS_MAX_RING_GRANTS ]; - }; +unsigned long addrs[XENBUS_MAX_RING_GRANTS ];phys_addr_t phys_addrs[XENBUS_MAX_RING_GRANTS ];struct gnttab_map_grant_ref map[XENBUS_MAX_RING_GRANTS ];struct gnttab_unmap_grant_ref unmap[XENBUS_MAX_RING_GRANTS ]; -unsigned int idx;/* HVM only. */ +unsigned int idx; };static DEFINE_SPINLOCK (xenbus_valloc_lock);
@@ -686,6 +683,14 @@ int xenbus_unmap_ring_vfree(struct xenbus_device *dev, void *vaddr)EXPORT_SYMBOL_GPL (xenbus_unmap_ring_vfree);#ifdef CONFIG_XEN_PV +static int map_ring_apply (pte_t *pte,unsigned long addr,void *data) +{ +struct map_ring_valloc *info = data; + + info->phys_addrs[info->idx++] =arbitrary_virt_to_machine (pte).maddr; +return 0 ; +} + static int xenbus_map_ring_pv(struct xenbus_device *dev, struct map_ring_valloc *info, grant_ref_t *gnt_refs,
@@ -694,18 +699,15 @@ static int xenbus_map_ring_pv(struct xenbus_device *dev, {struct xenbus_map_node *node = info->node;struct vm_struct *area; -int err = GNTST_okay; -int i; -bool leaked; +bool leaked = false; +int err = -ENOMEM ; - area =alloc_vm_area (XEN_PAGE_SIZE * nr_grefs, info->ptes); + area =get_vm_area (XEN_PAGE_SIZE * nr_grefs,VM_IOREMAP );if (!area)return -ENOMEM ; - -for (i =0 ; i < nr_grefs; i++) - info->phys_addrs[i] = -arbitrary_virt_to_machine (info->ptes[i]).maddr; - +if (apply_to_page_range (&init_mm, (unsigned long )area->addr, +XEN_PAGE_SIZE * nr_grefs, map_ring_apply, info)) + goto failed; err =__xenbus_map_ring (dev, gnt_refs, nr_grefs, node->handles, info, GNTMAP_host_map | GNTMAP_contains_pte, &leaked);
Signature · 6 lines
2.28.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 10/11 x86/xen: open code alloc_vm_area in arch_gnttab_valloc
In reply to Christoph HellwigReplace the last call to alloc_vm_area with an open coded version using an iterator in struct gnttab_vm_area instead of the triple indirection magic in alloc_vm_area.
--- arch/x86/xen/grant-table.c | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-)
arch/x86/xen/grant-table.c +20 -7
@@ -25,6 +25,7 @@static struct gnttab_vm_area {struct vm_struct *area;pte_t **ptes; +int idx; } gnttab_shared_vm_area, gnttab_status_vm_area; int arch_gnttab_map_shared(unsigned long *frames, unsigned long nr_gframes,
@@ -90,19 +91,31 @@ void arch_gnttab_unmap(void *shared, unsigned long nr_gframes) } } +static int gnttab_apply (pte_t *pte,unsigned long addr,void *data) +{ +struct gnttab_vm_area *area = data; + + area->ptes[area->idx++] = pte; +return 0 ; +} +static int arch_gnttab_valloc (struct gnttab_vm_area *area,unsigned nr_frames) { area->ptes =kmalloc_array (nr_frames,sizeof (*area->ptes),GFP_KERNEL );if (area->ptes ==NULL )return -ENOMEM ; - - area->area =alloc_vm_area (PAGE_SIZE * nr_frames, area->ptes); -if (area->area ==NULL ) { -kfree (area->ptes); -return -ENOMEM ; - } - + area->area =get_vm_area (PAGE_SIZE * nr_frames,VM_IOREMAP ); +if (!area->area) + goto out_free_ptes; +if (apply_to_page_range (&init_mm, (unsigned long )area->area->addr, +PAGE_SIZE * nr_frames, gnttab_apply, area)) + goto out_free_vm_area;return 0 ; +out_free_vm_area: +free_vm_area (area->area); +out_free_ptes: +kfree (area->ptes); +return -ENOMEM ; }static void arch_gnttab_vfree (struct gnttab_vm_area *area)
Signature · 6 lines
2.28.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 11/11 mm: remove alloc_vm_area
In reply to Christoph HellwigAll users are gone now.
--- include/linux/vmalloc.h | 5 +---- mm/nommu.c | 7 ------ mm/vmalloc.c | 48 ----------------------------------------- 3 files changed, 1 insertion(+), 59 deletions(-)
include/linux/vmalloc.h +1 -4
@@ -169,6 +169,7 @@ extern struct vm_struct *__get_vm_area_caller(unsigned long size,unsigned long flags, unsigned long start, unsigned long end, const void *caller); +void free_vm_area (struct vm_struct *area);extern struct vm_struct *remove_vm_area (const void *addr);extern struct vm_struct *find_vm_area (const void *addr);
@@ -204,10 +205,6 @@ static inline void set_vm_flush_reset_perms(void *addr) }#endif -/* Allocate/destroy a 'vmalloc' VM area. */ -extern struct vm_struct *alloc_vm_area (size_t size,pte_t **ptes); -extern void free_vm_area (struct vm_struct *area); -/* for /dev/kmem */ extern long vread (char *buf,char *addr,unsigned long count);extern long vwrite (char *buf,char *addr,unsigned long count);
mm/nommu.c +0 -7
@@ -354,13 +354,6 @@ void vm_unmap_aliases(void) }EXPORT_SYMBOL_GPL (vm_unmap_aliases); -struct vm_struct *alloc_vm_area (size_t size,pte_t **ptes) -{ -BUG (); -return NULL ; -} -EXPORT_SYMBOL_GPL (alloc_vm_area); -void free_vm_area (struct vm_struct *area) {BUG ();
mm/vmalloc.c +0 -48
54 lines not on this page · raw message
Signature · 6 lines
2.28.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/11] mm: update the documentation for vfree
In reply to Christoph Hellwig== Series Details ==
== Series Details ==
Series: series starting with [01/11] mm: update the documentation for vfree
URL : https://patchwork.freedesktop.org/series/82335/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 403e54bb3db2 mm: update the documentation for vfree c01ba7b7b91e mm: add a VM_MAP_PUT_PAGES flag for vmap 31a259dcbf9f mm: add a vmap_pfn function -:78: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #78: FILE: mm/vmalloc.c:2448: + area = get_vm_area_caller(count * PAGE_SIZE, VM_IOREMAP, + __builtin_return_address(0));
-:82: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #82: FILE: mm/vmalloc.c:2452:
+ if (apply_to_page_range(&init_mm, (unsigned long)area->addr,
+ count * PAGE_SIZE, vmap_pfn_apply, &data)) {
total: 0 errors, 0 warnings, 2 checks, 67 lines checked53cab076613e mm: allow a NULL fn callback in apply_to_page_range d5f375c01071 zsmalloc: switch from alloc_vm_area to get_vm_area
-:8: WARNING:BAD_SIGN_OFF: Co-developed-by and Signed-off-by: name/email do not match #8:
total: 0 errors, 1 warnings, 0 checks, 18 lines checked 96b3d73ace0b drm/i915: use vmap in shmem_pin_mapb692d6ffb709 drm/i915: stop using kmap in i915_gem_object_map 1f9fc4cfd84c drm/i915: use vmap in i915_gem_object_map
-:49: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #49: FILE: drivers/gpu/drm/i915/gem/i915_gem_pages.c:237:
+static void *i915_gem_object_map_page(struct drm_i915_gem_object *obj,
+ enum i915_map_type type)
-:147: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #147: FILE: drivers/gpu/drm/i915/gem/i915_gem_pages.c:293:
+static void *i915_gem_object_map_pfn(struct drm_i915_gem_object *obj,
+ enum i915_map_type type)
total: 0 errors, 0 warnings, 2 checks, 167 lines checked 31cb20191c3c xen/xenbus: use apply_to_page_range directly in xenbus_map_ring_pv 90dc709c8ef1 x86/xen: open code alloc_vm_area in arch_gnttab_valloc -:53: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #53: FILE: arch/x86/xen/grant-table.c:111:
+ if (apply_to_page_range(&init_mm, (unsigned long)area->area->addr,
+ PAGE_SIZE * nr_frames, gnttab_apply, area))
total: 0 errors, 0 warnings, 1 checks, 45 lines checked 573e3a0cb122 mm: remove alloc_vm_area
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/11] mm: update the documentation for vfree
In reply to Christoph Hellwig== Series Details ==
== Series Details ==
Series: series starting with [01/11] mm: update the documentation for vfree
URL : https://patchwork.freedesktop.org/series/82335/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9092 -> Patchwork_18612
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18612 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18612, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18612:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s3:
- fi-bsw-kefka: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9092/fi-bsw-kefka/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/fi-bsw-kefka/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_18612 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@hdmi-crc-fast:
- fi-kbl-7500u: [PASS][3] -> [FAIL][4] ([i915#1372])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9092/fi-kbl-7500u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/fi-kbl-7500u/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9092/fi-byt-j1900/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/fi-byt-j1900/igt@[email protected]
* igt@vgem_basic@unload:
- fi-kbl-x1275: [PASS][7] -> [DMESG-WARN][8] ([i915#62] / [i915#92])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9092/fi-kbl-x1275/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/fi-kbl-x1275/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9092/fi-bsw-kefka/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/fi-bsw-kefka/igt@[email protected]
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9092/fi-kbl-x1275/igt@kms_busy@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/fi-kbl-x1275/igt@kms_busy@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9092/fi-icl-u2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/fi-icl-u2/igt@[email protected]
* igt@vgem_basic@unload:
- fi-skl-guc: [DMESG-WARN][15] ([i915#2203]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9092/fi-skl-guc/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/fi-skl-guc/igt@[email protected]
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#1982] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#62] / [i915#92])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9092/fi-kbl-x1275/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/fi-kbl-x1275/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][19] ([i915#62]) -> [SKIP][20] ([fdo#109271])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9092/fi-kbl-x1275/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/fi-kbl-x1275/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][21] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][22] ([i915#62] / [i915#92]) +4 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9092/fi-kbl-x1275/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/fi-kbl-x1275/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- fi-kbl-x1275: [DMESG-WARN][23] ([i915#62] / [i915#92]) -> [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9092/fi-kbl-x1275/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (45 -> 39)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9092 -> Patchwork_18612
CI-20190529: 20190529
CI_DRM_9092: 4e9a7e28ea34e4b14e66cbc53fc004e4a93f5168 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5797: 1a7ef7eb5e99c9a8f4ffbc13cdae399a01a9aa12 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18612: 573e3a0cb12237929f42c604daab6013e2f2cdff @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
573e3a0cb122 mm: remove alloc_vm_area90dc709c8ef1 x86/xen: open code alloc_vm_area in arch_gnttab_valloc 31cb20191c3c xen/xenbus: use apply_to_page_range directly in xenbus_map_ring_pv 1f9fc4cfd84c drm/i915: use vmap in i915_gem_object_map b692d6ffb709 drm/i915: stop using kmap in i915_gem_object_map 96b3d73ace0b drm/i915: use vmap in shmem_pin_mapd5f375c01071 zsmalloc: switch from alloc_vm_area to get_vm_area 53cab076613e mm: allow a NULL fn callback in apply_to_page_range 31a259dcbf9f mm: add a vmap_pfn functionc01ba7b7b91e mm: add a VM_MAP_PUT_PAGES flag for vmap403e54bb3db2 mm: update the documentation for vfree
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18612/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx