i2c: pxa: move to generic GPIO recovery
PATCH v2 1/1 i2c: pxa: move to generic GPIO recovery
Starting with
commit 75820314de26 ("i2c: core: add generic I2C GPIO recovery") GPIO bus recovery is supported by the I2C core, so we can remove the driver implementation and use that one instead.
---
This patch is not tested.
Changes in v2:
- readded the pinctrl state change to default from the unprepare_recovery callback;
drivers/i2c/busses/i2c-pxa.c | 73 +++--------------------------------- 1 file changed, 6 insertions(+), 67 deletions(-)
drivers/i2c/busses/i2c-pxa.c +6 -67
@@ -264,9 +264,6 @@ struct pxa_i2c {u32 hs_mask;struct i2c_bus_recovery_info recovery; -struct pinctrl *pinctrl; -struct pinctrl_state *pinctrl_default; -struct pinctrl_state *pinctrl_recovery; };#define _IBMR (i2c) ((i2c)->reg_ibmr)
@@ -1305,8 +1302,6 @@ static void i2c_pxa_prepare_recovery(struct i2c_adapter *adap)*/ gpiod_set_value (i2c->recovery.scl_gpiod, ibmr &IBMR_SCLS );gpiod_set_value (i2c->recovery.sda_gpiod, ibmr &IBMR_SDAS ); - -WARN_ON (pinctrl_select_state (i2c->pinctrl, i2c->pinctrl_recovery)); }static void i2c_pxa_unprepare_recovery (struct i2c_adapter *adap)
@@ -1347,76 +1342,20 @@ static int i2c_pxa_init_recovery(struct pxa_i2c *i2c)if (IS_ENABLED (CONFIG_I2C_PXA_SLAVE ))return 0 ; - i2c->pinctrl =devm_pinctrl_get (dev); -if (PTR_ERR (i2c->pinctrl) == -ENODEV ) - i2c->pinctrl =NULL ; -if (IS_ERR (i2c->pinctrl)) -return PTR_ERR (i2c->pinctrl); - -if (!i2c->pinctrl) -return 0 ; - - i2c->pinctrl_default =pinctrl_lookup_state (i2c->pinctrl, -PINCTRL_STATE_DEFAULT ); - i2c->pinctrl_recovery =pinctrl_lookup_state (i2c->pinctrl,"recovery" ); - -if (IS_ERR (i2c->pinctrl_default) ||IS_ERR (i2c->pinctrl_recovery)) { -dev_info (dev,"missing pinmux recovery information: %ld %ld\n" , -PTR_ERR (i2c->pinctrl_default), -PTR_ERR (i2c->pinctrl_recovery)); -return 0 ; - } - -/* -* Claiming GPIOs can influence the pinmux state, and may glitch the -* I2C bus. Do this carefully. -*/ - bri->scl_gpiod =devm_gpiod_get (dev,"scl" ,GPIOD_OUT_HIGH_OPEN_DRAIN ); -if (bri->scl_gpiod ==ERR_PTR (-EPROBE_DEFER )) -return -EPROBE_DEFER ; -if (IS_ERR (bri->scl_gpiod)) { -dev_info (dev,"missing scl gpio recovery information: %pe\n" , - bri->scl_gpiod); -return 0 ; - } - -/* -* We have SCL. Pull SCL low and wait a bit so that SDA glitches -* have no effect. -*/ -gpiod_direction_output (bri->scl_gpiod,0 ); -udelay (10 ); - bri->sda_gpiod =devm_gpiod_get (dev,"sda" ,GPIOD_OUT_HIGH_OPEN_DRAIN ); - -/* Wait a bit in case of a SDA glitch, and then release SCL. */ -udelay (10 ); -gpiod_direction_output (bri->scl_gpiod,1 ); - -if (bri->sda_gpiod ==ERR_PTR (-EPROBE_DEFER )) -return -EPROBE_DEFER ; - -if (IS_ERR (bri->sda_gpiod)) { -dev_info (dev,"missing sda gpio recovery information: %pe\n" , - bri->sda_gpiod); + bri->pinctrl =devm_pinctrl_get (dev); +if (PTR_ERR (bri->pinctrl) == -ENODEV ) { + bri->pinctrl =NULL ;return 0 ; } +if (IS_ERR (bri->pinctrl)) +return PTR_ERR (bri->pinctrl); bri->prepare_recovery = i2c_pxa_prepare_recovery; bri->unprepare_recovery = i2c_pxa_unprepare_recovery; - bri->recover_bus = i2c_generic_scl_recovery; i2c->adap.bus_recovery_info = bri; -/* -* Claiming GPIOs can change the pinmux state, which confuses the -* pinctrl since pinctrl's idea of the current setting is unaffected -* by the pinmux change caused by claiming the GPIO. Work around that -* by switching pinctrl to the GPIO state here. We do it this way to -* avoid glitching the I2C bus. -*/ -pinctrl_select_state (i2c->pinctrl, i2c->pinctrl_recovery); - -return pinctrl_select_state (i2c->pinctrl, i2c->pinctrl_default); +return 0 ; }static int i2c_pxa_probe (struct platform_device *dev)
Signature · 1 line
2.25.1
Quoted 5 lines · Codrin Ciubotariu
Starting with
commit75820314de26("i2c: core: add generic I2C GPIO recovery") GPIO bus recovery is supported by the I2C core, so we can remove the driver implementation and use that one instead.
Quoted 8 lines
Signed-off-by Codrin Ciubotariu <[email protected]>---
This patch is not tested.
Changes in v2:
- readded the pinctrl state change to default from theunprepare_recoverycallback;
I don't think you've build tested this patch...
drivers/i2c/busses/i2c-pxa.c struct pxa_i2c { · line 269
Quoted 11 lines
drivers/i2c/busses/i2c-pxa.c +0
-3@@ -264,9 +264,6 @@ struct pxa_i2c {u32 hs_mask;struct i2c_bus_recovery_info recovery; -struct pinctrl *pinctrl; -struct pinctrl_state *pinctrl_default; -struct pinctrl_state *pinctrl_recovery;
i2c_pxa_unprepare_recovery() refers to pinctrl and pinctrl_default which you've retained in this version of the patch, but you've deleted the members from this structure - which will lead to a build error.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Quoted 11 lines · Russell King - ARM Linux admin
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Quoted 8 lines · Codrin Ciubotariu
Starting with
commit75820314de26("i2c: core: add generic I2C GPIO recovery") GPIO bus recovery is supported by the I2C core, so we can remove the driver implementation and use that one instead.Signed-off-by Codrin Ciubotariu <[email protected]>---
Quoted 7 lines
Quoted 5 lines
This patch is not tested.
Changes in v2:
- readded the pinctrl state change to default from theunprepare_recovery callback;I don't think you've build tested this patch...
You're right, sorry about that. I used a wrong config... Will fix it right away.
Best regards,
Codrin
Quoted 17 lines
drivers/i2c/busses/i2c-pxa.c struct pxa_i2c { · line 269
Quoted 12 lines
drivers/i2c/busses/i2c-pxa.c +0
-3@@ -264,9 +264,6 @@ struct pxa_i2c {u32 hs_mask;struct i2c_bus_recovery_info recovery; -struct pinctrl *pinctrl; -struct pinctrl_state *pinctrl_default; -struct pinctrl_state *pinctrl_recovery;
i2c_pxa_unprepare_recovery()refers to pinctrl andpinctrl_defaultwhich you've retained in this version of the patch, but you've deleted the members from this structure - which will lead to a build error.
Quoted 4 lines
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel