dt-bindings: Fix 'reg' size issues in zynqmp examples
Subsystems (7)
Rob Herring
maintainerPATCH 1/1 dt-bindings: Fix 'reg' size issues in zynqmp examples
The default sizes in examples for 'reg' are 1 cell each. Fix the incorrect sizes in zynqmp examples:
Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.example.dt.yaml: example-0: dma-controller@fd4c0000:reg:0: [0, 4249616384, 0, 4096] is too long
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:0: [0, 4249485312, 0, 4096] is too long
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:1: [0, 4249526272, 0, 4096] is too long
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:2: [0, 4249530368, 0, 4096] is too long
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:3: [0, 4249534464, 0, 4096] is too long
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
--- .../bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 8 ++++---- .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml +4 -4
@@ -145,10 +145,10 @@ examples: display@fd4a0000 { compatible = "xlnx,zynqmp-dpsub-1.7"; - reg = <0x0 0xfd4a0000 0x0 0x1000>, - <0x0 0xfd4aa000 0x0 0x1000>, - <0x0 0xfd4ab000 0x0 0x1000>, - <0x0 0xfd4ac000 0x0 0x1000>; + reg = <0xfd4a0000 0x1000>, + <0xfd4aa000 0x1000>, + <0xfd4ab000 0x1000>, + <0xfd4ac000 0x1000>; reg-names = "dp", "blend", "av_buf", "aud"; interrupts = <0 119 4>; interrupt-parent = <&gic>;
Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml +1 -1
@@ -57,7 +57,7 @@ examples: dma: dma-controller@fd4c0000 { compatible = "xlnx,zynqmp-dpdma"; - reg = <0x0 0xfd4c0000 0x0 0x1000>; + reg = <0xfd4c0000 0x1000>; interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; interrupt-parent = <&gic>; clocks = <&dpdma_clk>;
Signature · 1 line
2.25.1
Hi Rob,
Quoted 51 lines · Rob Herring
The default sizes in examples for 'reg' are 1 cell each. Fix the incorrect sizes in zynqmp examples:
Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.example.dt.yaml: example-0: dma-controller@fd4c0000:reg:0: [0, 4249616384, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:0: [0, 4249485312, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:1: [0, 4249526272, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:2: [0, 4249530368, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:3: [0, 4249534464, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlCc Hyun Kwon <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Michal Simek <[email protected]>Cc Vinod Koul <[email protected]>Signed-off-by Rob Herring <[email protected]>--- .../bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 8 ++++---- .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml +4
-4@@ -145,10 +145,10 @@ examples: display@fd4a0000 { compatible = "xlnx,zynqmp-dpsub-1.7"; - reg = <0x0 0xfd4a0000 0x0 0x1000>, - <0x0 0xfd4aa000 0x0 0x1000>, - <0x0 0xfd4ab000 0x0 0x1000>, - <0x0 0xfd4ac000 0x0 0x1000>; + reg = <0xfd4a0000 0x1000>, + <0xfd4aa000 0x1000>, + <0xfd4ab000 0x1000>, + <0xfd4ac000 0x1000>; reg-names = "dp", "blend", "av_buf", "aud"; interrupts = <0 119 4>; interrupt-parent = <&gic>;Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml +0
-0
Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml examples: · line 63
Quoted 8 lines
Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml +1
-1@@ -57,7 +57,7 @@ examples: dma: dma-controller@fd4c0000 { compatible = "xlnx,zynqmp-dpdma"; - reg = <0x0 0xfd4c0000 0x0 0x1000>; + reg = <0xfd4c0000 0x1000>; interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; interrupt-parent = <&gic>; clocks = <&dpdma_clk>;
I would prefer to keep 64bit version.
I use this style.
bus {
#address-cells = <2>;
#size-cells = <2>;
...
};Thanks,
Michal
Rob Herring
maintainerQuoted 55 lines · Michal Simek
Hi Rob,
Quoted 51 lines · Rob Herring
The default sizes in examples for 'reg' are 1 cell each. Fix the incorrect sizes in zynqmp examples:
Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.example.dt.yaml: example-0: dma-controller@fd4c0000:reg:0: [0, 4249616384, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:0: [0, 4249485312, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:1: [0, 4249526272, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:2: [0, 4249530368, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:3: [0, 4249534464, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlCc Hyun Kwon <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Michal Simek <[email protected]>Cc Vinod Koul <[email protected]>Signed-off-by Rob Herring <[email protected]>--- .../bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 8 ++++---- .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml +4
-4@@ -145,10 +145,10 @@ examples: display@fd4a0000 { compatible = "xlnx,zynqmp-dpsub-1.7"; - reg = <0x0 0xfd4a0000 0x0 0x1000>, - <0x0 0xfd4aa000 0x0 0x1000>, - <0x0 0xfd4ab000 0x0 0x1000>, - <0x0 0xfd4ac000 0x0 0x1000>; + reg = <0xfd4a0000 0x1000>, + <0xfd4aa000 0x1000>, + <0xfd4ab000 0x1000>, + <0xfd4ac000 0x1000>; reg-names = "dp", "blend", "av_buf", "aud"; interrupts = <0 119 4>; interrupt-parent = <&gic>;Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml +0
-0@@ -57,7 +57,7 @@ examples:
Quoted 11 lines
Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml examples: · line 63
Quoted 8 lines
Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml +1
-1dma: dma-controller@fd4c0000 { compatible = "xlnx,zynqmp-dpdma"; - reg = <0x0 0xfd4c0000 0x0 0x1000>; + reg = <0xfd4c0000 0x1000>; interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; interrupt-parent = <&gic>; clocks = <&dpdma_clk>;I would prefer to keep 64bit version.
I use this style.
I prefer to keep the examples simple. The address size is outside the scope of the binding.
Rob
Michal Simek
Acked-byQuoted 68 lines · Rob Herring
Quoted 55 lines · Michal Simek
Hi Rob,
Quoted 51 lines · Rob Herring
The default sizes in examples for 'reg' are 1 cell each. Fix the incorrect sizes in zynqmp examples:
Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.example.dt.yaml: example-0: dma-controller@fd4c0000:reg:0: [0, 4249616384, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:0: [0, 4249485312, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:1: [0, 4249526272, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:2: [0, 4249530368, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:3: [0, 4249534464, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlCc Hyun Kwon <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Michal Simek <[email protected]>Cc Vinod Koul <[email protected]>Signed-off-by Rob Herring <[email protected]>--- .../bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 8 ++++---- .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml +4
-4@@ -145,10 +145,10 @@ examples: display@fd4a0000 { compatible = "xlnx,zynqmp-dpsub-1.7"; - reg = <0x0 0xfd4a0000 0x0 0x1000>, - <0x0 0xfd4aa000 0x0 0x1000>, - <0x0 0xfd4ab000 0x0 0x1000>, - <0x0 0xfd4ac000 0x0 0x1000>; + reg = <0xfd4a0000 0x1000>, + <0xfd4aa000 0x1000>, + <0xfd4ab000 0x1000>, + <0xfd4ac000 0x1000>; reg-names = "dp", "blend", "av_buf", "aud"; interrupts = <0 119 4>; interrupt-parent = <&gic>;Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml +0
-0@@ -57,7 +57,7 @@ examples:Quoted 11 lines
Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml examples: · line 63
Quoted 8 lines
Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml +1
-1dma: dma-controller@fd4c0000 { compatible = "xlnx,zynqmp-dpdma"; - reg = <0x0 0xfd4c0000 0x0 0x1000>; + reg = <0xfd4c0000 0x1000>; interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; interrupt-parent = <&gic>; clocks = <&dpdma_clk>;I would prefer to keep 64bit version.
I use this style.
Quoted 2 lines
I prefer to keep the examples simple. The address size is outside the scope of the binding.
ok.
Thanks,
Michal
Quoted 13 lines · Rob Herring
The default sizes in examples for 'reg' are 1 cell each. Fix the incorrect sizes in zynqmp examples:
Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.example.dt.yaml: example-0: dma-controller@fd4c0000:reg:0: [0, 4249616384, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:0: [0, 4249485312, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:1: [0, 4249526272, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:2: [0, 4249530368, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yamlDocumentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.example.dt.yaml: example-0: display@fd4a0000:reg:3: [0, 4249534464, 0, 4096] is too long
From schema:/usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
Applied, thanks
Signature · 5 lines
~Vinod _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel