Skip to contentSkip to conversation

dt-bindings: mfd: ti,j721e-system-controller: Fix incorrect pattern property

PATCH In review Rob Herring 2 participants 2 messages Oct 2, 2020 – Oct 5, 2020

Subsystems (2)
Device tree bindings Multifunction devices (MFD)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: mfd: ti,j721e-system-controller: Fix incorrect pattern property

Pattern properties go under 'patternProperties', not 'properties'. Otherwise, the pattern is treated as a literal string.

A corresponding meta-schema check has been added to catch bad DT property names like this.

Fixes e0f946915b23 ("dt-bindings: mfd: ti,j721e-system-controller.yaml: Add J721e system controller")
Cc Roger Quadros <[email protected]>
Cc Tero Kristo <[email protected]>
Cc Lee Jones <[email protected]>
Cc Kishon Vijay Abraham I <[email protected]>
Signed-off-by Rob Herring <[email protected]>
---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml +2 -2
index c8fd5d3e3071..da3d9ab758b9 100644
@@ -38,8 +38,8 @@ properties:
 
   ranges: true
 
-# Optional children
-
+patternProperties:
+  # Optional children
   "^serdes-ln-ctrl@[0-9a-f]+$":
     type: object
     description: |
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Rob Herring

Pattern properties go under 'patternProperties', not 'properties'. Otherwise, the pattern is treated as a literal string.

A corresponding meta-schema check has been added to catch bad DT property names like this.

Fixes e0f946915b23 ("dt-bindings: mfd: ti,j721e-system-controller.yaml: Add J721e system controller")
Cc Roger Quadros <[email protected]>
Cc Tero Kristo <[email protected]>
Cc Lee Jones <[email protected]>
Cc Kishon Vijay Abraham I <[email protected]>
Signed-off-by Rob Herring <[email protected]>
Quoted 3 lines
---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by Lee Jones <[email protected]>
Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog