Skip to contentSkip to conversation

perl: fix ptest test count

PATCH In review Lee Chee Yang 3 participants 4 messages Oct 5, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perl: fix ptest test count

From: Chee Yang Lee <[email protected]>

patche added in commit c2710903859a5545aa9dd56251f61667ee8d80bd failed ptest perl.t/re/pat. The patch updates incorrect test cases count causes the ptest to fail.
864 test cases before apply the patch while the patch added only 4 test cases so it should be 868 instead of 873.

ptest-runner log :-
PASS: t/re/overload
# Looks like you planned 873 tests but ran 868.
FAIL: t/re/pat
PASS: t/re/pat_advanced

[YOCTO #14071]

---
 meta/recipes-devtools/perl/files/CVE-2020-12723.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/perl/files/CVE-2020-12723.patch +1 -1
index ad195cffab..d25f4d4a74 100644
@@ -265,7 +265,7 @@ index 6a868f4..2869b58 100644
  skip_all_without_unicode_tables();
  
 -plan tests => 864;  # Update this when adding/deleting tests.
-+plan tests => 873;  # Update this when adding/deleting tests.
++plan tests => 868;  # Update this when adding/deleting tests.
  
  run_tests() unless caller;
  
Signature · 1 line
2.17.1
#1 lore raw

Hello,

Is this fix meant for dunfell, or master or both? The bug is filed against master.

Alex

Quoted 42 lines · Lee Chee Yang

From: Chee Yang Lee <[email protected]>

patche added in commit c2710903859a5545aa9dd56251f61667ee8d80bd failed ptest perl.t/re/pat. The patch updates incorrect test cases count causes the ptest to fail.
864 test cases before apply the patch while the patch added only 4 test cases so it should be 868 instead of 873.

ptest-runner log :-
PASS: t/re/overload
# Looks like you planned 873 tests but ran 868.
FAIL: t/re/pat
PASS: t/re/pat_advanced

[YOCTO #14071]

---
 meta/recipes-devtools/perl/files/CVE-2020-12723.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/perl/files/CVE-2020-12723.patch +1 -2
index ad195cffab..d25f4d4a74 100644
@@ -265,7 +265,7 @@ index 6a868f4..2869b58 100644
  skip_all_without_unicode_tables();
 
 -plan tests => 864;  # Update this when adding/deleting tests.
-+plan tests => 873;  # Update this when adding/deleting tests.
++plan tests => 868;  # Update this when adding/deleting tests.
 
  run_tests() unless caller;
 
--

2.17.1

#2 lore raw

For Dunfell only

From: Alexander Kanavin <[email protected]>
Sent: Monday, 5 October, 2020 5:37 PM
To: Lee, Chee Yang <[email protected]>
Cc: OE-core <[email protected]>
Subject: Re: [OE-core] [PATCH][dunfell] perl: fix ptest test count

Hello,

Is this fix meant for dunfell, or master or both? The bug is filed against master.

Alex

On Mon, 5 Oct 2020 at 10:41, Lee Chee Yang <[email protected]<mailto:[email protected]>> wrote:
From: Chee Yang Lee <[email protected]<mailto:[email protected]>>

patche added in commit c2710903859a5545aa9dd56251f61667ee8d80bd failed ptest perl.t/re/pat. The patch updates incorrect test cases count causes the ptest to fail.
864 test cases before apply the patch while the patch added only 4 test cases so it should be 868 instead of 873.

ptest-runner log :-
PASS: t/re/overload
# Looks like you planned 873 tests but ran 868.
FAIL: t/re/pat
PASS: t/re/pat_advanced

[YOCTO #14071]

---
 meta/recipes-devtools/perl/files/CVE-2020-12723.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/perl/files/CVE-2020-12723.patch +1 -1
index ad195cffab..d25f4d4a74 100644
@@ -265,7 +265,7 @@ index 6a868f4..2869b58 100644
  skip_all_without_unicode_tables();
 
 -plan tests => 864;  # Update this when adding/deleting tests.
-+plan tests => 873;  # Update this when adding/deleting tests.
++plan tests => 868;  # Update this when adding/deleting tests.
 
  run_tests() unless caller;
 

--
2.17.1

#3 lore raw
In reply to Lee Chee Yang

Thanks! I tested this fix on Friday and can confirm that it fixes the problem.

I'll include this in the next batch of dunfell patches.

Steve

Quoted 41 lines · Lee Chee Yang

From: Chee Yang Lee <[email protected]>

patche added in commit c2710903859a5545aa9dd56251f61667ee8d80bd failed ptest perl.t/re/pat. The patch updates incorrect test cases count causes the ptest to fail.
864 test cases before apply the patch while the patch added only 4 test cases so it should be 868 instead of 873.

ptest-runner log :-
PASS: t/re/overload
# Looks like you planned 873 tests but ran 868.
FAIL: t/re/pat
PASS: t/re/pat_advanced

[YOCTO #14071]

---
 meta/recipes-devtools/perl/files/CVE-2020-12723.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/perl/files/CVE-2020-12723.patch +1 -2
index ad195cffab..d25f4d4a74 100644
@@ -265,7 +265,7 @@ index 6a868f4..2869b58 100644
  skip_all_without_unicode_tables();
 
 -plan tests => 864;  # Update this when adding/deleting tests.
-+plan tests => 873;  # Update this when adding/deleting tests.
++plan tests => 868;  # Update this when adding/deleting tests.
 
  run_tests() unless caller;
 
--

2.17.1